From 9e34b1cc413ffb35f37200c29ee3802f545204a6 Mon Sep 17 00:00:00 2001 From: Harshil Vasoya Date: Mon, 16 Nov 2026 17:03:41 +0530 Subject: [PATCH 1/2] fix : tool call result handling to display denied tool reasons --- .changeset/denied-tool-reason-key.md | 5 +++++ packages/assistant-ui-runtime/src/modelMessageContent.ts | 2 +- packages/assistant-ui-runtime/src/toolApproval.ts | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/denied-tool-reason-key.md diff --git a/.changeset/denied-tool-reason-key.md b/.changeset/denied-tool-reason-key.md new file mode 100644 index 0000000000..ff2ce68997 --- /dev/null +++ b/.changeset/denied-tool-reason-key.md @@ -0,0 +1,5 @@ +--- +'@truefoundry/trueforge-assistant-ui-runtime': patch +--- + +Show a denied tool call's result as `reason` instead of `error`. diff --git a/packages/assistant-ui-runtime/src/modelMessageContent.ts b/packages/assistant-ui-runtime/src/modelMessageContent.ts index 6dac303852..9b6428f871 100644 --- a/packages/assistant-ui-runtime/src/modelMessageContent.ts +++ b/packages/assistant-ui-runtime/src/modelMessageContent.ts @@ -90,7 +90,7 @@ function toolCallToPart(toolCall: SdkToolCall, context?: ToolCallContext): ToolC result = toolResult === '' ? true : toolResult; } else if (approvalDecision?.approved === false) { result = { - error: + reason: approvalDecision.reason == null || approvalDecision.reason.length === 0 ? 'Tool approval denied' : approvalDecision.reason, diff --git a/packages/assistant-ui-runtime/src/toolApproval.ts b/packages/assistant-ui-runtime/src/toolApproval.ts index d36bee5b5b..4aef0ac1ee 100644 --- a/packages/assistant-ui-runtime/src/toolApproval.ts +++ b/packages/assistant-ui-runtime/src/toolApproval.ts @@ -68,7 +68,7 @@ function applyApprovalDecisionToToolCall( return { ...part, approval, - result: { error: reason ?? 'Tool approval denied' }, + result: { reason: reason ?? 'Tool approval denied' }, isError: true, }; } From d0270bbbf358a93f55d537c3adc7121f65d08b65 Mon Sep 17 00:00:00 2001 From: Harshil Vasoya Date: Mon, 16 Nov 2026 17:07:56 +0530 Subject: [PATCH 2/2] fix : update error handling in recordToolApprovalInFold to return reason instead of error on denial --- packages/assistant-ui-runtime/test/foldPeerThreads.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts b/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts index 1da90dec2e..4d9fe52d66 100644 --- a/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts +++ b/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts @@ -735,7 +735,7 @@ describe('foldPeerThreads', () => { expect(state.ingestedEventIds).toEqual(new Set(['mcp-continue-1', 'policy-1'])); }); - it('recordToolApprovalInFold synthesizes an error result on deny', () => { + it('recordToolApprovalInFold synthesizes a reason result on deny', () => { const state = seedPendingApproval(); recordToolApprovalInFold(state, { @@ -753,7 +753,7 @@ describe('foldPeerThreads', () => { } expect(toolCall.approval?.approved).toBe(false); expect(toolCall.isError).toBe(true); - expect(toolCall.result).toEqual({ error: 'not allowed' }); + expect(toolCall.result).toEqual({ reason: 'not allowed' }); }); it('gives create_sub_agent a truthy result after empty tool.response so aui marks it complete', () => {