diff --git a/.changeset/denied-tool-reason-key.md b/.changeset/denied-tool-reason-key.md new file mode 100644 index 000000000..ff2ce6899 --- /dev/null +++ b/.changeset/denied-tool-reason-key.md @@ -0,0 +1,5 @@ +--- +'@truefoundry/trueforge-assistant-ui-runtime': patch +--- + +Show a denied tool call's result as `reason` instead of `error`. diff --git a/packages/assistant-ui-runtime/src/modelMessageContent.ts b/packages/assistant-ui-runtime/src/modelMessageContent.ts index 6dac30385..9b6428f87 100644 --- a/packages/assistant-ui-runtime/src/modelMessageContent.ts +++ b/packages/assistant-ui-runtime/src/modelMessageContent.ts @@ -90,7 +90,7 @@ function toolCallToPart(toolCall: SdkToolCall, context?: ToolCallContext): ToolC result = toolResult === '' ? true : toolResult; } else if (approvalDecision?.approved === false) { result = { - error: + reason: approvalDecision.reason == null || approvalDecision.reason.length === 0 ? 'Tool approval denied' : approvalDecision.reason, diff --git a/packages/assistant-ui-runtime/src/toolApproval.ts b/packages/assistant-ui-runtime/src/toolApproval.ts index d36bee5b5..4aef0ac1e 100644 --- a/packages/assistant-ui-runtime/src/toolApproval.ts +++ b/packages/assistant-ui-runtime/src/toolApproval.ts @@ -68,7 +68,7 @@ function applyApprovalDecisionToToolCall( return { ...part, approval, - result: { error: reason ?? 'Tool approval denied' }, + result: { reason: reason ?? 'Tool approval denied' }, isError: true, }; } diff --git a/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts b/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts index 01bc260e9..deefb2484 100644 --- a/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts +++ b/packages/assistant-ui-runtime/test/foldPeerThreads.test.ts @@ -735,7 +735,7 @@ describe('foldPeerThreads', () => { expect(state.ingestedEventIds).toEqual(new Set(['mcp-continue-1', 'policy-1'])); }); - it('recordToolApprovalInFold synthesizes an error result on deny', () => { + it('recordToolApprovalInFold synthesizes a reason result on deny', () => { const state = seedPendingApproval(); recordToolApprovalInFold(state, { @@ -753,7 +753,7 @@ describe('foldPeerThreads', () => { } expect(toolCall.approval?.approved).toBe(false); expect(toolCall.isError).toBe(true); - expect(toolCall.result).toEqual({ error: 'not allowed' }); + expect(toolCall.result).toEqual({ reason: 'not allowed' }); }); it('gives create_sub_agent a truthy result after empty tool.response so aui marks it complete', () => {