codeql/javascript/ql/test/library-tests/frameworks/AsyncPackage/waterfall.js at 575da5c31c8909a99a64dc20571bb7c23aa22635 · trailofbits/codeql · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
let async_ = require('async');
let waterfall = require('a-sync-waterfall');

function source() {
    return 'TAINT'
}

function sink(x) {
    console.log(x)
}

var somethingWrong;

async_.waterfall([
    function(callback) {
      callback(null, 'safe', source());
    },
    function(safe, taint, callback) {
      sink(taint); // NOT OK
      sink(safe);  // OK
      callback(null, taint, safe);
    },
    function(taint, safe, callback) {
      callback(null, taint, safe);
    }
  ],
  function finalCallback(err, taint, safe) {
    sink(taint); // NOT OK
    sink(safe);  // OK
  }
);

async_.waterfall([
    function(callback) {
      if (somethingWrong()) {
        callback(source());
      } else {
        callback(null, 'safe');
      }
    },
    function(safe, callback) {
      sink(safe); // OK
      callback(null, safe);
    }
  ],
  function(err, safe) {
    sink(err); // NOT OK
    sink(safe); // OK
  }
);

waterfall([
    function(callback) {
      callback(null, source());
    },
    function(taint, callback) {
      sink(taint); // NOT OK
      callback(null, taint);
    }
  ],
  function(err, taint) {
    sink(err); // OK
    sink(taint); // NOT OK
  }
);