From 6842d421cf941034e5480d5a8b9c4da16da708f9 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 29 Sep 2026 05:57:54 +0000 Subject: [PATCH 1/3] style: add missing @Override annotations Adds @Override to the 553 methods that CodeQL's java/missing-override-annotation flags. No behavior change; compiled at --release 8 to confirm each one really overrides. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01EZEDsWHuCKX7Cdwm6KvjpF --- .../ch/qos/logback/classic/AsyncAppender.java | 2 + .../logback/classic/BasicConfigurator.java | 1 + .../java/ch/qos/logback/classic/Level.java | 1 + .../java/ch/qos/logback/classic/Logger.java | 39 +++++++++++++++++++ .../ch/qos/logback/classic/LoggerContext.java | 3 ++ .../ch/qos/logback/classic/PatternLayout.java | 2 + .../classic/boolex/OnErrorEvaluator.java | 1 + .../classic/boolex/OnMarkerEvaluator.java | 1 + .../db/names/DefaultDBNameResolver.java | 2 + .../db/names/SimpleDBNameResolver.java | 2 + .../logback/classic/filter/LevelFilter.java | 1 + .../classic/filter/ThresholdFilter.java | 1 + .../classic/html/DefaultCssBuilder.java | 1 + .../html/DefaultThrowableRenderer.java | 1 + .../qos/logback/classic/html/HTMLLayout.java | 2 + .../logback/classic/html/UrlCssBuilder.java | 1 + .../joran/action/ContextNameAction.java | 3 ++ .../classic/joran/action/LevelAction.java | 2 + .../classic/joran/action/LoggerAction.java | 2 + .../joran/action/RootLoggerAction.java | 2 + .../logback/classic/layout/TTLLLayout.java | 1 + .../qos/logback/classic/log4j/XMLLayout.java | 1 + ...ggingEventPreSerializationTransformer.java | 1 + .../qos/logback/classic/net/ReceiverBase.java | 3 ++ .../qos/logback/classic/net/SMTPAppender.java | 4 ++ .../classic/net/SSLSocketAppender.java | 1 + .../classic/net/SSLSocketReceiver.java | 2 + .../classic/net/SimpleSocketServer.java | 1 + .../logback/classic/net/SocketAppender.java | 1 + .../qos/logback/classic/net/SocketNode.java | 1 + .../logback/classic/net/SocketReceiver.java | 4 ++ .../logback/classic/net/SyslogAppender.java | 2 + .../server/RemoteAppenderStreamClient.java | 3 ++ .../net/server/SSLServerSocketReceiver.java | 2 + .../net/server/ServerSocketReceiver.java | 2 + .../classic/pattern/CallerDataConverter.java | 2 + .../pattern/ClassNameOnlyAbbreviator.java | 1 + .../pattern/ClassOfCallerConverter.java | 1 + .../classic/pattern/ContextNameConverter.java | 1 + .../classic/pattern/DateConverter.java | 2 + .../pattern/EnsureExceptionHandling.java | 1 + .../pattern/FileOfCallerConverter.java | 1 + .../classic/pattern/LevelConverter.java | 1 + .../pattern/LineOfCallerConverter.java | 1 + .../pattern/LineSeparatorConverter.java | 1 + .../classic/pattern/LoggerConverter.java | 1 + .../classic/pattern/MarkerConverter.java | 1 + .../classic/pattern/MessageConverter.java | 1 + .../pattern/MethodOfCallerConverter.java | 1 + .../classic/pattern/NamedConverter.java | 2 + .../NopThrowableInformationConverter.java | 1 + .../classic/pattern/PropertyConverter.java | 2 + .../pattern/RelativeTimeConverter.java | 1 + .../classic/pattern/SyslogStartConverter.java | 2 + ...TargetLengthBasedClassNameAbbreviator.java | 1 + .../classic/pattern/ThreadConverter.java | 1 + .../pattern/ThrowableProxyConverter.java | 3 ++ .../selector/DefaultContextSelector.java | 5 +++ .../sift/AppenderFactoryUsingJoran.java | 1 + .../sift/ContextBasedDiscriminator.java | 2 + .../classic/sift/MDCBasedDiscriminator.java | 2 + .../qos/logback/classic/sift/SiftAction.java | 1 + .../logback/classic/sift/SiftingAppender.java | 1 + .../sift/SiftingJoranConfigurator.java | 1 + .../logback/classic/spi/ILoggingEvent.java | 1 + .../logback/classic/spi/LoggerComparator.java | 1 + .../qos/logback/classic/spi/LoggingEvent.java | 15 +++++++ .../logback/classic/spi/LoggingEventVO.java | 15 +++++++ .../logback/classic/spi/ThrowableProxy.java | 6 +++ .../logback/classic/spi/ThrowableProxyVO.java | 6 +++ .../classic/turbo/LRUMessageCache.java | 1 + .../turbo/ReconfigureOnChangeFilter.java | 1 + .../logback/classic/turbo/TurboFilter.java | 3 ++ .../classic/util/LogbackMDCAdapter.java | 6 +++ .../ch/qos/logback/core/AppenderBase.java | 11 ++++++ .../qos/logback/core/AsyncAppenderBase.java | 8 ++++ .../qos/logback/core/BasicStatusManager.java | 8 ++++ .../java/ch/qos/logback/core/Context.java | 2 + .../java/ch/qos/logback/core/ContextBase.java | 14 +++++++ .../ch/qos/logback/core/FileAppender.java | 1 + .../java/ch/qos/logback/core/LayoutBase.java | 10 +++++ .../logback/core/OutputStreamAppender.java | 2 + .../core/UnsynchronizedAppenderBase.java | 11 ++++++ .../core/boolex/EventEvaluatorBase.java | 5 +++ .../qos/logback/core/encoder/EncoderBase.java | 3 ++ .../core/encoder/LayoutWrappingEncoder.java | 4 ++ .../logback/core/filter/EvaluatorFilter.java | 1 + .../ch/qos/logback/core/filter/Filter.java | 3 ++ .../core/hook/DefaultShutdownHook.java | 1 + .../qos/logback/core/html/HTMLLayoutBase.java | 2 + .../action/AbstractEventEvaluatorAction.java | 2 + .../qos/logback/core/joran/action/Action.java | 1 + .../core/joran/action/AppenderAction.java | 2 + .../core/joran/action/AppenderRefAction.java | 2 + .../joran/action/ConversionRuleAction.java | 2 + .../joran/action/DefinePropertyAction.java | 2 + .../logback/core/joran/action/NOPAction.java | 2 + .../joran/action/NestedBasicPropertyIA.java | 4 ++ .../joran/action/NestedComplexPropertyIA.java | 3 ++ .../core/joran/action/NewRuleAction.java | 2 + .../core/joran/action/ParamAction.java | 2 + .../core/joran/action/PropertyAction.java | 2 + .../joran/action/StatusListenerAction.java | 2 + .../core/joran/event/SaxEventRecorder.java | 17 ++++++++ .../core/joran/spi/InterpretationContext.java | 2 + .../core/joran/spi/SimpleRuleStore.java | 4 ++ .../core/net/AbstractSSLSocketAppender.java | 2 + .../core/net/AbstractSocketAppender.java | 3 ++ .../core/net/DefaultSocketConnector.java | 4 ++ .../logback/core/net/LoginAuthenticator.java | 1 + .../logback/core/net/SMTPAppenderBase.java | 4 ++ .../core/net/SSLSocketAppenderBase.java | 2 + .../qos/logback/core/net/SocketConnector.java | 1 + .../logback/core/net/SocketConnectorBase.java | 5 +++ .../logback/core/net/SyslogAppenderBase.java | 1 + .../logback/core/net/SyslogOutputStream.java | 3 ++ .../server/AbstractServerSocketAppender.java | 1 + .../qos/logback/core/net/server/Client.java | 1 + .../net/server/ConcurrentServerRunner.java | 7 ++++ .../server/RemoteReceiverStreamClient.java | 4 ++ .../server/SSLServerSocketAppenderBase.java | 2 + .../core/net/server/ServerListener.java | 1 + .../net/server/ServerSocketAppenderBase.java | 1 + .../core/net/server/ServerSocketListener.java | 2 + .../net/ssl/SSLConfigurableServerSocket.java | 8 ++++ .../core/net/ssl/SSLConfigurableSocket.java | 8 ++++ .../core/pattern/CompositeConverter.java | 2 + .../core/pattern/DynamicConverter.java | 12 ++++++ .../qos/logback/core/pattern/FormatInfo.java | 2 + .../core/pattern/LiteralConverter.java | 1 + .../core/pattern/PatternLayoutBase.java | 2 + .../pattern/ReplacingCompositeConverter.java | 1 + .../core/pattern/parser/CompositeNode.java | 2 + .../core/pattern/parser/FormattingNode.java | 1 + .../qos/logback/core/pattern/parser/Node.java | 2 + .../pattern/parser/SimpleKeywordNode.java | 2 + .../logback/core/pattern/parser/Token.java | 3 ++ .../pattern/util/AlmostAsIsEscapeUtil.java | 1 + .../core/pattern/util/AsIsEscapeUtil.java | 1 + .../core/pattern/util/RegularEscapeUtil.java | 1 + .../pattern/util/RestrictedEscapeUtil.java | 1 + .../property/FileExistsPropertyDefiner.java | 1 + .../ResourceExistsPropertyDefiner.java | 1 + .../core/read/CyclicBufferAppender.java | 2 + .../recovery/ResilientOutputStreamBase.java | 1 + ...imeBasedFileNamingAndTriggeringPolicy.java | 1 + .../rolling/FixedWindowRollingPolicy.java | 3 ++ .../core/rolling/RollingFileAppender.java | 1 + .../core/rolling/RollingPolicyBase.java | 5 +++ .../rolling/SizeBasedTriggeringPolicy.java | 1 + ...asedFileNamingAndTriggeringPolicyBase.java | 9 +++++ .../core/rolling/TimeBasedRollingPolicy.java | 4 ++ .../core/rolling/TriggeringPolicyBase.java | 3 ++ .../core/rolling/helper/Compressor.java | 1 + .../core/rolling/helper/DateParser.java | 1 + .../rolling/helper/DateTokenConverter.java | 3 ++ .../rolling/helper/DefaultFileProvider.java | 6 +++ .../core/rolling/helper/FileFilterUtil.java | 1 + .../core/rolling/helper/FileFinder.java | 4 ++ .../core/rolling/helper/FileNamePattern.java | 1 + .../core/rolling/helper/IntParser.java | 1 + .../rolling/helper/IntegerTokenConverter.java | 2 + .../helper/TimeBasedArchiveRemover.java | 5 +++ .../AbstractAppenderFactoryUsingJoran.java | 1 + .../core/sift/AbstractDiscriminator.java | 3 ++ .../core/sift/DefaultDiscriminator.java | 2 + .../sift/SiftingJoranConfiguratorBase.java | 1 + .../core/spi/AbstractComponentTracker.java | 10 +++++ .../core/spi/AppenderAttachableImpl.java | 7 ++++ .../logback/core/spi/ContextAwareBase.java | 9 +++++ .../logback/core/spi/ContextAwareImpl.java | 9 +++++ .../core/spi/FilterAttachableImpl.java | 4 ++ .../qos/logback/core/spi/ScanException.java | 1 + .../OnPrintStreamStatusListenerBase.java | 4 ++ .../qos/logback/core/status/StatusBase.java | 10 +++++ .../core/util/ExecutorServiceUtil.java | 1 + .../ch/qos/logback/core/util/FixedDelay.java | 1 + .../java/ch/qos/logback/core/util/Loader.java | 2 + .../org/slf4j/impl/StaticLoggerBinder.java | 1 + .../org/slf4j/impl/StaticMarkerBinder.java | 2 + 180 files changed, 553 insertions(+) diff --git a/logback-android/src/main/java/ch/qos/logback/classic/AsyncAppender.java b/logback-android/src/main/java/ch/qos/logback/classic/AsyncAppender.java index 9c888c9a3b..e4de2a1f4a 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/AsyncAppender.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/AsyncAppender.java @@ -37,11 +37,13 @@ public class AsyncAppender extends AsyncAppenderBase { * @param event * @return true if the event is of level TRACE, DEBUG or INFO false otherwise. */ + @Override protected boolean isDiscardable(ILoggingEvent event) { Level level = event.getLevel(); return level.toInt() <= Level.INFO_INT; } + @Override protected void preprocess(ILoggingEvent eventObject) { eventObject.prepareForDeferredProcessing(); if(includeCallerData) diff --git a/logback-android/src/main/java/ch/qos/logback/classic/BasicConfigurator.java b/logback-android/src/main/java/ch/qos/logback/classic/BasicConfigurator.java index 12890d08e8..6327c1dee8 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/BasicConfigurator.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/BasicConfigurator.java @@ -36,6 +36,7 @@ public class BasicConfigurator extends ContextAwareBase implements Configurator public BasicConfigurator() { } + @Override public void configure(LoggerContext lc) { addInfo("Setting up default configuration."); ConsoleAppender ca = new ConsoleAppender(); diff --git a/logback-android/src/main/java/ch/qos/logback/classic/Level.java b/logback-android/src/main/java/ch/qos/logback/classic/Level.java index 48d3801088..0ac53dc82f 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/Level.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/Level.java @@ -96,6 +96,7 @@ private Level(int levelInt, String levelStr) { * Returns the string representation of this Level. * @return the string value of this level */ + @Override public String toString() { return levelStr; } diff --git a/logback-android/src/main/java/ch/qos/logback/classic/Logger.java b/logback-android/src/main/java/ch/qos/logback/classic/Logger.java index 95cd38dea4..b796c3d598 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/Logger.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/Logger.java @@ -122,6 +122,7 @@ public Level getLevel() { return level; } + @Override public String getName() { return name; } @@ -207,12 +208,14 @@ private synchronized void handleParentLevelChange(int newParentLevelInt) { *

* This is useful when re-reading configuration information. */ + @Override public void detachAndStopAllAppenders() { if (aai != null) { aai.detachAndStopAllAppenders(); } } + @Override public boolean detachAppender(String name) { if (aai == null) { return false; @@ -222,6 +225,7 @@ public boolean detachAppender(String name) { // this method MUST be synchronized. See comments on 'aai' field for further // details. + @Override public synchronized void addAppender(Appender newAppender) { if (aai == null) { aai = new AppenderAttachableImpl(); @@ -229,6 +233,7 @@ public synchronized void addAppender(Appender newAppender) { aai.addAppender(newAppender); } + @Override public boolean isAttached(Appender appender) { if (aai == null) { return false; @@ -237,6 +242,7 @@ public boolean isAttached(Appender appender) { } @SuppressWarnings("unchecked") + @Override public Iterator> iteratorForAppenders() { if (aai == null) { return Collections.EMPTY_LIST.iterator(); @@ -244,6 +250,7 @@ public Iterator> iteratorForAppenders() { return aai.iteratorForAppenders(); } + @Override public Appender getAppender(String name) { if (aai == null) { return null; @@ -282,6 +289,7 @@ private int appendLoopOnAppenders(ILoggingEvent event) { /** * Remove the appender passed as parameter form the list of appenders. */ + @Override public boolean detachAppender(Appender appender) { if (aai == null) { return false; @@ -439,22 +447,27 @@ private void buildLoggingEventAndAppend(final String localFQCN, callAppenders(le); } + @Override public void trace(String msg) { filterAndLog_0_Or3Plus(FQCN, null, Level.TRACE, msg, null, null); } + @Override public void trace(String format, Object arg) { filterAndLog_1(FQCN, null, Level.TRACE, format, arg, null); } + @Override public void trace(String format, Object arg1, Object arg2) { filterAndLog_2(FQCN, null, Level.TRACE, format, arg1, arg2, null); } + @Override public void trace(String format, Object... argArray) { filterAndLog_0_Or3Plus(FQCN, null, Level.TRACE, format, argArray, null); } + @Override public void trace(String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, null, Level.TRACE, msg, null, t); } @@ -509,6 +522,7 @@ public void trace(List markers, String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, markers, Level.TRACE, msg, null, t); } + @Override public boolean isDebugEnabled() { return isDebugEnabled(Collections.emptyList()); } @@ -526,22 +540,27 @@ public boolean isDebugEnabled(List markers) { } } + @Override public void debug(String msg) { filterAndLog_0_Or3Plus(FQCN, null, Level.DEBUG, msg, null, null); } + @Override public void debug(String format, Object arg) { filterAndLog_1(FQCN, null, Level.DEBUG, format, arg, null); } + @Override public void debug(String format, Object arg1, Object arg2) { filterAndLog_2(FQCN, null, Level.DEBUG, format, arg1, arg2, null); } + @Override public void debug(String format, Object... argArray) { filterAndLog_0_Or3Plus(FQCN, null, Level.DEBUG, format, argArray, null); } + @Override public void debug(String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, null, Level.DEBUG, msg, null, t); } @@ -596,22 +615,27 @@ public void debug(List markers, String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, markers, Level.DEBUG, msg, null, t); } + @Override public void error(String msg) { filterAndLog_0_Or3Plus(FQCN, null, Level.ERROR, msg, null, null); } + @Override public void error(String format, Object arg) { filterAndLog_1(FQCN, null, Level.ERROR, format, arg, null); } + @Override public void error(String format, Object arg1, Object arg2) { filterAndLog_2(FQCN, null, Level.ERROR, format, arg1, arg2, null); } + @Override public void error(String format, Object... argArray) { filterAndLog_0_Or3Plus(FQCN, null, Level.ERROR, format, argArray, null); } + @Override public void error(String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, null, Level.ERROR, msg, null, t); } @@ -666,6 +690,7 @@ public void error(List markers, String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, markers, Level.ERROR, msg, null, t); } + @Override public boolean isInfoEnabled() { return isInfoEnabled(Collections.emptyList()); } @@ -683,22 +708,27 @@ public boolean isInfoEnabled(List markers) { } } + @Override public void info(String msg) { filterAndLog_0_Or3Plus(FQCN, null, Level.INFO, msg, null, null); } + @Override public void info(String format, Object arg) { filterAndLog_1(FQCN, null, Level.INFO, format, arg, null); } + @Override public void info(String format, Object arg1, Object arg2) { filterAndLog_2(FQCN, null, Level.INFO, format, arg1, arg2, null); } + @Override public void info(String format, Object... argArray) { filterAndLog_0_Or3Plus(FQCN, null, Level.INFO, format, argArray, null); } + @Override public void info(String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, null, Level.INFO, msg, null, t); } @@ -753,6 +783,7 @@ public void info(List markers, String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, markers, Level.INFO, msg, null, t); } + @Override public boolean isTraceEnabled() { return isTraceEnabled(Collections.emptyList()); } @@ -770,6 +801,7 @@ public boolean isTraceEnabled(List markers) { } } + @Override public boolean isErrorEnabled() { return isErrorEnabled(Collections.emptyList()); } @@ -787,6 +819,7 @@ public boolean isErrorEnabled(List markers) { } } + @Override public boolean isWarnEnabled() { return isWarnEnabled(Collections.emptyList()); } @@ -822,10 +855,12 @@ public boolean isEnabledFor(Level level) { return isEnabledFor(null, level); } + @Override public void warn(String msg) { filterAndLog_0_Or3Plus(FQCN, null, Level.WARN, msg, null, null); } + @Override public void warn(String msg, Throwable t) { filterAndLog_0_Or3Plus(FQCN, null, Level.WARN, msg, null, t); } @@ -860,14 +895,17 @@ public void warn(Marker marker, String msg, Throwable t) { warn(Collections.singletonList(marker), msg, t); } + @Override public void warn(String format, Object arg) { filterAndLog_1(FQCN, null, Level.WARN, format, arg, null); } + @Override public void warn(String format, Object arg1, Object arg2) { filterAndLog_2(FQCN, null, Level.WARN, format, arg1, arg2, null); } + @Override public void warn(String format, Object... argArray) { filterAndLog_0_Or3Plus(FQCN, null, Level.WARN, format, argArray, null); } @@ -900,6 +938,7 @@ public void setAdditive(boolean additive) { this.additive = additive; } + @Override public String toString() { return "Logger[" + name + "]"; } diff --git a/logback-android/src/main/java/ch/qos/logback/classic/LoggerContext.java b/logback-android/src/main/java/ch/qos/logback/classic/LoggerContext.java index 7876f48905..152891f007 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/LoggerContext.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/LoggerContext.java @@ -116,6 +116,7 @@ public final Logger getLogger(final Class clazz) { return getLogger(clazz.getName()); } + @Override public Logger getLogger(final String name) { if (name == null) { @@ -350,11 +351,13 @@ private void fireOnStop() { // === end listeners ============================================== + @Override public void start() { super.start(); fireOnStart(); } + @Override public void stop() { reset(); fireOnStop(); diff --git a/logback-android/src/main/java/ch/qos/logback/classic/PatternLayout.java b/logback-android/src/main/java/ch/qos/logback/classic/PatternLayout.java index b89a074508..2add84c011 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/PatternLayout.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/PatternLayout.java @@ -139,10 +139,12 @@ public PatternLayout() { this.postCompileProcessor = new EnsureExceptionHandling(); } + @Override public Map getDefaultConverterMap() { return defaultConverterMap; } + @Override public String doLayout(ILoggingEvent event) { if (!isStarted()) { return CoreConstants.EMPTY_STRING; diff --git a/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnErrorEvaluator.java b/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnErrorEvaluator.java index 9d7a6e262f..90e84b5869 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnErrorEvaluator.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnErrorEvaluator.java @@ -33,6 +33,7 @@ public class OnErrorEvaluator extends EventEvaluatorBase { * Return true if event passed as parameter has level ERROR or higher, returns * false otherwise. */ + @Override public boolean evaluate(ILoggingEvent event) throws NullPointerException, EvaluationException { return event.getLevel().levelInt >= Level.ERROR_INT; diff --git a/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnMarkerEvaluator.java b/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnMarkerEvaluator.java index 9c47f67f0b..e82fdd28c3 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnMarkerEvaluator.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/boolex/OnMarkerEvaluator.java @@ -42,6 +42,7 @@ public void addMarker(String markerStr) { * Return true if event passed as parameter contains one of the specified * user-markers. */ + @Override public boolean evaluate(ILoggingEvent event) throws NullPointerException, EvaluationException { diff --git a/logback-android/src/main/java/ch/qos/logback/classic/db/names/DefaultDBNameResolver.java b/logback-android/src/main/java/ch/qos/logback/classic/db/names/DefaultDBNameResolver.java index edbeec2ac1..08ebe73fec 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/db/names/DefaultDBNameResolver.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/db/names/DefaultDBNameResolver.java @@ -27,10 +27,12 @@ */ public class DefaultDBNameResolver implements DBNameResolver { + @Override public > String getTableName(N tableName) { return tableName.toString().toLowerCase(Locale.US); } + @Override public > String getColumnName(N columnName) { return columnName.toString().toLowerCase(Locale.US); } diff --git a/logback-android/src/main/java/ch/qos/logback/classic/db/names/SimpleDBNameResolver.java b/logback-android/src/main/java/ch/qos/logback/classic/db/names/SimpleDBNameResolver.java index 0d6db8ad6b..0eb3550c9e 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/db/names/SimpleDBNameResolver.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/db/names/SimpleDBNameResolver.java @@ -33,10 +33,12 @@ public class SimpleDBNameResolver implements DBNameResolver { private String columnNameSuffix = ""; + @Override public > String getTableName(N tableName) { return tableNamePrefix + tableName.name().toLowerCase(Locale.US) + tableNameSuffix; } + @Override public > String getColumnName(N columnName) { return columnNamePrefix + columnName.name().toLowerCase(Locale.US) + columnNameSuffix; } diff --git a/logback-android/src/main/java/ch/qos/logback/classic/filter/LevelFilter.java b/logback-android/src/main/java/ch/qos/logback/classic/filter/LevelFilter.java index 55d10ec434..0f00e32a66 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/filter/LevelFilter.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/filter/LevelFilter.java @@ -51,6 +51,7 @@ public void setLevel(Level level) { this.level = level; } + @Override public void start() { if (this.level != null) { super.start(); diff --git a/logback-android/src/main/java/ch/qos/logback/classic/filter/ThresholdFilter.java b/logback-android/src/main/java/ch/qos/logback/classic/filter/ThresholdFilter.java index 9ad67e2cc3..0a79ae739c 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/filter/ThresholdFilter.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/filter/ThresholdFilter.java @@ -55,6 +55,7 @@ public void setLevel(String level) { this.level = Level.toLevel(level); } + @Override public void start() { if (this.level != null) { super.start(); diff --git a/logback-android/src/main/java/ch/qos/logback/classic/html/DefaultCssBuilder.java b/logback-android/src/main/java/ch/qos/logback/classic/html/DefaultCssBuilder.java index 0eccd1ca01..542f292bfa 100644 --- a/logback-android/src/main/java/ch/qos/logback/classic/html/DefaultCssBuilder.java +++ b/logback-android/src/main/java/ch/qos/logback/classic/html/DefaultCssBuilder.java @@ -29,6 +29,7 @@ */ public class DefaultCssBuilder implements CssBuilder { + @Override public void addCss(StringBuilder sbuf) { sbuf.append("