From 87c163966bb0779232d561dbc197a95e6ba7c461 Mon Sep 17 00:00:00 2001 From: ThiagoCS Date: Fri, 13 Nov 2026 11:56:43 -0300 Subject: [PATCH 1/5] feat(api): return filtered pagination totals with deterministic ordering --- apps/api/src/tasks/prisma-task.repository.ts | 8 +++++++- apps/api/src/tasks/task.types.ts | 1 + apps/api/src/tasks/tasks.routes.test.ts | 1 + apps/api/src/tasks/tasks.routes.ts | 10 ++++++++++ 4 files changed, 19 insertions(+), 1 deletion(-) diff --git a/apps/api/src/tasks/prisma-task.repository.ts b/apps/api/src/tasks/prisma-task.repository.ts index 4c8e721..ef579e3 100644 --- a/apps/api/src/tasks/prisma-task.repository.ts +++ b/apps/api/src/tasks/prisma-task.repository.ts @@ -19,7 +19,13 @@ export class PrismaTaskRepository implements TaskRepository { return this.prisma.task.findMany({ where: { status: filters.status, priority: filters.priority, ownerId: this.ownerId }, ...(filters.page !== undefined || filters.limit !== undefined ? { skip: ((filters.page ?? 1) - 1) * (filters.limit ?? 50), take: filters.limit ?? 50 } : {}), - orderBy: [{ dueAt: "asc" }, { createdAt: "desc" }], + orderBy: [{ dueAt: "asc" }, { createdAt: "desc" }, { id: "asc" }], + }); + } + + async count(filters: ListTaskFilters): Promise { + return this.prisma.task.count({ + where: { ownerId: this.ownerId, status: filters.status, priority: filters.priority }, }); } diff --git a/apps/api/src/tasks/task.types.ts b/apps/api/src/tasks/task.types.ts index 2f99a52..64e209b 100644 --- a/apps/api/src/tasks/task.types.ts +++ b/apps/api/src/tasks/task.types.ts @@ -12,6 +12,7 @@ export interface UpdateTaskInput { title?:string; description?:string|null; stat export interface ListTaskFilters { status?:TaskStatus; priority?:TaskPriority; page?:number; limit?:number; } export interface TaskRepository { list(filters:ListTaskFilters):Promise; + count?(filters:ListTaskFilters):Promise; findById(id:string):Promise; listActivities(taskId:string):Promise; /** Atomically persist the task and its creation activity. */ diff --git a/apps/api/src/tasks/tasks.routes.test.ts b/apps/api/src/tasks/tasks.routes.test.ts index c593309..7ced7e4 100644 --- a/apps/api/src/tasks/tasks.routes.test.ts +++ b/apps/api/src/tasks/tasks.routes.test.ts @@ -36,6 +36,7 @@ describe("task endpoints",()=>{ it("lists tasks and supports filters",async()=>{const response=await request(app).get("/api/v1/tasks?status=NEW");expect(response.status).toBe(200);expect(response.body.data).toHaveLength(1);}); it("validates pagination bounds without changing existing list responses",async()=>{ const valid=await request(app).get("/api/v1/tasks?page=1&limit=20&status=NEW"); + expect(valid.body.pagination).toEqual({page:1,limit:20,total:1,totalPages:1}); expect(valid.status).toBe(200); expect(valid.body.data).toEqual(expect.any(Array)); for(const query of ["page=0","page=-1","page=1.5","limit=0","limit=101","page=abc"]){ diff --git a/apps/api/src/tasks/tasks.routes.ts b/apps/api/src/tasks/tasks.routes.ts index b821392..1e3b171 100644 --- a/apps/api/src/tasks/tasks.routes.ts +++ b/apps/api/src/tasks/tasks.routes.ts @@ -26,6 +26,16 @@ export function createTasksRouter(repository: TaskRepository): Router { return; } + if (filters.data.page !== undefined || filters.data.limit !== undefined) { + const page = filters.data.page ?? 1; + const limit = filters.data.limit ?? 50; + const [data, total] = await Promise.all([ + repository.list({ ...filters.data, page, limit }), + repository.count ? repository.count(filters.data) : repository.list({ status: filters.data.status, priority: filters.data.priority }).then(items => items.length), + ]); + response.status(200).json({ data, pagination: { page, limit, total, totalPages: Math.ceil(total / limit) } }); + return; + } response.status(200).json({ data: await repository.list(filters.data) }); }); From 1bbb8f2165d71f937e3279a760a3e9e58e82cda5 Mon Sep 17 00:00:00 2001 From: ThiagoCS Date: Fri, 13 Nov 2026 11:57:03 -0300 Subject: [PATCH 2/5] test(api): verify paginated totals exclude foreign and legacy tasks --- .../src/tasks/prisma-task.repository.integration.test.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/apps/api/src/tasks/prisma-task.repository.integration.test.ts b/apps/api/src/tasks/prisma-task.repository.integration.test.ts index 9e182bf..21ee0f6 100644 --- a/apps/api/src/tasks/prisma-task.repository.integration.test.ts +++ b/apps/api/src/tasks/prisma-task.repository.integration.test.ts @@ -80,6 +80,12 @@ describe.skipIf(!process.env.TEST_DATABASE_URL)("Prisma task persistence", () => expect(list.body.data.map((task: {id:string})=>task.id)).toEqual(token==="alice"?[id]:[]); expect((await request(app).get(`/api/v1/tasks/${legacy.id}`).set("Authorization",`Bearer ${token}`)).status).toBe(404); } + const alicePage=await request(app).get("/api/v1/tasks?page=1&limit=1").set("Authorization","Bearer alice"); + const bobPage=await request(app).get("/api/v1/tasks?page=1&limit=1").set("Authorization","Bearer bob"); + expect(alicePage.body.pagination).toEqual({page:1,limit:1,total:1,totalPages:1}); + expect(alicePage.body.data.map((task: {id:string})=>task.id)).toEqual([id]); + expect(bobPage.body.pagination).toEqual({page:1,limit:1,total:0,totalPages:0}); + expect(bobPage.body.data).toEqual([]); for(const suffix of ["", "/activities"]){ expect((await request(app).get(`/api/v1/tasks/${id}${suffix}`).set("Authorization","Bearer bob")).status).toBe(404); } From fb724c3b0744b79bad926916d445b2c572163497 Mon Sep 17 00:00:00 2001 From: ThiagoCS Date: Fri, 13 Nov 2026 11:59:45 -0300 Subject: [PATCH 3/5] fix(api): require database count and remove unbounded pagination fallback --- apps/api/src/tasks/task.types.ts | 2 +- apps/api/src/tasks/tasks.routes.test.ts | 1 + apps/api/src/tasks/tasks.routes.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/api/src/tasks/task.types.ts b/apps/api/src/tasks/task.types.ts index 64e209b..315fc13 100644 --- a/apps/api/src/tasks/task.types.ts +++ b/apps/api/src/tasks/task.types.ts @@ -12,7 +12,7 @@ export interface UpdateTaskInput { title?:string; description?:string|null; stat export interface ListTaskFilters { status?:TaskStatus; priority?:TaskPriority; page?:number; limit?:number; } export interface TaskRepository { list(filters:ListTaskFilters):Promise; - count?(filters:ListTaskFilters):Promise; + count(filters:ListTaskFilters):Promise; findById(id:string):Promise; listActivities(taskId:string):Promise; /** Atomically persist the task and its creation activity. */ diff --git a/apps/api/src/tasks/tasks.routes.test.ts b/apps/api/src/tasks/tasks.routes.test.ts index 7ced7e4..d671845 100644 --- a/apps/api/src/tasks/tasks.routes.test.ts +++ b/apps/api/src/tasks/tasks.routes.test.ts @@ -10,6 +10,7 @@ class InMemoryTaskRepository implements TaskRepository { async list(filters:ListTaskFilters):Promise { return this.tasks.filter(task=>(!filters.status||task.status===filters.status)&&(!filters.priority||task.priority===filters.priority)); } + async count(filters:ListTaskFilters):Promise{return (await this.list(filters)).length;} async listActivities(taskId:string):Promise{return this.activities.filter(activity=>activity.taskId===taskId);} async addActivity(taskId:string,type:string,message:string):Promise{const activity={id:`activity-${this.activities.length+1}`,taskId,type,message,createdAt:new Date()};this.activities.push(activity);return activity;} async findById(id:string):Promise{return this.tasks.find(task=>task.id===id)??null;} diff --git a/apps/api/src/tasks/tasks.routes.ts b/apps/api/src/tasks/tasks.routes.ts index 1e3b171..05b32af 100644 --- a/apps/api/src/tasks/tasks.routes.ts +++ b/apps/api/src/tasks/tasks.routes.ts @@ -31,7 +31,7 @@ export function createTasksRouter(repository: TaskRepository): Router { const limit = filters.data.limit ?? 50; const [data, total] = await Promise.all([ repository.list({ ...filters.data, page, limit }), - repository.count ? repository.count(filters.data) : repository.list({ status: filters.data.status, priority: filters.data.priority }).then(items => items.length), + repository.count(filters.data), ]); response.status(200).json({ data, pagination: { page, limit, total, totalPages: Math.ceil(total / limit) } }); return; From 62a3090ac75c4281435d4a5ad4b62e2adc8c91a1 Mon Sep 17 00:00:00 2001 From: ThiagoCS Date: Fri, 13 Nov 2026 12:00:13 -0300 Subject: [PATCH 4/5] test(api): align app test repository with count contract --- apps/api/src/app.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/api/src/app.test.ts b/apps/api/src/app.test.ts index 3e39f55..e0de803 100644 --- a/apps/api/src/app.test.ts +++ b/apps/api/src/app.test.ts @@ -6,6 +6,7 @@ import type { TaskRepository } from "./tasks/task.types.js"; function createRepository(overrides:Partial={}):TaskRepository { return { list:async()=>[], + count:async()=>0, findById:async()=>null, listActivities:async()=>[], create:async()=>{throw new Error("secret task content should not be logged");}, From ed8c457fd975b89745673f0557267d9657bf814f Mon Sep 17 00:00:00 2001 From: ThiagoCS Date: Fri, 13 Nov 2026 12:02:46 -0300 Subject: [PATCH 5/5] fix(test): implement count in authentication repository mock --- apps/api/src/auth/authentication.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/api/src/auth/authentication.test.ts b/apps/api/src/auth/authentication.test.ts index 250f8ba..7ab133c 100644 --- a/apps/api/src/auth/authentication.test.ts +++ b/apps/api/src/auth/authentication.test.ts @@ -6,7 +6,7 @@ import type { TaskRepository } from "../tasks/task.types.js"; const owner = "11111111-1111-4111-8111-111111111111"; const repository = { - list: vi.fn(async () => []), findById: async () => null, listActivities: async () => [], + list: vi.fn(async () => []), count: vi.fn(async () => 0), findById: async () => null, listActivities: async () => [], create: async () => { throw new Error(); }, update: async () => null, delete: async () => false, } satisfies TaskRepository; const env = {SUPABASE_URL:"https://auth.example.test", SUPABASE_PUBLISHABLE_KEY:"sb_publishable_test"};