From 8302ccf272fa2ddcec8bd1d50beaddb37fe6b89a Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Sun, 20 Sep 2026 01:42:46 +0800 Subject: [PATCH 1/8] [ci] adopt Go 1.27 and authenticated coverage --- .github/workflows/build.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7a1e8a8..3d54ef7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -10,11 +10,14 @@ permissions: read-all jobs: ci: + permissions: + contents: read + id-token: write # Reusable CI lives in 1set/meta — the single source of truth for every # Star* module's pipeline. Pinned to a commit SHA for supply-chain safety; # bump the pin when meta's workflow changes (Dependabot github-actions can # automate this). - uses: 1set/meta/.github/workflows/go-ci.yml@5d86667e7264f012655dab2644dfa44e09597445 + uses: 1set/meta/.github/workflows/go-ci.yml@496f38088eff1a37bae1b43d158146a8a9d83a37 with: go-floor: "1.19" doc-coverage: true From c8c4237b5d13e54c5d840064c70019ae0c062630 Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Sun, 20 Sep 2026 01:50:07 +0800 Subject: [PATCH 2/8] [ci] require project and patch coverage results --- .codecov.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .codecov.yml diff --git a/.codecov.yml b/.codecov.yml new file mode 100644 index 0000000..f886069 --- /dev/null +++ b/.codecov.yml @@ -0,0 +1,10 @@ +coverage: + status: + project: + default: + target: auto + threshold: 0% + patch: + default: + target: 100% + threshold: 0% From 00598a9a39a17182227ab3bbcef9c4135dc24fae Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Sun, 20 Sep 2026 02:17:11 +0800 Subject: [PATCH 3/8] [ci] measure a real pre-migration coverage baseline --- .github/workflows/build.yml | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3d54ef7..0a1761f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -6,6 +6,13 @@ on: pull_request: branches: ["master"] + workflow_dispatch: + inputs: + coverage-ref: + description: "Exact commit SHA to measure for the initial coverage baseline" + required: true + type: string + permissions: read-all jobs: @@ -27,3 +34,27 @@ jobs: footprint: true footprint-max-mb: 8 secrets: inherit + + # Backfill real coverage for a pre-OIDC commit; do not substitute head data. + baseline: + if: ${{ github.event_name == 'workflow_dispatch' }} + runs-on: ubuntu-22.04 + permissions: + contents: read + id-token: write + steps: + - uses: actions/checkout@v5 + with: + ref: ${{ inputs.coverage-ref }} + - uses: actions/setup-go@v6 + with: + go-version: "1.19.x" + - run: go test -race -coverprofile=coverage-baseline.txt ./... + - uses: codecov/codecov-action@v5 + with: + use_oidc: true + files: coverage-baseline.txt + disable_search: true + fail_ci_if_error: true + override_commit: ${{ inputs.coverage-ref }} + override_branch: master From c1b197d71b3fab0dd550e09392fd9c9308a0c845 Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Sun, 20 Sep 2026 02:24:41 +0800 Subject: [PATCH 4/8] [ci] finalize explicit project and patch coverage gates --- .github/workflows/build.yml | 30 ------------------------------ .codecov.yml => codecov.yml | 4 ++++ 2 files changed, 4 insertions(+), 30 deletions(-) rename .codecov.yml => codecov.yml (62%) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0a1761f..c3510ec 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -6,12 +6,6 @@ on: pull_request: branches: ["master"] - workflow_dispatch: - inputs: - coverage-ref: - description: "Exact commit SHA to measure for the initial coverage baseline" - required: true - type: string permissions: read-all @@ -34,27 +28,3 @@ jobs: footprint: true footprint-max-mb: 8 secrets: inherit - - # Backfill real coverage for a pre-OIDC commit; do not substitute head data. - baseline: - if: ${{ github.event_name == 'workflow_dispatch' }} - runs-on: ubuntu-22.04 - permissions: - contents: read - id-token: write - steps: - - uses: actions/checkout@v5 - with: - ref: ${{ inputs.coverage-ref }} - - uses: actions/setup-go@v6 - with: - go-version: "1.19.x" - - run: go test -race -coverprofile=coverage-baseline.txt ./... - - uses: codecov/codecov-action@v5 - with: - use_oidc: true - files: coverage-baseline.txt - disable_search: true - fail_ci_if_error: true - override_commit: ${{ inputs.coverage-ref }} - override_branch: master diff --git a/.codecov.yml b/codecov.yml similarity index 62% rename from .codecov.yml rename to codecov.yml index f886069..2f7efae 100644 --- a/.codecov.yml +++ b/codecov.yml @@ -8,3 +8,7 @@ coverage: default: target: 100% threshold: 0% +comment: + layout: "diff, flags, files" + require_changes: false + hide_project_coverage: false From 83be3414682c83232286ff8b5497c08cab86945f Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Sun, 20 Sep 2026 02:43:32 +0800 Subject: [PATCH 5/8] [fix] update vulnerable dependencies and parser baseline (STAR-88) --- .github/workflows/build.yml | 2 +- CLAUDE.md | 14 ++++-------- README.md | 4 ++++ go.mod | 17 +++++++-------- go.sum | 43 +++++++++++++++++++++---------------- 5 files changed, 42 insertions(+), 38 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c3510ec..539c7c6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,7 +20,7 @@ jobs: # automate this). uses: 1set/meta/.github/workflows/go-ci.yml@496f38088eff1a37bae1b43d158146a8a9d83a37 with: - go-floor: "1.19" + go-floor: "1.26" doc-coverage: true doc-coverage-file: docs/API.md doc-coverage-config: true diff --git a/CLAUDE.md b/CLAUDE.md index 5fcfc67..4be5460 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -35,13 +35,13 @@ gofmt -l . && go vet ./... # must be clean before commit go run github.com/1set/meta/doccov@master . # doc-coverage gate (exit 0 required) ``` -**Verify on the go floor in Docker** — this repo's floor is **go 1.19** (see +**Verify on the go floor in Docker** — this repo's floor is **go 1.26.8** (see Release discipline), and the pinned `go.starlark.net` baseline uses `maphash.String` (needs ≥1.19), so behavior on the floor must be checked in a container, not just on the (newer) local toolchain: ```bash -docker run --rm -v "$PWD":/src -v "$HOME/go/pkg/mod":/go/pkg/mod -w /src golang:1.19 go test -race -count=1 ./... +docker run --rm -v "$PWD":/src -v "$HOME/go/pkg/mod":/go/pkg/mod -w /src golang:1.26.8 go test -race -count=1 ./... ``` Integration scripts under `../test/web/*.star` live in the **private @@ -165,13 +165,7 @@ Three layers must stay in sync (enforced by the doc standard, ## Release discipline -- **Floor = go 1.19** (`go.mod`), matching the pinned `go.starlark.net` baseline - (`ffb3f39…`) and the `starlet v0.2.1` / `starlight v0.2.0` / `base v0.1.0` - deps. A repo's floor only rises in its own isolated **pin PR**, which is the - *last* PR of the series — never tag before it merges. -- **CI matrix** = `[1.19.x, 1.25.x]` via the centralized reusable workflow in - `1set/meta` (`.github/workflows/build.yml` pins the `go-ci.yml` SHA and sets - `go-floor: "1.19"` + `doc-coverage: true`). A standalone OpenSSF Scorecard - workflow runs separately. +- **Floor = go 1.26.8**, required by the reviewed networking dependencies and current Go security patch. The interpreter is pinned to its minimum parser-depth fix (`5395d018f003`). +- **CI matrix** = `[1.26.x, 1.27.x]` via the pinned reusable workflow in `1set/meta`. - **Bumping the version, the go floor, or tagging are user-confirmed actions** — never tag autonomously; default to patch bumps; published tags are immutable. diff --git a/README.md b/README.md index 9dc11a3..02a8cc7 100644 --- a/README.md +++ b/README.md @@ -140,3 +140,7 @@ option table, defaults, accessors, and the bind-guardrail details. ## License This project is licensed under the MIT License — see the [LICENSE](LICENSE) file for details. + +## Go compatibility + +Go 1.26.8 or newer is required. Release builds use Go 1.27.1. This patch updates the interpreter and the reviewed networking/Unicode security dependencies. diff --git a/go.mod b/go.mod index 63a6a57..787b879 100644 --- a/go.mod +++ b/go.mod @@ -1,26 +1,25 @@ module github.com/starpkg/web -go 1.19 +go 1.26.8 require ( github.com/1set/starlet v0.2.3 github.com/1set/starlight v0.2.1 github.com/gin-gonic/gin v1.9.1 github.com/starpkg/base v0.1.3 - go.starlark.net v0.0.0-20260324133313-ffb3f39dd27a + go.starlark.net v0.0.0-20260708150628-5395d018f003 ) require ( github.com/bytedance/sonic v1.9.1 // indirect github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311 // indirect - github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e // indirect + github.com/chzyer/readline v1.5.1 // indirect github.com/gabriel-vasile/mimetype v1.4.2 // indirect github.com/gin-contrib/sse v0.1.0 // indirect github.com/go-playground/locales v0.14.1 // indirect github.com/go-playground/universal-translator v0.18.1 // indirect github.com/go-playground/validator/v10 v10.14.0 // indirect github.com/goccy/go-json v0.10.2 // indirect - github.com/google/go-cmp v0.5.9 // indirect github.com/google/uuid v1.6.0 // indirect github.com/h2so5/here v0.0.0-20200815043652-5e14eb691fae // indirect github.com/json-iterator/go v1.1.12 // indirect @@ -40,10 +39,10 @@ require ( go.uber.org/multierr v1.9.0 // indirect go.uber.org/zap v1.24.0 // indirect golang.org/x/arch v0.3.0 // indirect - golang.org/x/crypto v0.21.0 // indirect - golang.org/x/net v0.23.0 // indirect - golang.org/x/sys v0.18.0 // indirect - golang.org/x/text v0.14.0 // indirect - google.golang.org/protobuf v1.33.0 // indirect + golang.org/x/crypto v0.56.0 // indirect + golang.org/x/net v0.57.0 // indirect + golang.org/x/sys v0.47.0 // indirect + golang.org/x/text v0.41.0 // indirect + google.golang.org/protobuf v1.36.11 // indirect gopkg.in/yaml.v3 v3.0.1 // indirect ) diff --git a/go.sum b/go.sum index 7aa27ee..c01fa8f 100644 --- a/go.sum +++ b/go.sum @@ -3,16 +3,19 @@ github.com/1set/starlet v0.2.3/go.mod h1:txkHyqtkqb1j9zBM0lOTwf6oW9vwtnsoLyUfqe9 github.com/1set/starlight v0.2.1 h1:07XiRr4XJ9p8rSL/A4XDC7sDInGszpXIP5jASCIZo10= github.com/1set/starlight v0.2.1/go.mod h1:o9KiJBpy92daHyNHBUwS0nFIjjLxLM/XmRxAZf4FIaE= github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8= +github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA= github.com/bytedance/sonic v1.5.0/go.mod h1:ED5hyg4y6t3/9Ku1R6dU/4KyJ48DZ4jPhfY1O2AihPM= github.com/bytedance/sonic v1.9.1 h1:6iJ6NqdoxCDr6mbY8h18oSO+cShGSMRGCEo7F2h0x8s= github.com/bytedance/sonic v1.9.1/go.mod h1:i736AoUSYt75HyZLoJW9ERYxcy6eaN6h4BZXU064P/U= github.com/chenzhuoyu/base64x v0.0.0-20211019084208-fb5309c8db06/go.mod h1:DH46F32mSOjUmXrMHnKwZdA8wcEefY7UVqBKYGjpdQY= github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311 h1:qSGYFH7+jGhDF8vLC+iwCD4WpbV1EBDSzWkJODFLams= github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311/go.mod h1:b583jCggY9gE99b6G5LEC39OIiVsWj+R97kbl5odCEk= -github.com/chzyer/logex v1.1.10 h1:Swpa1K6QvQznwJRcfTfQJmTE72DqScAa40E+fbHEXEE= -github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e h1:fY5BOSpyZCqRo5OhCuC+XN+r/bBCmeuuJtjz+bCNIf8= -github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e/go.mod h1:nSuG5e5PlCu98SY8svDHJxuZscDgtXS6KTTbou5AhLI= -github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1 h1:q763qf9huN11kDQavWsoZXJNW3xEE4JJyHa5Q25/sd8= +github.com/chzyer/logex v1.2.1 h1:XHDu3E6q+gdHgsdTPH6ImJMIp436vR6MPtH8gP05QzM= +github.com/chzyer/logex v1.2.1/go.mod h1:JLbx6lG2kDbNRFnfkgvh4eRJRPX1QCoOIWomwysCBrQ= +github.com/chzyer/readline v1.5.1 h1:upd/6fQk4src78LMRzh5vItIt361/o4uq553V8B5sGI= +github.com/chzyer/readline v1.5.1/go.mod h1:Eh+b79XXUwfKfcPLepksvw2tcLE/Ct21YObkaSkeBlk= +github.com/chzyer/test v1.0.0 h1:p3BQDXSxOhOG0P9z6/hGnII4LGiEPOYBhs8asl/fC04= +github.com/chzyer/test v1.0.0/go.mod h1:2JlltgoNkt4TW/z9V/IzDdFaMTM2JPIi26O1pF38GC8= github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= @@ -23,6 +26,7 @@ github.com/gin-contrib/sse v0.1.0/go.mod h1:RHrZQHXnP2xjPF+u1gW/2HnVO7nvIa9PG3Gm github.com/gin-gonic/gin v1.9.1 h1:4idEAncQnU5cB7BeOkPtxjfCSye0AAm1R0RVIqJ+Jmg= github.com/gin-gonic/gin v1.9.1/go.mod h1:hPrL7YrpYKXt5YId3A/Tnip5kqbEAP+KLuI3SUcPTeU= github.com/go-playground/assert/v2 v2.2.0 h1:JvknZsQTYeFEAhQwI4qEt9cyV5ONwRHC+lYKSsYSR8s= +github.com/go-playground/assert/v2 v2.2.0/go.mod h1:VDjEfimB/XKnb+ZQfWdccd7VUvScMdVu0Titje2rxJ4= github.com/go-playground/locales v0.14.1 h1:EWaQ/wswjilfKLTECiXz7Rh+3BjFhfDFKv/oXslEjJA= github.com/go-playground/locales v0.14.1/go.mod h1:hxrqLVvrK65+Rwrd5Fc6F2O76J/NuW9t0sjnWqG1slY= github.com/go-playground/universal-translator v0.18.1 h1:Bcnm0ZwsGyWbCzImXv+pAJnYK9S473LQFuzCbDbfSFY= @@ -31,8 +35,8 @@ github.com/go-playground/validator/v10 v10.14.0 h1:vgvQWe3XCz3gIeFDm/HnTIbj6UGmg github.com/go-playground/validator/v10 v10.14.0/go.mod h1:9iXMNT7sEkjXb0I+enO7QXmzG6QCsPWY4zveKFVRSyU= github.com/goccy/go-json v0.10.2 h1:CrxCmQqYDkv1z7lO7Wbh2HN93uovUHgrECaO5ZrCXAU= github.com/goccy/go-json v0.10.2/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I= -github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38= -github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= +github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8= +github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU= github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg= github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0= github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= @@ -57,6 +61,7 @@ github.com/montanaflynn/stats v0.7.1/go.mod h1:etXPPgVO6n31NxCd9KQUMvCM+ve0ruNzt github.com/pelletier/go-toml/v2 v2.0.8 h1:0ctb6s9mE31h0/lhu+J6OPmVeDxJn+kYnJc2jZR9tGQ= github.com/pelletier/go-toml/v2 v2.0.8/go.mod h1:vuYfssBdrU2XDZ9bYydBu6t+6a6PYNcZljzZR9VXg+4= github.com/pkg/errors v0.8.1 h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I= +github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 h1:lZUw3E0/J3roVtGQ+SCrUrg3ON6NgVqpn3+iol9aGu4= @@ -81,11 +86,12 @@ github.com/twitchyliquid64/golang-asm v0.15.1 h1:SU5vSMR7hnwNxj24w34ZyCi/FmDZTkS github.com/twitchyliquid64/golang-asm v0.15.1/go.mod h1:a1lVb/DtPvCB8fslRZhAngC2+aY1QWCk3Cedj/Gdt08= github.com/ugorji/go/codec v1.2.11 h1:BMaWp1Bb6fHwEtbplGBGJ498wD+LKlNSl25MjdZY4dU= github.com/ugorji/go/codec v1.2.11/go.mod h1:UNopzCgEMSXjBc6AOMqYvWC1ktqTAfzJZUZgYf6w6lg= -go.starlark.net v0.0.0-20260324133313-ffb3f39dd27a h1:w7OMj6r/AoxBpbfncRXaV18hjzIAFRytYaRILymmMRE= -go.starlark.net v0.0.0-20260324133313-ffb3f39dd27a/go.mod h1:YKMCv9b1WrfWmeqdV5MAuEHWsu5iC+fe6kYl2sQjdI8= +go.starlark.net v0.0.0-20260708150628-5395d018f003 h1:cAxcqHgW8fnmT0cEBU3TzvVYHIFt8IIGDMWUF6rImk4= +go.starlark.net v0.0.0-20260708150628-5395d018f003/go.mod h1:Iue6g6iirlfLoVi/DYCi5/x0h/bAOuWF3dULTKpt2Vo= go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE= go.uber.org/atomic v1.11.0/go.mod h1:LUxbIzbOniOlMKjJjyPfpl4v+PKK2cNJn91OQbhoJI0= go.uber.org/goleak v1.1.11 h1:wy28qYRKZgnJTxGxvye5/wgWr1EKjmUDGYox5mGlRlI= +go.uber.org/goleak v1.1.11/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ= go.uber.org/multierr v1.9.0 h1:7fIwc/ZtS0q++VgcfqFDxSBZVv/Xo49/SYnDFupUwlI= go.uber.org/multierr v1.9.0/go.mod h1:X2jQV1h+kxSjClGpnseKVIxpmcjrj7MNnI0bnlfKTVQ= go.uber.org/zap v1.24.0 h1:FiJd5l1UOLj0wCgbSE0rwwXHzEdAZS6hiiSnxJN/D60= @@ -93,18 +99,19 @@ go.uber.org/zap v1.24.0/go.mod h1:2kMP+WWQ8aoFoedH3T2sq6iJ2yDWpHbP0f6MQbS9Gkg= golang.org/x/arch v0.0.0-20210923205945-b76863e36670/go.mod h1:5om86z9Hs0C8fWVUuoMHwpExlXzs5Tkyp9hOrfG7pp8= golang.org/x/arch v0.3.0 h1:02VY4/ZcO/gBOH6PUaoiptASxtXU10jazRCP865E97k= golang.org/x/arch v0.3.0/go.mod h1:5om86z9Hs0C8fWVUuoMHwpExlXzs5Tkyp9hOrfG7pp8= -golang.org/x/crypto v0.21.0 h1:X31++rzVUdKhX5sWmSOFZxx8UW/ldWx55cbf08iNAMA= -golang.org/x/crypto v0.21.0/go.mod h1:0BP7YvVV9gBbVKyeTG0Gyn+gZm94bibOW5BjDEYAOMs= -golang.org/x/net v0.23.0 h1:7EYJ93RZ9vYSZAIb2x3lnuvqO5zneoD6IvWjuhfxjTs= -golang.org/x/net v0.23.0/go.mod h1:JKghWKKOSdJwpW2GEx0Ja7fmaKnMsbu+MWVZTokSYmg= +golang.org/x/crypto v0.56.0 h1:GUh5Ii4J5jtcseSMiRqr1jXCNHoxjeV9Fmekc2oLy6Y= +golang.org/x/crypto v0.56.0/go.mod h1:OMW5y6CY9l38uPLmxU6l6pwcXp1obtLo3e6gT7gQR2I= +golang.org/x/net v0.57.0 h1:K5+3DljvIuDG9/Jv9rvyMywYNFCQ9RSUY6OOTTkT+tE= +golang.org/x/net v0.57.0/go.mod h1:KpXc8iv+r3XplLAG/f7Jsf9RPszJzdR0f58q9vGOuEU= +golang.org/x/sys v0.0.0-20220310020820-b874c991c1a5/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220704084225-05e143d24a9e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.18.0 h1:DBdB3niSjOA/O0blCZBqDefyWNYveAYMNF1Wum0DYQ4= -golang.org/x/sys v0.18.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= -golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ= -golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU= -google.golang.org/protobuf v1.33.0 h1:uNO2rsAINq/JlFpSdYEKIZ0uKD/R9cpdv0T+yoGwGmI= -google.golang.org/protobuf v1.33.0/go.mod h1:c6P6GXX6sHbq/GpV6MGZEdwhWPcYBgnhAHhKbcUYpos= +golang.org/x/sys v0.47.0 h1:o7XGOvZQCADBQQ4Y7VNq2dRWQR7JmOUW8Kxx4ZsNgWs= +golang.org/x/sys v0.47.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw= +golang.org/x/text v0.41.0 h1:vz/seA0lnX87Othu2f/0L24RcgrXD9/YFTSuGjj3rH8= +golang.org/x/text v0.41.0/go.mod h1:jvf1O8ajNzZqhSrQBPbutR/EB83Cc0CFrezNQIwbb5M= +google.golang.org/protobuf v1.36.11 h1:fV6ZwhNocDyBLK0dj+fg8ektcVegBBuEolpbTQyBNVE= +google.golang.org/protobuf v1.36.11/go.mod h1:HTf+CrKn2C3g5S8VImy6tdcUvCska2kB7j23XfzDpco= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= From d75e2464e83ab7eeba3bdc7e701964b731cacb96 Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Sun, 20 Sep 2026 02:58:52 +0800 Subject: [PATCH 6/8] [ci] adopt current toolchain patches and configuration contract checks --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 539c7c6..9ebf279 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -18,7 +18,7 @@ jobs: # Star* module's pipeline. Pinned to a commit SHA for supply-chain safety; # bump the pin when meta's workflow changes (Dependabot github-actions can # automate this). - uses: 1set/meta/.github/workflows/go-ci.yml@496f38088eff1a37bae1b43d158146a8a9d83a37 + uses: 1set/meta/.github/workflows/go-ci.yml@23f088bcd6dce16c93e0056d7b70b4f4434208e8 with: go-floor: "1.26" doc-coverage: true From 75acbc6dfc6f79be44ff038c3086e2e8eefd6c76 Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Mon, 21 Sep 2026 01:17:17 +0800 Subject: [PATCH 7/8] [fix] preserve the interpreter pin and minimize the network Go floor --- .github/workflows/build.yml | 22 +++++++++++++++++++++- CLAUDE.md | 8 ++++---- README.md | 12 +++++++++++- go.mod | 6 +++--- go.sum | 8 ++++---- 5 files changed, 43 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9ebf279..c6d4c02 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -10,6 +10,26 @@ on: permissions: read-all jobs: + compatibility: + runs-on: ubuntu-22.04 + steps: + - uses: actions/checkout@v5 + - uses: actions/setup-go@v6 + with: + go-version: "1.27.1" + - name: Verify the pinned interpreter + run: test "$(go list -m -f '{{.Version}}' go.starlark.net)" = "v0.0.0-20260324133313-ffb3f39dd27a" + - name: Guard the compatible crypto dependency boundary + # v0.55.0 keeps Go 1.25 support. Its SSH/OpenPGP packages must not enter + # this application's build or tests; their advisories need a separate + # dependency and compatibility review before either package is used. + run: | + go list -deps -test ./... > "$RUNNER_TEMP/crypto-imports.txt" + if grep -E '^golang.org/x/crypto/(ssh|openpgp)(/|$)' "$RUNNER_TEMP/crypto-imports.txt"; then + echo "Review the crypto version before adding SSH or OpenPGP dependencies" + exit 1 + fi + ci: permissions: contents: read @@ -20,7 +40,7 @@ jobs: # automate this). uses: 1set/meta/.github/workflows/go-ci.yml@23f088bcd6dce16c93e0056d7b70b4f4434208e8 with: - go-floor: "1.26" + go-floor: "1.25" doc-coverage: true doc-coverage-file: docs/API.md doc-coverage-config: true diff --git a/CLAUDE.md b/CLAUDE.md index 4be5460..3326ec7 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -35,13 +35,13 @@ gofmt -l . && go vet ./... # must be clean before commit go run github.com/1set/meta/doccov@master . # doc-coverage gate (exit 0 required) ``` -**Verify on the go floor in Docker** — this repo's floor is **go 1.26.8** (see +**Verify on the go floor in Docker** — this repo's floor is **go 1.25.0** (see Release discipline), and the pinned `go.starlark.net` baseline uses `maphash.String` (needs ≥1.19), so behavior on the floor must be checked in a container, not just on the (newer) local toolchain: ```bash -docker run --rm -v "$PWD":/src -v "$HOME/go/pkg/mod":/go/pkg/mod -w /src golang:1.26.8 go test -race -count=1 ./... +docker run --rm -v "$PWD":/src -v "$HOME/go/pkg/mod":/go/pkg/mod -w /src golang:1.25.0 go test -race -count=1 ./... ``` Integration scripts under `../test/web/*.star` live in the **private @@ -165,7 +165,7 @@ Three layers must stay in sync (enforced by the doc standard, ## Release discipline -- **Floor = go 1.26.8**, required by the reviewed networking dependencies and current Go security patch. The interpreter is pinned to its minimum parser-depth fix (`5395d018f003`). -- **CI matrix** = `[1.26.x, 1.27.x]` via the pinned reusable workflow in `1set/meta`. +- **Floor = go 1.25.0**, required by the reviewed networking and Unicode dependencies. The interpreter remains at `ffb3f39dd27a`; its known parser recursion limitation requires host-reviewed source or an external isolation boundary. Production builds use a supported patched Go toolchain. +- **CI matrix** = `[1.25.x, 1.27.x]` via the pinned reusable workflow in `1set/meta`. - **Bumping the version, the go floor, or tagging are user-confirmed actions** — never tag autonomously; default to patch bumps; published tags are immutable. diff --git a/README.md b/README.md index 02a8cc7..1c8ece4 100644 --- a/README.md +++ b/README.md @@ -143,4 +143,14 @@ This project is licensed under the MIT License — see the [LICENSE](LICENSE) fi ## Go compatibility -Go 1.26.8 or newer is required. Release builds use Go 1.27.1. This patch updates the interpreter and the reviewed networking/Unicode security dependencies. +Go 1.25.0 or newer is required. Release builds use Go 1.27.1. This patch updates the interpreter and the reviewed networking/Unicode security dependencies. + +### Dependency compatibility + +The Go 1.25.0 floor comes from the networking and Unicode fixes (`x/net` and +`x/text`), independently of the Starlark pin. Production applications should +use a supported patched Go toolchain. `x/crypto v0.55.0` keeps Go 1.25 +compatibility; this module imports its SHA-3 package, not SSH or OpenPGP. Those +unused packages retain advisories, and CI rejects their introduction until a +separate dependency and compatibility review. This is not a claim that the +entire dependency module is free of vulnerabilities. diff --git a/go.mod b/go.mod index 787b879..61ded3c 100644 --- a/go.mod +++ b/go.mod @@ -1,13 +1,13 @@ module github.com/starpkg/web -go 1.26.8 +go 1.25.0 require ( github.com/1set/starlet v0.2.3 github.com/1set/starlight v0.2.1 github.com/gin-gonic/gin v1.9.1 github.com/starpkg/base v0.1.3 - go.starlark.net v0.0.0-20260708150628-5395d018f003 + go.starlark.net v0.0.0-20260324133313-ffb3f39dd27a ) require ( @@ -39,7 +39,7 @@ require ( go.uber.org/multierr v1.9.0 // indirect go.uber.org/zap v1.24.0 // indirect golang.org/x/arch v0.3.0 // indirect - golang.org/x/crypto v0.56.0 // indirect + golang.org/x/crypto v0.55.0 // indirect golang.org/x/net v0.57.0 // indirect golang.org/x/sys v0.47.0 // indirect golang.org/x/text v0.41.0 // indirect diff --git a/go.sum b/go.sum index c01fa8f..8127c0f 100644 --- a/go.sum +++ b/go.sum @@ -86,8 +86,8 @@ github.com/twitchyliquid64/golang-asm v0.15.1 h1:SU5vSMR7hnwNxj24w34ZyCi/FmDZTkS github.com/twitchyliquid64/golang-asm v0.15.1/go.mod h1:a1lVb/DtPvCB8fslRZhAngC2+aY1QWCk3Cedj/Gdt08= github.com/ugorji/go/codec v1.2.11 h1:BMaWp1Bb6fHwEtbplGBGJ498wD+LKlNSl25MjdZY4dU= github.com/ugorji/go/codec v1.2.11/go.mod h1:UNopzCgEMSXjBc6AOMqYvWC1ktqTAfzJZUZgYf6w6lg= -go.starlark.net v0.0.0-20260708150628-5395d018f003 h1:cAxcqHgW8fnmT0cEBU3TzvVYHIFt8IIGDMWUF6rImk4= -go.starlark.net v0.0.0-20260708150628-5395d018f003/go.mod h1:Iue6g6iirlfLoVi/DYCi5/x0h/bAOuWF3dULTKpt2Vo= +go.starlark.net v0.0.0-20260324133313-ffb3f39dd27a h1:w7OMj6r/AoxBpbfncRXaV18hjzIAFRytYaRILymmMRE= +go.starlark.net v0.0.0-20260324133313-ffb3f39dd27a/go.mod h1:YKMCv9b1WrfWmeqdV5MAuEHWsu5iC+fe6kYl2sQjdI8= go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE= go.uber.org/atomic v1.11.0/go.mod h1:LUxbIzbOniOlMKjJjyPfpl4v+PKK2cNJn91OQbhoJI0= go.uber.org/goleak v1.1.11 h1:wy28qYRKZgnJTxGxvye5/wgWr1EKjmUDGYox5mGlRlI= @@ -99,8 +99,8 @@ go.uber.org/zap v1.24.0/go.mod h1:2kMP+WWQ8aoFoedH3T2sq6iJ2yDWpHbP0f6MQbS9Gkg= golang.org/x/arch v0.0.0-20210923205945-b76863e36670/go.mod h1:5om86z9Hs0C8fWVUuoMHwpExlXzs5Tkyp9hOrfG7pp8= golang.org/x/arch v0.3.0 h1:02VY4/ZcO/gBOH6PUaoiptASxtXU10jazRCP865E97k= golang.org/x/arch v0.3.0/go.mod h1:5om86z9Hs0C8fWVUuoMHwpExlXzs5Tkyp9hOrfG7pp8= -golang.org/x/crypto v0.56.0 h1:GUh5Ii4J5jtcseSMiRqr1jXCNHoxjeV9Fmekc2oLy6Y= -golang.org/x/crypto v0.56.0/go.mod h1:OMW5y6CY9l38uPLmxU6l6pwcXp1obtLo3e6gT7gQR2I= +golang.org/x/crypto v0.55.0 h1:+KWHjbgOaAQ66dh/YlkZKHlz9ZUlq61AFirAR9ntP8M= +golang.org/x/crypto v0.55.0/go.mod h1:uq0V9dE/fzQuJtbnL+2EhWOE63vo164FY8xqEnV9xis= golang.org/x/net v0.57.0 h1:K5+3DljvIuDG9/Jv9rvyMywYNFCQ9RSUY6OOTTkT+tE= golang.org/x/net v0.57.0/go.mod h1:KpXc8iv+r3XplLAG/f7Jsf9RPszJzdR0f58q9vGOuEU= golang.org/x/sys v0.0.0-20220310020820-b874c991c1a5/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= From e241ce216247ba94a9a9488ddc8869faf5d6a0d9 Mon Sep 17 00:00:00 2001 From: Kevin Tang <73975146+vt128@users.noreply.github.com> Date: Wed, 23 Sep 2026 10:37:21 +0800 Subject: [PATCH 8/8] [doc] clarify the retained interpreter and production toolchain --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1c8ece4..fef3207 100644 --- a/README.md +++ b/README.md @@ -143,7 +143,7 @@ This project is licensed under the MIT License — see the [LICENSE](LICENSE) fi ## Go compatibility -Go 1.25.0 or newer is required. Release builds use Go 1.27.1. This patch updates the interpreter and the reviewed networking/Unicode security dependencies. +Go 1.25.0 or newer is required. Production builds use Go 1.27.1. This patch retains the established Starlark interpreter pin and updates the reviewed networking/Unicode dependencies. ### Dependency compatibility