refactor(hickey): hoist lmlSourcePath from View.Export.JSON to Route.ModelRoute

lmlSourcePath is withLmlRoute encodeRoute — a pure route-layer helper with
no View or JSON-export concern. Its home was an accident of being the
first consumer's module. Adding MCP.Tools as a non-View consumer made the
layering inversion visible (MCP depending on View). Move it to its natural
home alongside withLmlRoute / mkLMLRouteFromKnownFilePath.

lmlRouteKey stays in View.Export.JSON (single-consumer, JSON-key-specific)
but now derives from R.lmlSourcePath instead of redefining the body.

Author: srid

emanote/src/Emanote/MCP/Tools.hs

@@ -42,7 +42,6 @@ import Emanote.Model.Title qualified as Tit
 import Emanote.Route qualified as R
 import Emanote.Route.Ext (LML (Md, Org))
 import Emanote.Route.ModelRoute (mkLMLRouteFromKnownFilePath)
-import Emanote.View.Export.JSON (lmlSourcePath)
 import MCP.Server (
   CallToolResult,
   InputSchema (..),
@@ -83,7 +82,7 @@ data NoteMatch = NoteMatch
 
 noteMatchOf :: Model -> R.LMLRoute -> NoteMatch
 noteMatchOf model r =
-  let p = toText $ lmlSourcePath r
+  let p = toText $ R.lmlSourcePath r
    in NoteMatch
         { path = p
         , title = Tit.toPlain (M.modelLookupTitle r model)
@@ -106,7 +105,7 @@ findNotes query lim model =
       hit note =
         let r = note ^. N.noteRoute
             t = Tit.toPlain (note ^. N.noteTitle)
-            p = toText (lmlSourcePath r)
+            p = toText (R.lmlSourcePath r)
          in if q `T.isInfixOf` T.toLower t || q `T.isInfixOf` T.toLower p
               then Just (noteMatchOf model r)
               else Nothing

emanote/src/Emanote/Route/ModelRoute.hs

@@ -20,6 +20,7 @@ module Emanote.Route.ModelRoute (
   lmlToHtmlRoute,
   mkLMLRouteFromFilePath,
   mkLMLRouteFromKnownFilePath,
+  lmlSourcePath,
   isMdRoute,
   -- Static file routes
   StaticFileRoute,
@@ -158,3 +159,7 @@ mkLMLRouteFromKnownFilePath lmlType fp =
   case lmlType of
     Md -> fmap LMLRoute_Md (R.mkLmlRouteFromFilePath fp)
     Org -> fmap LMLRoute_Org (R.mkLmlRouteFromFilePath fp)
+
+-- | Source-relative path of an LML note (e.g. @guide/mcp.md@).
+lmlSourcePath :: LMLRoute -> FilePath
+lmlSourcePath = withLmlRoute R.encodeRoute

emanote/src/Emanote/View/Export/Content.hs

@@ -20,7 +20,7 @@ import Emanote.Route qualified as R
 import Emanote.Route.SiteRoute qualified as SR
 import Emanote.Route.SiteRoute.Class (lmlSiteRoute)
 import Emanote.Source.Loc (locResolve)
-import Emanote.View.Export.JSON (getBaseUrlFromModel, lmlSourcePath)
+import Emanote.View.Export.JSON (getBaseUrlFromModel)
 import NeatInterpolation (text)
 import Optics.Operators ((^.))
 import Relude
@@ -51,7 +51,7 @@ renderContentExport :: Model -> IO Text
 renderContentExport model = do
   let mBaseUrl = getBaseUrlFromModel model
   let notes_ = model ^. M.modelNotes
-      noteList = sortOn (lmlSourcePath . Note._noteRoute) $ toList notes_
+      noteList = sortOn (R.lmlSourcePath . Note._noteRoute) $ toList notes_
   exportedNotes <- catMaybes <$> mapM (exportNote model) noteList
   let urlHelpText = case mBaseUrl of
         Just _ -> "- URL: The full URL where this note can be accessed"
@@ -66,7 +66,7 @@ renderContentExport model = do
 generateNoteHeader :: Model -> Note.Note -> Text
 generateNoteHeader model note =
   let route = Note._noteRoute note
-      sourcePath = lmlSourcePath route
+      sourcePath = R.lmlSourcePath route
       noteTitle = Tit.toPlain $ Note._noteTitle note
       wikilinks = Note.noteSelfRefs note
       wikilinkTexts = toList $ fmap (toText . (show :: WL.WikiLink -> String)) wikilinks

emanote/src/Emanote/View/Export/JSON.hs

@@ -9,7 +9,6 @@ module Emanote.View.Export.JSON (
   modelRels,
   currentVersion,
   lmlRouteKey,
-  lmlSourcePath,
   getBaseUrlFromModel,
 ) where
 
@@ -73,7 +72,7 @@ renderJSONExport model =
                  in SourceFile
                       (Tit.toPlain tit)
                       k
-                      (toText . lmlSourcePath <$> M.parentLmlRoute model r)
+                      (toText . R.lmlSourcePath <$> M.parentLmlRoute model r)
                       (SR.siteRouteUrl model $ lmlSiteRoute (R.LMLView_Html, r))
                       meta_
                       (fromMaybe [] $ Map.lookup k rels)
@@ -98,13 +97,7 @@ modelRels model =
 --
 -- We use the source path consistently.
 lmlRouteKey :: LMLRoute -> Text
-lmlRouteKey =
-  toText . R.withLmlRoute R.encodeRoute
-
--- Path of the LML note
-lmlSourcePath :: LMLRoute -> FilePath
-lmlSourcePath =
-  R.withLmlRoute R.encodeRoute
+lmlRouteKey = toText . R.lmlSourcePath
 
 -- | Get base URL from model configuration (returns Nothing if not configured)
 getBaseUrlFromModel :: Model -> Maybe Text