dont evaluate Redis as a generic at runtime

zzzeek · zzzeek · commit 6e9fa0408d51 · 2025-01-28T08:21:06.000-05:00
Fixes to the recently added ``RedisClusterBackend`` fixing a runtime typing error that prevented it from running. Fixes: #263 Change-Id: I1e6d4404bce0fd0515277b1db0c7e90d1582f961
diff --git a/docs/build/unreleased/263.rst b/docs/build/unreleased/263.rst
@@ -0,0 +1,6 @@
+.. change::
+    :tags: bug, redis
+    :tickets: 263
+
+    Fixes to the recently added ``RedisClusterBackend`` fixing a runtime typing
+    error that prevented it from running.
diff --git a/dogpile/cache/backends/redis.py b/dogpile/cache/backends/redis.py
@@ -565,5 +565,5 @@ def _create_client(self):
                 startup_nodes=self.startup_nodes,
                 **self.connection_kwargs,
             )
-        self.writer_client = typing.cast(redis.Redis[bytes], redis_cluster)
+        self.writer_client = typing.cast("redis.Redis[bytes]", redis_cluster)
         self.reader_client = self.writer_client

Original file line number	Diff line number	Diff line change
`@@ -565,5 +565,5 @@ def _create_client(self):`
`565`	`565`	`startup_nodes=self.startup_nodes,`
`566`	`566`	`**self.connection_kwargs,`
`567`	`567`	`)`
`568`		`- self.writer_client = typing.cast(redis.Redis[bytes], redis_cluster)`
	`568`	`+ self.writer_client = typing.cast("redis.Redis[bytes]", redis_cluster)`
`569`	`569`	`self.reader_client = self.writer_client`