Add colon (:) to invalid char for revision name add unittest

Disallow ':' character in custom revision identifiers. Previously, using a
colon in a revision ID (e.g., 'REV:1') would create the revision, however
revisions with colons in them are not correctly interpreted by other
commands, as it overlaps with the revision range syntax.   Pull request
courtesy Kim Wooseok with original implementation by Hrushikesh Patil.

Fixes: #1540
Closes: #1741
Pull-request: #1741
Pull-request-sha: 3894b1f

Change-Id: Ie935f0e04981a0b3d0ac8a2ac03ffebce898280a

Author: kimwoo123

alembic/script/revision.py

@@ -45,7 +45,7 @@
 _TR = TypeVar("_TR", bound=Optional[_RevisionOrStr])
 
 _relative_destination = re.compile(r"(?:(.+?)@)?(\w+)?((?:\+|-)\d+)")
-_revision_illegal_chars = ["@", "-", "+"]
+_revision_illegal_chars = ["@", "-", "+", ":"]
 
 
 class _CollectRevisionsProtocol(Protocol):

docs/build/unreleased/1540.rst

@@ -0,0 +1,9 @@
+.. change::
+    :tags: bug, commands
+    :tickets: 1540
+
+    Disallow ':' character in custom revision identifiers. Previously, using a
+    colon in a revision ID (e.g., 'REV:1') would create the revision, however
+    revisions with colons in them are not correctly interpreted by other
+    commands, as it overlaps with the revision range syntax.   Pull request
+    courtesy Kim Wooseok with original implementation by Hrushikesh Patil.

tests/test_script_production.py

@@ -393,6 +393,16 @@ def test_illegal_revision_chars(self):
             rev_id="no@atsigns",
         )
 
+        assert_raises_message(
+            util.CommandError,
+            r"Character\(s\) ':' not allowed in "
+            "revision identifier 'no:colons'",
+            command.revision,
+            self.cfg,
+            message="some message",
+            rev_id="no:colons",
+        )
+
         assert_raises_message(
             util.CommandError,
             r"Character\(s\) '-, @' not allowed in revision "