From b066cb21f2250a0fc9dd7fdc9ba828e8970c887f Mon Sep 17 00:00:00 2001 From: specify Date: Tue, 15 Sep 2026 08:41:01 -0500 Subject: [PATCH 1/5] [test]: added model and tes for creating a record set and update the name --- .../tests/test_edit_previous_object.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py index 98385ad17ae..bbf074e1c9c 100644 --- a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py +++ b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py @@ -168,7 +168,26 @@ def setUp(self): deaccessionnumber='Test deaccession', ) ] - + self.recordset = models.Recordset.objects.create( + name='Previous Record set', + collectionmemberid=self.collection.id, + dbtableid=models.Collectionobject.specify_model.tableId, + specifyuser=self.specifyuser, + type=0, + ) + + def test_edit_recordset_created_in_previous_version(self): + recordset = self.recordset + + recordset.name ='Updated Name' + recordset.save() + recordset.refresh_from_db() + + self.assertEqual( + recordset.name, + 'Updated Name', + ) + def test_edit_collectionobject_created_in_previous_version(self): collectionobject = self.collectionobjects[0] From 543a63fcedc428f9b17b44083914da82ab069306 Mon Sep 17 00:00:00 2001 From: "coderabbitai[bot]" <136622811+coderabbitai[bot]@users.noreply.github.com> Date: Tue, 15 Sep 2026 14:35:01 +0000 Subject: [PATCH 2/5] test(businessrules): verify updates to legacy recordsets --- .../tests/test_edit_previous_object.py | 29 ++++++++++++------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py index bbf074e1c9c..23548405680 100644 --- a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py +++ b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py @@ -1,3 +1,6 @@ +from django.db import connection +from django.db.migrations.loader import MigrationLoader + from specifyweb.specify import models from specifyweb.specify.tests.test_api import ApiTests @@ -168,26 +171,30 @@ def setUp(self): deaccessionnumber='Test deaccession', ) ] - self.recordset = models.Recordset.objects.create( + legacy_apps = MigrationLoader(connection).project_state( + [("specify", "0034_accession_date_fields")] + ).apps + legacy_recordset = legacy_apps.get_model("specify", "Recordset") + recordset = legacy_recordset.objects.create( name='Previous Record set', collectionmemberid=self.collection.id, dbtableid=models.Collectionobject.specify_model.tableId, - specifyuser=self.specifyuser, + specifyuser_id=self.specifyuser.id, type=0, ) - + self.recordset = models.Recordset.objects.get(pk=recordset.pk) + def test_edit_recordset_created_in_previous_version(self): - recordset = self.recordset - - recordset.name ='Updated Name' + recordset = models.Recordset.objects.get(pk=self.recordset.pk) + + recordset.name = 'Updated Name' recordset.save() - recordset.refresh_from_db() - self.assertEqual( - recordset.name, + self.assertEqual( + models.Recordset.objects.get(pk=recordset.pk).name, 'Updated Name', ) - + def test_edit_collectionobject_created_in_previous_version(self): collectionobject = self.collectionobjects[0] @@ -390,4 +397,4 @@ def test_edit_deaccession_created_in_previous_version(self): self.assertEqual( deaccession.deaccessionnumber, '123', - ) \ No newline at end of file + ) From 6d4341e72c8c95538443d57539b0850f845bc638 Mon Sep 17 00:00:00 2001 From: specify Date: Tue, 15 Sep 2026 10:51:13 -0500 Subject: [PATCH 3/5] [test]:did the suggested changes recommended by CodeRabbit --- .../tests/test_edit_previous_object.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py index bbf074e1c9c..83e94e69555 100644 --- a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py +++ b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py @@ -168,16 +168,17 @@ def setUp(self): deaccessionnumber='Test deaccession', ) ] - self.recordset = models.Recordset.objects.create( - name='Previous Record set', - collectionmemberid=self.collection.id, - dbtableid=models.Collectionobject.specify_model.tableId, - specifyuser=self.specifyuser, - type=0, - ) - + self.recordset = [ + models.Recordset.objects.create( + name='Previous Record set', + collectionmemberid=self.collection.id, + dbtableid=models.Collectionobject.specify_model.tableId, + specifyuser=self.specifyuser, + type=0, + ) + ] def test_edit_recordset_created_in_previous_version(self): - recordset = self.recordset + recordset = self.recordset[0] recordset.name ='Updated Name' recordset.save() From 54ec16b124ec57ac4dc52d4d1030c57a27f8a331 Mon Sep 17 00:00:00 2001 From: specify Date: Tue, 15 Sep 2026 13:14:20 -0500 Subject: [PATCH 4/5] [test]:removed the imports that code rabbit put in --- .../backend/businessrules/tests/test_edit_previous_object.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py index 79c95396eec..ecd2c691c64 100644 --- a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py +++ b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py @@ -1,6 +1,3 @@ -from django.db import connection -from django.db.migrations.loader import MigrationLoader - from specifyweb.specify import models from specifyweb.specify.tests.test_api import ApiTests From fc18c6f35a60dcf7ba616bf5d7406c75b335186d Mon Sep 17 00:00:00 2001 From: specify Date: Thu, 17 Sep 2026 08:14:24 -0500 Subject: [PATCH 5/5] [test]: removed extra def made from code rabbit --- .../businessrules/tests/test_edit_previous_object.py | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py index ecd2c691c64..925f82ef2e2 100644 --- a/specifyweb/backend/businessrules/tests/test_edit_previous_object.py +++ b/specifyweb/backend/businessrules/tests/test_edit_previous_object.py @@ -184,17 +184,6 @@ def test_edit_recordset_created_in_previous_version(self): recordset.save() recordset.refresh_from_db() - def test_edit_recordset_created_in_previous_version(self): - recordset = models.Recordset.objects.get(pk=self.recordset.pk) - - recordset.name = 'Updated Name' - recordset.save() - - self.assertEqual( - models.Recordset.objects.get(pk=recordset.pk).name, - 'Updated Name', - ) - def test_edit_collectionobject_created_in_previous_version(self): collectionobject = self.collectionobjects[0]