Skip to content

Commit ba52d2f

Browse files
authored
fix(iOS): fix possible build issues on Mac Catalyst due to implicit conversions (#3594)
## Description Closes <#3592> The fix relies on adding an explicit cast from `BOOL` to `bool`. Currently, I am not aware of any scenario where described cast could fail, therefore I determine it to be safe. This change reportedly fixes an issue with build on Mac Catalyst. The fix is analogous to the one I did in <#3202>. ## Before & after - visual documentation N/A ## Test plan This diff does not change behavior on our end. For us sufficient testing plan would be for out CIs to pass. I'm relying here on user confirmation that the PR indeed fixes the issue. ## Checklist - [ ] Included code example that can be used to test this change. - [ ] Updated / created local changelog entries in relevant test files. - [ ] For visual changes, included screenshots / GIFs / recordings documenting the change. - [ ] For API changes, updated relevant public types. - [x] Ensured that CI passes
1 parent 92b9cdf commit ba52d2f

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

ios/bottom-tabs/host/RNSBottomTabsHostEventEmitter.mm

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ - (BOOL)emitOnNativeFocusChange:(OnNativeFocusChangePayload)payload
3939
if (_reactEventEmitter != nullptr) {
4040
_reactEventEmitter->onNativeFocusChange(
4141
{.tabKey = RCTStringFromNSString(payload.tabKey),
42-
.repeatedSelectionHandledBySpecialEffect = payload.repeatedSelectionHandledBySpecialEffect});
42+
.repeatedSelectionHandledBySpecialEffect =
43+
static_cast<bool>(payload.repeatedSelectionHandledBySpecialEffect)});
4344
return YES;
4445
} else {
4546
RCTLogWarn(@"[RNScreens] Skipped OnNativeFocusChange event emission due to nullish emitter");

0 commit comments

Comments
 (0)