Commit 9bfc35c
authored
fix(Android, Stack v5): fix lifecycle of prevent native dismiss callback (#3635)
## Description
There is no memory leak currently, because PreventNativeDismissCallback
does not retain the fragment (lifecycleOwner), it registers itself as a
listener on it, so it's the fragment who retains it x2 (explicitly & in
listener array). The callback unregisters when fragment is destroyed.
The problem is however, that the callback registers as a listener in its
init block, effectively doing it once per object lifetime, even if the
fragment is reattached to the fragment manager the callback won't
initialize again effectively breaking the prevent-native-dismiss
behavior.
## Changes
I fix this by setting up the callback in onCreate & destroying it in
onDestroy.
## Visual documentation
N/A
## Checklist
- [x] Ensured that CI passes1 parent cc2a3b3 commit 9bfc35c
1 file changed
Lines changed: 22 additions & 8 deletions
Lines changed: 22 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
28 | | - | |
29 | | - | |
30 | | - | |
| 29 | + | |
31 | 30 | | |
32 | 31 | | |
33 | 32 | | |
| |||
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
56 | | - | |
| 55 | + | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
81 | 95 | | |
82 | 96 | | |
0 commit comments