chore(iOS, Stack v4): Enable iosPreventReattachmentOfDismissedScreens by default (#3652)

## Description

It probably should be merged after expo-router cutoff for RNScreens
version. This PR is enabling the fix which was earlier hidden behind FF

## Changes

- iosPreventReattachmentOfDismissedScreens is now set to `true` by
default

## Before & after - visual documentation

N/A - nothing should change, for visual documentation please see:
#3584

## Test plan

Performed regression testing on Test2559.

## Checklist

- [ ] Included code example that can be used to test this change.
- [ ] Updated / created local changelog entries in relevant test files.
- [ ] For visual changes, included screenshots / GIFs / recordings
documenting the change.
- [ ] For API changes, updated relevant public types.
- [ ] Ensured that CI passes

Author: t0maboro

FabricExample/App.tsx

@@ -1,12 +1,10 @@
 import App from '../apps';
 import { featureFlags } from 'react-native-screens';
 
-featureFlags.experiment.synchronousScreenUpdatesEnabled = false
-featureFlags.experiment.synchronousHeaderConfigUpdatesEnabled = false
-featureFlags.experiment.synchronousHeaderSubviewUpdatesEnabled = false
-featureFlags.experiment.androidResetScreenShadowStateOnOrientationChangeEnabled = true
-// TODO: @t0maboro - remove ts-ignore after release
-// @ts-ignore - will be present since react-native-screens 4.21.0
-featureFlags.experiment.iosPreventReattachmentOfDismissedScreens = false
+featureFlags.experiment.synchronousScreenUpdatesEnabled = false;
+featureFlags.experiment.synchronousHeaderConfigUpdatesEnabled = false;
+featureFlags.experiment.synchronousHeaderSubviewUpdatesEnabled = false;
+featureFlags.experiment.androidResetScreenShadowStateOnOrientationChangeEnabled =
+  true;
 
 export default App;

android/src/paper/java/com/facebook/react/viewmanagers/RNSScreenStackManagerDelegate.java

@@ -24,7 +24,7 @@ public RNSScreenStackManagerDelegate(U viewManager) {
   public void setProperty(T view, String propName, @Nullable Object value) {
     switch (propName) {
       case "iosPreventReattachmentOfDismissedScreens":
-        mViewManager.setIosPreventReattachmentOfDismissedScreens(view, value == null ? false : (boolean) value);
+        mViewManager.setIosPreventReattachmentOfDismissedScreens(view, value == null ? true : (boolean) value);
         break;
       default:
         super.setProperty(view, propName, value);

ios/RNSScreenStack.mm

@@ -259,6 +259,7 @@ - (void)initCommonProps
   _controller = [RNSNavigationController new];
   _controller.delegate = self;
   _sinkEventsPanGestureRecognizer = [[UIPanGestureRecognizer alloc] init];
+  _iosPreventReattachmentOfDismissedScreens = YES;
 #if !TARGET_OS_TV && !TARGET_OS_VISION
   [self setupGestureHandlers];
 #endif
@@ -1560,6 +1561,7 @@ @implementation RNSScreenStackManager {
 RCT_EXPORT_MODULE()
 
 RCT_EXPORT_VIEW_PROPERTY(onFinishTransitioning, RCTDirectEventBlock);
+RCT_EXPORT_VIEW_PROPERTY(iosPreventReattachmentOfDismissedScreens, BOOL);
 
 #ifdef RCT_NEW_ARCH_ENABLED
 #else

src/fabric/ScreenStackNativeComponent.ts

@@ -7,7 +7,7 @@ import type { CodegenTypes as CT, ViewProps } from 'react-native';
 type FinishTransitioningEvent = Readonly<{}>;
 
 export interface NativeProps extends ViewProps {
-  iosPreventReattachmentOfDismissedScreens?: CT.WithDefault<boolean, false>;
+  iosPreventReattachmentOfDismissedScreens?: CT.WithDefault<boolean, true>;
 
   onFinishTransitioning?: CT.DirectEventHandler<FinishTransitioningEvent>;
 }

src/flags.ts

@@ -4,7 +4,7 @@ const RNS_SYNCHRONOUS_HEADER_CONFIG_STATE_UPDATES_DEFAULT = false;
 const RNS_SYNCHRONOUS_HEADER_SUBVIEW_STATE_UPDATES_DEFAULT = false;
 const RNS_ANDROID_RESET_SCREEN_SHADOW_STATE_ON_ORIENTATION_CHANGE_DEFAULT =
   true;
-const RNS_IOS_PREVENT_REATTACHMENT_OF_DISMISSED_SCREENS = false;
+const RNS_IOS_PREVENT_REATTACHMENT_OF_DISMISSED_SCREENS = true;
 
 // TODO: Migrate freeze here