fix: log error and error stack in exception handler

Author: adrobuta

lib/analyzer/image-inspector.ts

@@ -212,8 +212,11 @@ async function getImageArchive(
 
   try {
     inspectResult = await getInspectResult(docker, targetImage);
-  } catch {
-    debug(`${targetImage} does not exist locally, proceeding to pull image.`);
+  } catch (error) {
+    debug(
+      `${targetImage} does not exist locally, proceeding to pull image.`,
+      error.stack || error,
+    );
   }
 
   if (inspectResult === undefined) {

test/system/plugin.spec.ts

@@ -1,5 +1,6 @@
 import { DepGraph } from "@snyk/dep-graph";
 import * as plugin from "../../lib";
+import * as subProcess from "../../lib/sub-process";
 import { getFixture } from "../util";
 
 describe("plugin", () => {
@@ -108,6 +109,35 @@ describe("plugin", () => {
     expect(depGraph.rootPkg.version).toEqual("1.19.0");
   });
 
+  describe("when scanning a locally loaded image", () => {
+    const imageName = "busybox";
+    const imageTag = "latest";
+    const imageNameWithTag = `${imageName}:${imageTag}`;
+
+    beforeAll(async () => {
+      const fixturePath = getFixture([
+        "../fixtures/docker-archives",
+        "skopeo-copy/busybox.tar",
+      ]);
+      await subProcess.execute("docker", ["load", "--input", fixturePath]);
+    }, 10000); // 10s timeout for loading image
+
+    afterAll(async () => {
+      await subProcess.execute("docker", ["rmi", imageNameWithTag]);
+    });
+
+    test("should successfully scan a local image loaded from a tar archive", async () => {
+      const pluginResult = await plugin.scan({ path: imageNameWithTag });
+      const depGraph: DepGraph = pluginResult.scanResults[0].facts.find(
+        (fact) => fact.type === "depGraph",
+      )!.data;
+
+      expect(depGraph.rootPkg.name).toEqual(`docker-image|${imageName}`);
+      expect(depGraph.rootPkg.version).toEqual(imageTag);
+      expect(pluginResult.scanResults[0].identity.type).toEqual("linux");
+    });
+  });
+
   test("static scan for Identifier type image (nginx:1.19.0)", async () => {
     // This digest resolves to the `1.19.0` tag. We're using the digest to guarantee we always get the correct
     // image, no matter on which platform this test is run on.