fix: do not default to /bin/bash

Author: adrobuta

lib/sub-process.ts

@@ -13,7 +13,7 @@ function execute(
   options?,
 ): Promise<CmdOutput> {
   const spawnOptions: any = {
-    shell: process.platform !== "win32" ? "/bin/bash" : true,
+    shell: true,
     env: { ...process.env },
   };
   if (options && options.cwd) {

test/lib/sub-process.spec.ts

@@ -1,3 +1,4 @@
+import { quoteAll } from "shescape";
 import { execute } from "../../lib/sub-process";
 
 describe("sub-process", () => {
@@ -31,4 +32,24 @@ describe("sub-process", () => {
     expect(stdout).toContain("NO_PROXY=snyk.com");
     expect(process.env.NO_PROXY).toStrictEqual("example.com");
   });
+
+  describe("quoteAll", () => {
+    const shellOptions = [false, true, "/bin/sh"];
+    if (process.platform !== "win32") {
+      shellOptions.push(
+        "/bin/bash",
+        "/bin/zsh",
+        "/bin/dash",
+        "/bin/ksh",
+        "/bin/csh",
+        "/bin/busybox",
+      );
+    }
+
+    for (const shell of shellOptions) {
+      it(`does not throw when shell is ${shell}`, () => {
+        expect(() => quoteAll(["test"], { shell })).not.toThrow();
+      });
+    }
+  });
 });