Merge pull request #663 from snyk/dotkas/CLI-194/bump-shescape-drop-node-eol-versions

fix: [CLI-914] Removing EOL Node version `18` in favor of `20` - bump `shescape` to `v2.1.0`.

Author: Kaspar Lyngsie

.circleci/config.yml

@@ -9,7 +9,7 @@ orbs:
 defaults: &defaults
   resource_class: small
   docker:
-    - image: cimg/node:18.20
+    - image: cimg/node:20.19
   working_directory: ~/snyk-docker-plugin
 
 windows_defaults: &windows_defaults
@@ -54,10 +54,10 @@ windows_big: &windows_big
 release_defaults: &release_defaults
   resource_class: small
   docker:
-    - image: node:18
+    - image: node:20
   working_directory: ~/snyk-docker-plugin
 
-define: &windows_node_version "18"
+define: &windows_node_version "20.19.1"
 
 commands:
   install_deps:

.nvmrc

@@ -1 +1 @@
-18
+20

appveyor.yml

@@ -17,9 +17,9 @@ cache:
 
 environment:
   matrix:
-    - nodejs_version: "18"
     - nodejs_version: "20"
     - nodejs_version: "22"
+    - nodejs_version: "24"
 
 matrix:
   fast_finish: true

lib/sub-process.ts

@@ -1,5 +1,5 @@
 import * as childProcess from "child_process";
-import { quoteAll } from "shescape";
+import { quoteAll } from "shescape/stateless";
 
 export { execute, CmdOutput };
 interface CmdOutput {
@@ -16,10 +16,10 @@ function execute(
   if (options && options.cwd) {
     spawnOptions.cwd = options.cwd;
   }
-  args = quoteAll(args, spawnOptions);
+  args = quoteAll(args, { ...spawnOptions, flagProtection: false });
 
   // Before spawning an external process, we look if we need to restore the system proxy configuration,
-  // which overides the cli internal proxy configuration.
+  // which overrides the cli internal proxy configuration.
   if (process.env.SNYK_SYSTEM_HTTP_PROXY !== undefined) {
     spawnOptions.env.HTTP_PROXY = process.env.SNYK_SYSTEM_HTTP_PROXY;
   }

package-lock.json

@@ -25,7 +25,7 @@
     "prepare": "npm run build"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=20"
   },
   "dependencies": {
     "@snyk/composer-lockfile-parser": "^1.4.1",
@@ -45,7 +45,7 @@
     "mkdirp": "^1.0.4",
     "packageurl-js": "1.2.0",
     "semver": "^7.6.3",
-    "shescape": "^1.7.4",
+    "shescape": "2.1.0",
     "snyk-nodejs-lockfile-parser": "^2.0.0",
     "snyk-poetry-lockfile-parser": "^1.4.0",
     "snyk-resolve-deps": "^4.7.1",