feat(configuration): flagset-native config resolution — FlagMetadata, prefix keys, ConfigResolver [IDE-1786] (#561)

Author: bastiandoetsch

.circleci/config.yml

@@ -8,7 +8,7 @@ orbs:
 base_image: &base_image
   resource_class: small
   docker:
-    - image: cimg/go:1.24
+    - image: cimg/go:1.26
 
 # Define the jobs we want to run for this project
 jobs:

.gitignore

@@ -45,4 +45,7 @@ Thumbs.db
 ._*
 webidentity.json
 .cursor
-.windsurf
+.windsurf
+
+*IDE-*
+.vscode/

.golangci.yaml

@@ -1,91 +1,10 @@
+version: "2"
 run:
+  concurrency: 4
   build-tags:
     - integration
-  concurrency: 4
   issues-exit-code: 1
-  skip-dirs: []
   tests: true
-  timeout: 5m
-
-linters-settings:
-  errcheck:
-    check-blank: true
-    check-type-assertions: true
-  exhaustive:
-    default-signifies-exhaustive: true
-  goconst:
-    ignore-calls: false
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - experimental
-      - opinionated
-      - performance
-      - style
-  gocyclo:
-    min-complexity: 15
-  gofumpt:
-    module-path: github.com/snyk/go-application-framework
-    extra-rules: true
-  goimports:
-    local-prefixes: github.com/snyk/go-application-framework
-  gosimple:
-    checks: ['all']
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment
-  lll:
-    line-length: 160
-  misspell:
-    locale: US
-  nolintlint:
-    allow-unused: false
-    require-explanation: true
-    require-specific: true
-  prealloc:
-    simple: true
-    range-loops: true
-    for-loops: true
-  promlinter:
-    strict: true
-  revive:
-    rules:
-      - name: blank-imports
-        disabled: true
-      - name: context-as-argument
-      - name: context-keys-type
-      - name: dot-imports
-      - name: error-return
-      - name: error-strings
-      - name: error-naming
-      - name: exported
-        disable-stuttering-check: true
-      - name: if-return
-      - name: increment-decrement
-      - name: var-naming
-      - name: var-declaration
-        disabled: true
-      - name: package-comments
-      - name: range
-      - name: receiver-naming
-      - name: time-naming
-      - name: unexported-return
-      - name: indent-error-flow
-      - name: errorf
-      - name: empty-block
-      - name: superfluous-else
-      - name: unused-parameter
-      - name: unreachable-code
-      - name: redefines-builtin-id
-  staticcheck:
-    checks: ['all']
-  stylecheck:
-    checks: ['all']
-    http-status-code-whitelist: []
-  varcheck:
-    exported-fields: true
-
 linters:
   enable:
     - asasalint
@@ -95,82 +14,131 @@ linters:
     - containedctx
     - contextcheck
     - dogsled
-    # TODO(dupl): revisit
-    #- dupl
     - durationcheck
     - errname
     - errorlint
     - exhaustive
-    # TODO(forbidigo): revisit
-    #- forbidigo
     - forcetypeassert
-    # TODO(goconst): revisit
-    #- goconst
-    # TODO(gocritic): revisit
-    #- gocritic
     - gocyclo
-    # TODO(godot): revisit
-    #- godot
-    # TODO(gofumpt): revisit
-    #- gofumpt
-    # TODO(goimports): revisit
-    #- goimports
     - goprintffuncname
-    # TODO(gosec): revisit; consequences of revoking non-owner file permissions?
-    #- gosec
-    # TODO(interfacebloat): revisit in a followup; will require a breaking API change
-    #- interfacebloat
-    # TODO(ireturn): revisit in a followup; will require a breaking API change
-    #- ireturn
-    # TODO(lll): revisit in followup; formatting
-    #- lll
     - misspell
     - nakedret
-    # TODO(nestif): revisit in a followup; refactor will need more careful review
-    #- nestif
     - nilerr
     - nilnil
-    # TODO(noctx): revisit in a followup; context lifecycle consequences and/or breaking API change
-    #- noctx
     - nolintlint
-    # TODO(prealloc): revisit in a followup; some logic around slices are ignoring errors
-    #- prealloc
     - predeclared
     - promlinter
-    # TODO(revive): revisit in a followup; extensive changes, some breaking. godoc requirement would be good to introduce
-    #- revive
     - rowserrcheck
     - sqlclosecheck
-    # TODO(stylecheck): revisit in a followup; some breaking API changes
-    #- stylecheck
-    # NOTE: removed tagliatelle as it conflicts too much with existing API wireformats
-    # - TODO(usetesting)
-    # TODO(testpackage): improve open vs closed-box testing in a followup
-    #- testpackage
     - thelper
     - tparallel
     - unconvert
     - unparam
     - usestdlibvars
     - wastedassign
     - whitespace
-    # TODO(wrapcheck): wrap errors in a followup
-    #- wrapcheck
-
-issues:
-  exclude-rules:
-    - linters:
-        - staticcheck
-      text: "SA1019"
-    - path: _test\.go
-      linters:
-        - bodyclose
-        - forcetypeassert
-        - goconst
-        - ireturn
-    - path: test/
-      linters:
-        - testpackage
-  include:
-    - EXC0012
-    - EXC0014
+  settings:
+    errcheck:
+      check-type-assertions: true
+      check-blank: true
+    exhaustive:
+      default-signifies-exhaustive: true
+    goconst:
+      ignore-calls: false
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - experimental
+        - opinionated
+        - performance
+        - style
+    gocyclo:
+      min-complexity: 15
+    govet:
+      disable:
+        - fieldalignment
+      enable-all: true
+    lll:
+      line-length: 160
+    misspell:
+      locale: US
+    nolintlint:
+      require-explanation: true
+      require-specific: true
+      allow-unused: false
+    prealloc:
+      simple: true
+      range-loops: true
+      for-loops: true
+    promlinter:
+      strict: true
+    revive:
+      rules:
+        - name: blank-imports
+          disabled: true
+        - name: context-as-argument
+        - name: context-keys-type
+        - name: dot-imports
+        - name: error-return
+        - name: error-strings
+        - name: error-naming
+        - name: exported
+        - name: if-return
+        - name: increment-decrement
+        - name: var-naming
+        - name: var-declaration
+          disabled: true
+        - name: package-comments
+        - name: range
+        - name: receiver-naming
+        - name: time-naming
+        - name: unexported-return
+        - name: indent-error-flow
+        - name: errorf
+        - name: empty-block
+        - name: superfluous-else
+        - name: unused-parameter
+        - name: unreachable-code
+        - name: redefines-builtin-id
+    staticcheck:
+      checks:
+        - all
+        - -ST*
+        - -QF*
+  exclusions:
+    generated: lax
+    presets:
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - staticcheck
+        text: SA1019
+      - linters:
+          - bodyclose
+          - forcetypeassert
+          - goconst
+          - ireturn
+        path: _test\.go
+      - linters:
+          - testpackage
+        path: test/
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  settings:
+    gofumpt:
+      module-path: github.com/snyk/go-application-framework
+      extra-rules: true
+    goimports:
+      local-prefixes:
+        - github.com/snyk/go-application-framework
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -3,7 +3,7 @@ GOOS = $(shell go env GOOS)
 GOARCH = $(shell go env GOARCH)
 
 GO_BIN := $(shell pwd)/.bin
-OVERRIDE_GOCI_LINT_V := v1.64.8
+OVERRIDE_GOCI_LINT_V := v2.10.1
 SHELL := env PATH=$(GO_BIN):$(shell go env GOROOT)/bin:$(PATH) $(SHELL)
 
 .PHONY: format
@@ -47,7 +47,7 @@ generate:
 tools: $(GO_BIN)/golangci-lint
 
 $(GO_BIN)/golangci-lint:
-	curl -sSfL 'https://raw.githubusercontent.com/golangci/golangci-lint/${OVERRIDE_GOCI_LINT_V}/install.sh' | sh -s -- -b ${GO_BIN} ${OVERRIDE_GOCI_LINT_V}
+	curl -sSfL 'https://golangci-lint.run/install.sh' | sh -s -- -b ${GO_BIN} ${OVERRIDE_GOCI_LINT_V}
 
 .PHONY: update-dragonfly
 update-dragonfly:

go.mod

@@ -1,6 +1,6 @@
 module github.com/snyk/go-application-framework
 
-go 1.24.0
+go 1.26.1
 
 require (
 	github.com/charmbracelet/lipgloss v1.1.0
@@ -25,13 +25,12 @@ require (
 
 require (
 	github.com/cenkalti/backoff/v5 v5.0.2
-	github.com/go-git/go-git/v5 v5.14.0
+	github.com/go-git/go-git/v5 v5.16.5
 	github.com/gofrs/flock v0.12.1
 	github.com/manifoldco/promptui v0.9.0
 	github.com/mattn/go-isatty v0.0.20
 	github.com/oapi-codegen/runtime v1.1.1
 	github.com/patrickmn/go-cache v2.1.0+incompatible
-	github.com/puzpuzpuz/xsync v1.5.2
 	github.com/snyk/error-catalog-golang-public v0.0.0-20260205094614-116c03822905
 	github.com/subosito/gotenv v1.6.0
 	golang.org/x/mod v0.30.0
@@ -53,7 +52,7 @@ require (
 	github.com/charmbracelet/x/cellbuf v0.0.13-0.20250311204145-2c3ea96c31dd // indirect
 	github.com/charmbracelet/x/term v0.2.1 // indirect
 	github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e // indirect
-	github.com/cloudflare/circl v1.6.0 // indirect
+	github.com/cloudflare/circl v1.6.1 // indirect
 	github.com/cyphar/filepath-securejoin v0.4.1 // indirect
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/dprotaso/go-yit v0.0.0-20240618133044-5a0af90af097 // indirect
@@ -66,7 +65,7 @@ require (
 	github.com/go-git/go-billy/v5 v5.6.2 // indirect
 	github.com/go-openapi/jsonpointer v0.21.1 // indirect
 	github.com/go-openapi/swag v0.23.1 // indirect
-	github.com/go-viper/mapstructure/v2 v2.2.1 // indirect
+	github.com/go-viper/mapstructure/v2 v2.4.0 // indirect
 	github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect