Skip to content

fix: Request verification can be skipped with ssl_check=1 when SSL check middleware is disabled #1494

@homanp

Description

@homanp

When an app is configured with request_verification_enabled=True and ssl_check_enabled=False, a form-encoded request containing ssl_check=1 skips Slack signature verification.

RequestVerification._can_skip currently treats any parsed body with ssl_check=1 as safe to bypass, but that check is independent of whether the SslCheck middleware is enabled. If the SSL-check middleware is disabled, the request can continue through the normal middleware/listener pipeline without a valid Slack signature.

Expected behavior: ssl_check=1 should only bypass normal dispatch when the SSL-check middleware handles the request. If SSL-check handling is disabled, request verification should still require a valid Slack signature.

This affects both sync and async request verification paths.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions