fix(skillgen): open accepted updates ready for review (#469)

Author: harlan-zw

COPY.md

@@ -50,10 +50,10 @@ These exact strings. Do not paraphrase them per page.
 | Nav: MCP server | MCP server · For ChatGPT, Claude, and any app that speaks MCP. | guidance only: a compact row in the Developers menu. Links `/developers?setup=mcp`. The line is the MCP setup card on `/developers` |
 | Nav: SDK | SDK · For your own code, with the TypeScript SDK or plain HTTP. | guidance only: a compact row in the Developers menu. Links `/developers?setup=api`. The line is the API setup card on `/developers` |
 | Nav: make | Make a skill · Write a Skill for your package or project, then keep it current. · Guides and three authoring Skills · Skillgen drafts updates after each release · Get the steps | guidance only: the large Developers menu card: name, line, its two routes, action. Links `/make-skill`, which routes to the guides or to `/skillgen`. The three are `generate-package-skill`, `generate-project-skill` and `review-skill` |
-| Make a skill: Skillgen route | Already ship a package Skill? · Keep it current with Skillgen · After each release tag, Skillgen opens a draft pull request that updates your Skill. npm packages only. | guidance only: the second question on `/make-skill`, under the Skill kinds. Links `/skillgen`. The badge reads "GitHub App" |
+| Make a skill: Skillgen route | Already ship a package Skill? · Keep it current with Skillgen · After each release tag, Skillgen opens a pull request that updates your Skill. npm packages only. | guidance only: the second question on `/make-skill`, under the Skill kinds. Links `/skillgen`. The badge reads "GitHub App" |
 | Nav: setup guides | All setup guides | guidance only: the link under the Developers menu cards. Links `/developers` |
-| Skillgen lead | Keep your package skill current. After each release tag, Skillgen opens a draft pull request that updates the Skill in your repository. You review it and decide what merges. | guidance only: the `/skillgen` line under the H1. Its first two sentences are the page's meta description. A "Make a skill" link above the H1 returns to `/make-skill` |
-| Skillgen opt-in | Skillgen opens a draft pull request after each release tag. It runs only on the repositories you turn on here. | guidance only: the intro of the Skillgen view on `/me?view=skillgen`. The `/skillgen` step 02 says the same in its own words: Skillgen never runs on a repository you did not turn on |
+| Skillgen lead | Keep your package skill current. After each release tag, Skillgen opens a pull request that updates the Skill in your repository. You review it and decide what merges. | guidance only: the `/skillgen` line under the H1. Its first two sentences are the page's meta description. A "Make a skill" link above the H1 returns to `/make-skill` |
+| Skillgen opt-in | Skillgen opens a pull request after each release tag. It runs only on the repositories you turn on here. | guidance only: the intro of the Skillgen view on `/me?view=skillgen`. The `/skillgen` step 02 says the same in its own words: Skillgen never runs on a repository you did not turn on |
 | Skillgen groups | Ready · Needs a change · Turn on all (n) · n of n on | guidance only: the two groups on `/me?view=skillgen`. Ready rows say "Updates <package> on each new tag." when on and "Can update <package> when you turn it on." when off. Needs a change rows show the refusal sentence from `skillgenRefusal` |
 | CLI H1 | The skilld CLI | guidance only: the `/cli` H1 and its OG title |
 | CLI line | Search, run, install, and keep Skills current. | guidance only: the `/cli` line under the H1. It is the CLI's own `--help` line, so change it in the CLI first |

GLOSSARY.md

@@ -30,7 +30,7 @@ Shared terms match the skilld CLI glossary (`skilld-dev/skilld/GLOSSARY.md`). Th
 | skilld token | `cli_tokens`, `layers/identity` | Author 1—N token | "skilld token" |
 | provenance | Skill detail, cards | Skill 1—1 author and source link | "written by", "source" |
 | behavior | `skilld-protocol/behaviors`, Skill page | Skill 1—N behavior | "Skill behaviors" |
-| Skillgen | `workers/skill-harness`, `/skillgen` | Repository 1—N draft pull request | "Skillgen" |
+| Skillgen | `workers/skill-harness`, `/skillgen` | Repository 1—N pull request | "Skillgen" |
 | task search | search box, `layers/registry` | sentence 1—N Skill | "Find skills for this task" |
 
 Collisions
@@ -264,7 +264,7 @@ Existing route paths, table names, and protocol fields keep their identifiers.
 
 ### Skillgen
 
-**Is:** the `skilld-skillgen` GitHub App. After each release tag, it opens a draft pull request that updates a package skill. The maintainer reviews it and decides what merges.
+**Is:** the `skilld-skillgen` GitHub App. After each release tag, it opens a pull request that updates a package skill. The maintainer reviews it and decides what merges.
 
 **Use for:** the App and its per-repository switch. A maintainer turns Skillgen on for each repository on their account page, and it runs nowhere else. It supports npm packages only.
 

docs/runbooks/skillgen.md

@@ -3,7 +3,7 @@
 <!-- eslint-disable harlanzw/ai-deslop-buzzwords -- GLOSSARY.md defines Harness as a product noun. -->
 
 Skillgen is the `skilld-skillgen` GitHub App.
-It maintains an existing package skill through draft pull requests.
+It maintains an existing package skill through pull requests.
 It runs only on a public repository whose maintainer turned it on at `/me?view=skillgen`.
 Maintainers set it up from [/skillgen](https://skilld.dev/skillgen).
 
@@ -58,7 +58,7 @@ Each job lists the packages with a Skill on the default branch.
 It reads each one's `package.json` from the exact tag commit, and skips private packages.
 The tag must equal a package version, as `1.2.3`, `v1.2.3`, or `name@1.2.3`.
 If several packages match one tag, the job splits into one job per package.
-Each split job opens its own draft on a branch named after the package directory.
+Each split job opens its own pull request on a branch named after the package directory.
 If the package publication follows the tag, the job waits for it.
 The whole job has a thirty minute deadline.
 

layers/identity/app/components/_SkillgenRepositories.vue

@@ -80,7 +80,7 @@ const signInAgain = computed(() => error.value?.statusCode === 401)
       Skillgen repositories
     </h2>
     <p class="max-w-2xl text-sm leading-relaxed text-muted">
-      Skillgen opens a draft pull request after each release tag. It runs only on the repositories you turn on here. Then
+      Skillgen opens a pull request after each release tag. It runs only on the repositories you turn on here. Then
       <a :href="INSTALL_URL" target="_blank" rel="noopener" class="text-default underline underline-offset-2 hover:text-primary">install the App</a>
       on the same repositories.
       <NuxtLink to="/skillgen" class="text-default underline underline-offset-2 hover:text-primary">

layers/marketing/app/pages/make-skill.vue

@@ -139,7 +139,7 @@ useHead({ link: [{ rel: 'canonical', href: 'https://skilld.dev/make-skill' }] })
             <span id="skillgen-label" class="text-base font-medium">Keep it current with Skillgen</span>
             <UBadge label="GitHub App" color="neutral" variant="outline" size="sm" class="font-mono" />
           </span>
-          <span class="mt-1 block text-sm font-normal text-muted">After each release tag, Skillgen opens a draft pull request that updates your Skill. npm packages only.</span>
+          <span class="mt-1 block text-sm font-normal text-muted">After each release tag, Skillgen opens a pull request that updates your Skill. npm packages only.</span>
         </span>
         <UIcon name="i-lucide-arrow-right" class="size-4 shrink-0 text-muted" aria-hidden="true" />
       </UButton>
@@ -252,7 +252,7 @@ useHead({ link: [{ rel: 'canonical', href: 'https://skilld.dev/make-skill' }] })
       <div v-if="ecosystem === 'npm'" class="mt-8 flex items-start gap-3 border-t border-default pt-6">
         <UIcon name="i-lucide-git-pull-request-draft" class="mt-0.5 size-5 shrink-0 text-muted" aria-hidden="true" />
         <p class="text-sm leading-relaxed text-muted">
-          Once the Skill ships, Skillgen can keep it current. After each release tag, it opens a draft pull request that updates the Skill.
+          Once the Skill ships, Skillgen can keep it current. After each release tag, it opens a pull request that updates the Skill.
           <NuxtLink to="/skillgen" class="text-default underline underline-offset-2 hover:text-primary">
             Set up Skillgen
           </NuxtLink>

layers/marketing/app/pages/skillgen.vue

@@ -5,7 +5,7 @@ import { pageRobots } from '../utils/page-admissions'
 const INSTALL_URL = 'https://github.com/apps/skilld-skillgen/installations/new'
 
 const title = 'Skillgen'
-const description = 'Keep your package skill current. After each release tag, Skillgen opens a draft pull request that updates the Skill in your repository.'
+const description = 'Keep your package skill current. After each release tag, Skillgen opens a pull request that updates the Skill in your repository.'
 const canonicalUrl = 'https://skilld.dev/skillgen'
 
 useSeoMeta({
@@ -40,7 +40,7 @@ const codeClass = 'font-mono text-xs text-default'
         Skillgen
       </h1>
       <p class="mt-4 text-base leading-relaxed text-muted">
-        Keep your package skill current. After each release tag, Skillgen opens a draft pull request that updates the Skill in your repository. You review it and decide what merges.
+        Keep your package skill current. After each release tag, Skillgen opens a pull request that updates the Skill in your repository. You review it and decide what merges.
       </p>
     </header>
 
@@ -66,7 +66,7 @@ const codeClass = 'font-mono text-xs text-default'
                 Up to 9 files and 64 KiB in total: <code :class="codeClass">SKILL.md</code> and Markdown files under <code :class="codeClass">references/</code>.
               </li>
               <li>
-                Release tags that match the package version, such as <code :class="codeClass">1.4.0</code>, <code :class="codeClass">v1.4.0</code> or <code :class="codeClass">name@1.4.0</code>. If one tag releases several packages with Skills, each gets its own draft.
+                Release tags that match the package version, such as <code :class="codeClass">1.4.0</code>, <code :class="codeClass">v1.4.0</code> or <code :class="codeClass">name@1.4.0</code>. If one tag releases several packages with Skills, each gets its own pull request.
               </li>
               <li>
                 npm links each version to its tag commit, through provenance or <code :class="codeClass">gitHead</code>.
@@ -117,7 +117,7 @@ const codeClass = 'font-mono text-xs text-default'
             />
             <ul class="mt-4 list-disc space-y-2 pl-5 text-sm leading-relaxed text-muted">
               <li><strong class="font-medium text-default">Contents: write.</strong> Skillgen pushes one branch for each release.</li>
-              <li><strong class="font-medium text-default">Pull requests: write.</strong> Skillgen opens the draft.</li>
+              <li><strong class="font-medium text-default">Pull requests: write.</strong> Skillgen opens the pull request.</li>
               <li>It asks for no Actions, administration, or issues access.</li>
             </ul>
           </div>
@@ -126,7 +126,7 @@ const codeClass = 'font-mono text-xs text-default'
           <span :class="indexClass" aria-hidden="true">04</span>
           <div class="min-w-0">
             <h3 class="text-base font-medium">
-              Review the draft
+              Review the pull request
             </h3>
             <p class="mt-2 text-sm leading-relaxed text-muted">
               Skillgen starts with your latest tag when you install the App. If you turned the repository on after the install, it starts at your next tag. Each new tag starts another run. If npm has not published the version yet, the run waits. Each run must finish within 30 minutes.
@@ -135,7 +135,7 @@ const codeClass = 'font-mono text-xs text-default'
               A model drafts the update from the tagged source with the skilld Harness. A separate review must accept it before anything reaches your repository. If the Skill needs no change, Skillgen opens nothing.
             </p>
             <p class="mt-3 text-sm leading-relaxed text-muted">
-              Look for a draft pull request titled <code :class="codeClass">docs(skills): update for v1.4.0</code>. It changes only your Skill's folder. Skillgen never overwrites a branch that already exists. You decide what merges.
+              Look for a pull request titled <code :class="codeClass">docs(skills): update for v1.4.0</code>. It changes only your Skill's folder. Skillgen never overwrites a branch that already exists. You decide what merges.
             </p>
           </div>
         </li>

workers/skill-harness/src/github-client.ts

@@ -206,7 +206,7 @@ export async function publishSkill(context: PreparedTag, files: ProofInput['curr
   const title = (context.packageDir ? `docs(skills): update ${packageName} for ${context.tag}` : `docs(skills): update for ${context.tag}`).slice(0, 69)
   const generated = commit.parse(await api(`${prefix}/git/commits`, 'POST', { message: title, tree: tree.sha, parents: [context.baseSha] }))
   await api(`${prefix}/git/refs`, 'POST', { ref: `refs/heads/${branch}`, sha: generated.sha })
-  const body = `🤖 This draft was written by the skilld GitHub App.\n\nUpdates the existing Skill for ${context.input.spec}.\nSource tag: ${context.tag}. Source commit: ${context.targetSha}.\n\nThe Harness generated these files and a separate review accepted them.\nA maintainer must check the examples before merging.\n\n> 🤖 AI disclosure: [Harlan Agent Kit](https://github.com/harlan-zw/harlan-agent-kit) modified this description. [My AI open-source policy](https://harlanzw.com/blog/ai-in-open-source).`
-  const published = pull.parse(await api(`${prefix}/pulls`, 'POST', { title, head: branch, base: context.baseBranch, body, draft: true }))
+  const body = `🤖 This pull request was written by the skilld GitHub App.\n\nUpdates the existing Skill for ${context.input.spec}.\nSource tag: ${context.tag}. Source commit: ${context.targetSha}.\n\nThe Harness generated these files and a separate review accepted them.\nA maintainer must check the examples before merging.\n\n> 🤖 AI disclosure: [Harlan Agent Kit](https://github.com/harlan-zw/harlan-agent-kit) modified this description. [My AI open-source policy](https://harlanzw.com/blog/ai-in-open-source).`
+  const published = pull.parse(await api(`${prefix}/pulls`, 'POST', { title, head: branch, base: context.baseBranch, body, draft: false }))
   return { _tag: 'Published', url: published.html_url }
 }

workers/skill-harness/test/github-app.test.ts

@@ -102,7 +102,7 @@ describe('skill publication', () => {
     })
     expect(result).toEqual({ _tag: 'Conflict' })
   })
-  it('publishes only Skill changes and marks the pull request as a draft', async () => {
+  it('publishes only Skill changes in a pull request ready for review', async () => {
     const writes: { path: string, body: unknown }[] = []
     const result = await publishSkill(context, [{ path: 'SKILL.md', content: 'new' }], async (path, method, body) => {
       if (method === 'POST') {
@@ -119,7 +119,7 @@ describe('skill publication', () => {
     })
     expect(result).toEqual({ _tag: 'Published', url: 'https://github.com/harlan-zw/package/pull/2' })
     expect(writes.find(write => write.path.endsWith('/git/trees'))?.body).toMatchObject({ tree: [{ path: 'skills/package/SKILL.md', mode: '100644', type: 'blob', sha: 'd'.repeat(40) }] })
-    expect(writes.find(write => write.path.endsWith('/pulls'))?.body).toMatchObject({ draft: true, base: 'main' })
+    expect(writes.find(write => write.path.endsWith('/pulls'))?.body).toMatchObject({ draft: false, base: 'main' })
   })
 })