Skip to content

Commit aeafa27

Browse files
committed
fix(sso): use issuer as entityID in auto-generated idp metadata xml
1 parent cd0fc46 commit aeafa27

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

apps/sim/app/api/auth/sso/register/route.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ export async function POST(request: NextRequest) {
407407
const computedIdpMetadataXml =
408408
idpMetadata ||
409409
`<?xml version="1.0"?>
410-
<EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata" entityID="${escapeXml(entryPoint)}">
410+
<EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata" entityID="${escapeXml(issuer)}">
411411
<IDPSSODescriptor WantAuthnRequestsSigned="false" protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol">
412412
<KeyDescriptor use="signing">
413413
<ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">

packages/db/scripts/register-sso-provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ function buildSSOConfigFromEnv(): SSOProviderConfig | null {
283283
.replace(/\s/g, '')
284284
const escapedEntryPoint = escapeXml(entryPoint)
285285
computedIdpMetadata = `<?xml version="1.0"?>
286-
<EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata" entityID="${escapedEntryPoint}">
286+
<EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata" entityID="${escapeXml(issuer)}">
287287
<IDPSSODescriptor WantAuthnRequestsSigned="false" protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol">
288288
<KeyDescriptor use="signing">
289289
<ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">

0 commit comments

Comments
 (0)