Skip to content

Commit 8578439

Browse files
renamed local variable in entity factories
$classData was not descriptive enough, changed to $entityClassName
1 parent 899c1df commit 8578439

62 files changed

Lines changed: 130 additions & 130 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/Component/Cron/CronModuleFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public function __construct(protected readonly EntityNameResolver $entityNameRes
2121
*/
2222
public function create(string $serviceId): CronModule
2323
{
24-
$classData = $this->entityNameResolver->resolve(CronModule::class);
24+
$entityClassName = $this->entityNameResolver->resolve(CronModule::class);
2525

26-
return new $classData($serviceId);
26+
return new $entityClassName($serviceId);
2727
}
2828
}

src/Component/Cron/CronModuleRunFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ public function __construct(
2222
*/
2323
public function createFromFinishedCronModule(CronModule $cronModule): CronModuleRun
2424
{
25-
$classData = $this->entityNameResolver->resolve(CronModuleRun::class);
25+
$entityClassName = $this->entityNameResolver->resolve(CronModuleRun::class);
2626

27-
return new $classData(
27+
return new $entityClassName(
2828
$cronModule,
2929
$cronModule->getStatus(),
3030
$cronModule->getLastStartedAt(),

src/Component/DataFixture/PersistentReferenceFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ public function create(
2626
string $entityName,
2727
int $entityId,
2828
): PersistentReference {
29-
$classData = $this->entityNameResolver->resolve(PersistentReference::class);
29+
$entityClassName = $this->entityNameResolver->resolve(PersistentReference::class);
3030

31-
return new $classData($referenceName, $entityName, $entityId);
31+
return new $entityClassName($referenceName, $entityName, $entityId);
3232
}
3333
}

src/Component/Image/ImageFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ public function create(
4242
$temporaryFilePath = $this->fileUpload->getTemporaryFilepath($temporaryFilename);
4343
$convertedFilePath = $this->imageProcessor->convertToShopFormatAndGetNewFilename($temporaryFilePath);
4444

45-
$classData = $this->entityNameResolver->resolve(Image::class);
45+
$entityClassName = $this->entityNameResolver->resolve(Image::class);
4646

47-
return new $classData($entityName, $entityId, $namesIndexedByLocale, $convertedFilePath, $type);
47+
return new $entityClassName($entityName, $entityId, $namesIndexedByLocale, $convertedFilePath, $type);
4848
}
4949

5050
/**

src/Component/Router/FriendlyUrl/FriendlyUrlFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ public function create(
3333
int $domainId,
3434
string $slug,
3535
): FriendlyUrl {
36-
$classData = $this->entityNameResolver->resolve(FriendlyUrl::class);
36+
$entityClassName = $this->entityNameResolver->resolve(FriendlyUrl::class);
3737

38-
return new $classData($routeName, $entityId, $domainId, $slug);
38+
return new $entityClassName($routeName, $entityId, $domainId, $slug);
3939
}
4040

4141
/**

src/Component/Setting/SettingValueFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ public function create(
2626
$value,
2727
int $domainId,
2828
): SettingValue {
29-
$classData = $this->entityNameResolver->resolve(SettingValue::class);
29+
$entityClassName = $this->entityNameResolver->resolve(SettingValue::class);
3030

31-
return new $classData($name, $value, $domainId);
31+
return new $entityClassName($name, $value, $domainId);
3232
}
3333
}

src/Component/UploadedFile/UploadedFileFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ public function create(
3838
): UploadedFile {
3939
$temporaryFilepath = $this->fileUpload->getTemporaryFilepath($temporaryFilename);
4040

41-
$classData = $this->entityNameResolver->resolve(UploadedFile::class);
41+
$entityClassName = $this->entityNameResolver->resolve(UploadedFile::class);
4242

43-
return new $classData($entityName, $entityId, $type, pathinfo(
43+
return new $entityClassName($entityName, $entityId, $type, pathinfo(
4444
$temporaryFilepath,
4545
PATHINFO_BASENAME,
4646
), $uploadedFilename, $position);

src/Model/Administrator/Activity/AdministratorActivityFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ public function __construct(protected readonly EntityNameResolver $entityNameRes
2323
*/
2424
public function create(Administrator $administrator, string $ipAddress): AdministratorActivity
2525
{
26-
$classData = $this->entityNameResolver->resolve(AdministratorActivity::class);
26+
$entityClassName = $this->entityNameResolver->resolve(AdministratorActivity::class);
2727

28-
return new $classData($administrator, $ipAddress);
28+
return new $entityClassName($administrator, $ipAddress);
2929
}
3030
}

src/Model/Administrator/AdministratorFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public function __construct(protected readonly EntityNameResolver $entityNameRes
2121
*/
2222
public function create(AdministratorData $data): Administrator
2323
{
24-
$classData = $this->entityNameResolver->resolve(Administrator::class);
24+
$entityClassName = $this->entityNameResolver->resolve(Administrator::class);
2525

26-
return new $classData($data);
26+
return new $entityClassName($data);
2727
}
2828
}

src/Model/Administrator/AdministratorGridLimitFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ public function __construct(protected readonly EntityNameResolver $entityNameRes
2323
*/
2424
public function create(Administrator $administrator, string $gridId, int $limit): AdministratorGridLimit
2525
{
26-
$classData = $this->entityNameResolver->resolve(AdministratorGridLimit::class);
26+
$entityClassName = $this->entityNameResolver->resolve(AdministratorGridLimit::class);
2727

28-
return new $classData($administrator, $gridId, $limit);
28+
return new $entityClassName($administrator, $gridId, $limit);
2929
}
3030
}

0 commit comments

Comments
 (0)