frontend API: removed searching in products based on brand, category or flag query

- YAGNI violation

Author: TomasLudvik

src/Model/Product/Filter/ProductFilterConfigFactory.php

@@ -40,18 +40,15 @@ public function __construct(
     /**
      * @param string $locale
      * @param \Shopsys\FrameworkBundle\Model\Category\Category $category
-     * @param string $searchText
      * @return \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterConfig
      */
     public function createForCategory(
         string $locale,
         Category $category,
-        string $searchText,
     ): ProductFilterConfig {
         $productFilterConfigIdsData = $this->productFilterElasticFacade->getProductFilterDataInCategory(
             $category->getId(),
             $this->currentCustomerUser->getPricingGroup(),
-            $searchText,
         );
 
         $aggregatedParameterFilterChoices = $this->parameterFacade->getParameterFilterChoicesByIds(

src/Model/Product/Filter/ProductFilterElasticFacade.php

@@ -25,21 +25,16 @@ public function __construct(
     /**
      * @param int $categoryId
      * @param \Shopsys\FrameworkBundle\Model\Pricing\Group\PricingGroup $pricingGroup
-     * @param string $search
      * @return \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterConfigIdsData
      */
     public function getProductFilterDataInCategory(
         int $categoryId,
         PricingGroup $pricingGroup,
-        string $search,
     ): ProductFilterConfigIdsData {
         $filterQuery = $this->filterQueryFactory->createVisible()
             ->filterOnlySellable()
             ->filterByCategory([$categoryId]);
 
-        if ($search !== '') {
-            $filterQuery = $filterQuery->search($search);
-        }
         $aggregationQuery = $filterQuery
             ->getAggregationQueryForProductFilterConfig($pricingGroup->getId());
         $aggregationResult = $this->client->search($aggregationQuery)['aggregations'];
@@ -68,21 +63,16 @@ public function getProductFilterDataForSearch(
     /**
      * @param int $brandId
      * @param \Shopsys\FrameworkBundle\Model\Pricing\Group\PricingGroup $pricingGroup
-     * @param string $searchText
      * @return \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterConfigIdsData
      */
     public function getProductFilterDataInBrand(
         int $brandId,
         PricingGroup $pricingGroup,
-        string $searchText = '',
     ): ProductFilterConfigIdsData {
         $filterQuery = $this->filterQueryFactory->createVisible()
             ->filterOnlySellable()
             ->filterByBrands([$brandId]);
 
-        if ($searchText !== '') {
-            $filterQuery = $filterQuery->search($searchText);
-        }
         $aggregationQuery = $filterQuery
             ->getAggregationQueryForProductFilterConfig($pricingGroup->getId());
         $aggregationResult = $this->client->search($aggregationQuery)['aggregations'];
@@ -93,21 +83,16 @@ public function getProductFilterDataInBrand(
     /**
      * @param int $flagId
      * @param \Shopsys\FrameworkBundle\Model\Pricing\Group\PricingGroup $pricingGroup
-     * @param string $searchText
      * @return \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterConfigIdsData
      */
     public function getProductFilterDataInFlag(
         int $flagId,
         PricingGroup $pricingGroup,
-        string $searchText = '',
     ): ProductFilterConfigIdsData {
         $filterQuery = $this->filterQueryFactory->createVisible()
             ->filterOnlySellable()
             ->filterByFlags([$flagId]);
 
-        if ($searchText !== '') {
-            $filterQuery = $filterQuery->search($searchText);
-        }
         $aggregationQuery = $filterQuery
             ->getAggregationQueryForProductFilterConfig($pricingGroup->getId());
         $aggregationResult = $this->client->search($aggregationQuery)['aggregations'];

src/Model/Product/ProductOnCurrentDomainElasticFacade.php

@@ -55,17 +55,12 @@ public function getProductFilterCountDataInCategory(
         int $categoryId,
         ProductFilterConfig $productFilterConfig,
         ProductFilterData $productFilterData,
-        string $searchText = '',
     ): ProductFilterCountData {
         $baseFilterQuery = $this->filterQueryFactory->createListableProductsByCategoryIdWithPriceAndStockFilter(
             $categoryId,
             $productFilterData,
         );
 
-        if ($searchText !== '') {
-            $baseFilterQuery = $baseFilterQuery->search($searchText);
-        }
-
         return $this->productFilterCountDataElasticsearchRepository->getProductFilterCountDataInCategory(
             $productFilterData,
             $baseFilterQuery,

src/Model/Product/ProductOnCurrentDomainFacadeInterface.php

@@ -20,14 +20,12 @@ public function getVisibleProductById(int $productId): Product;
      * @param int $categoryId
      * @param \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterConfig $productFilterConfig
      * @param \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterData $productFilterData
-     * @param string $searchText
      * @return \Shopsys\FrameworkBundle\Model\Product\Filter\ProductFilterCountData
      */
     public function getProductFilterCountDataInCategory(
         int $categoryId,
         ProductFilterConfig $productFilterConfig,
         ProductFilterData $productFilterData,
-        string $searchText = '',
     ): ProductFilterCountData;
 
     /**