Skip to content

Commit 18de92a

Browse files
committed
Drop regression tests for figsize validator
Per maintainer preference, omit the parametrized validator tests.
1 parent e33e6a7 commit 18de92a

1 file changed

Lines changed: 0 additions & 60 deletions

File tree

‎tests/pl/test_utils.py‎

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -285,66 +285,6 @@ def test_utils_get_subplots_produces_correct_axs_layout(input_output):
285285
assert axs_visible == [ax.axison for ax in axs.flatten()]
286286

287287

288-
def _call_validator(figsize):
289-
from spatialdata_plot.pl.utils import _validate_show_parameters
290-
291-
_validate_show_parameters(
292-
coordinate_systems=None,
293-
legend_fontsize=None,
294-
legend_fontweight="bold",
295-
legend_loc=None,
296-
legend_fontoutline=None,
297-
na_in_legend=True,
298-
colorbar=True,
299-
colorbar_params=None,
300-
wspace=None,
301-
hspace=0.25,
302-
ncols=4,
303-
frameon=None,
304-
figsize=figsize,
305-
dpi=None,
306-
fig=None,
307-
title=None,
308-
pad_extent=0,
309-
ax=None,
310-
return_ax=False,
311-
save=None,
312-
show=None,
313-
)
314-
315-
316-
@pytest.mark.parametrize(
317-
"figsize",
318-
[
319-
(6.0, 4.0),
320-
[6.0, 4.0],
321-
[6, 4],
322-
np.array([6.0, 4.0]),
323-
None,
324-
],
325-
)
326-
def test_show_accepts_figsize_as_sequence(figsize):
327-
# Regression test for #626.
328-
_call_validator(figsize)
329-
330-
331-
@pytest.mark.parametrize(
332-
"figsize",
333-
[
334-
[6.0, 4.0, 2.0],
335-
[6.0],
336-
["a", "b"],
337-
"big",
338-
42,
339-
{6, 4},
340-
[True, False],
341-
],
342-
)
343-
def test_show_rejects_invalid_figsize(figsize):
344-
with pytest.raises(TypeError, match="figsize"):
345-
_call_validator(figsize)
346-
347-
348288
class TestMultiscaleToSpatialImage:
349289
"""Regression tests for #589: multiscale resolution selection."""
350290

0 commit comments

Comments
 (0)