Skip to content

Commit e2c62d7

Browse files
committed
Fix formatting and shorten comments
1 parent ac7d2a7 commit e2c62d7

2 files changed

Lines changed: 6 additions & 15 deletions

File tree

‎scip-gradle-plugin/src/main/java/org/scip_code/scip_java/gradle/ScipGradlePlugin.java‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,11 @@ private void configureProject(Project project) {
2525
project.getRepositories().add(project.getRepositories().mavenCentral());
2626
project.getRepositories().add(project.getRepositories().mavenLocal());
2727
} catch (InvalidUserCodeException exc) {
28-
// The build declares repositories centrally in settings.gradle with
29-
// RepositoriesMode.FAIL_ON_PROJECT_REPOS, which makes any project-level
30-
// repository an error (issue #847). Repositories are guaranteed to be
31-
// declared in settings in that mode, so the injection is unnecessary.
28+
// FAIL_ON_PROJECT_REPOS forbids project repositories; they are declared
29+
// in settings instead, so the injection isn't needed (issue #847).
3230
project
3331
.getLogger()
34-
.info(
35-
"scip-java: not injecting Maven Central/local repositories: " + exc.getMessage());
32+
.info("scip-java: not injecting Maven Central/local repositories: " + exc.getMessage());
3633
}
3734

3835
Map<String, Object> extraProperties =

‎scip-java/src/test/kotlin/tests/GradleBuildToolTest.kt‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -91,17 +91,11 @@ class GradleBuildToolTest : BuildToolHarness() {
9191
)
9292
)
9393
add(checkGradleBuild("basic", "gradle/basic", expectedScipFiles = 2))
94-
// Regression test: builds that centralize repository declarations in
95-
// settings.gradle with RepositoriesMode.FAIL_ON_PROJECT_REPOS reject any
96-
// project-level repository, so the plugin must not inject Maven
97-
// Central/local into the project.
94+
// Regression test: FAIL_ON_PROJECT_REPOS rejects project-level
95+
// repositories, so the plugin must not inject Maven Central/local.
9896
// https://github.com/scip-code/scip-java/issues/847
9997
add(
100-
checkGradleBuild(
101-
"centralized-repos",
102-
"gradle/centralized-repos",
103-
expectedScipFiles = 1,
104-
)
98+
checkGradleBuild("centralized-repos", "gradle/centralized-repos", expectedScipFiles = 1)
10599
)
106100
add(
107101
checkGradleBuild(

0 commit comments

Comments
 (0)