Skip to content

Memory Leak From set(contentViewController:) Function #655

Description

@Obsidian-Watermelon
スクリーンショット 2024-12-13 17 41 51

Description

As shown in the screenshot, there seems to be a retain cycle occurring when SurfaceView set(contentView:mode:) function is running in the set(contentViewController:) function in FloatingPanelController. I believe it is occurring since the contentView being passed as a parameter is being added as a subView rather that SurfaceView's self.contentView being added.

Steps to reproduce

Code example that reproduces the issue
let contentVC = ContentViewController()
self.fpc.set(contentViewController: contentVC)

How do you display panel(s)?

  • Add as child view controllers

How many panels do you displays?

  • 1

Environment

Library version
2.8.6

Installation method

  • CocoaPods

iOS version(s)
18.1.1

Xcode version
16.2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions