diff --git a/src/Providers/ModuleServiceProvider.php b/src/Providers/ModuleServiceProvider.php index 7ae75f9..eea1102 100644 --- a/src/Providers/ModuleServiceProvider.php +++ b/src/Providers/ModuleServiceProvider.php @@ -5,6 +5,7 @@ use Illuminate\Support\ServiceProvider; use Illuminate\Support\Str; use InterNACHI\Modular\Support\ModuleRegistry; +use Saucebase\Core\CoreServiceProvider; abstract class ModuleServiceProvider extends ServiceProvider { @@ -37,6 +38,11 @@ public function boot(): void */ public function register(): void { + // Laravel registers discovered packages alphabetically, so a module named + // before "core" gets here first and moduleName() would find no registry. + // Registering an already-registered provider is a no-op. + $this->app->register(CoreServiceProvider::class); + // Config is merged here rather than in boot() because every register() runs // before any boot(): a provider that reads a module's config while booting — // Filament resolving its panels, for one — would otherwise race the merge and diff --git a/tests/Feature/ModuleBootOrderTest.php b/tests/Feature/ModuleBootOrderTest.php new file mode 100644 index 0000000..5cc5158 --- /dev/null +++ b/tests/Feature/ModuleBootOrderTest.php @@ -0,0 +1,27 @@ +fixtureModuleProviders(), ...parent::getPackageProviders($app)]; + } + + public function test_a_module_registered_before_core_still_merges_its_config(): void + { + $this->assertSame('Module Test Fixture', config('module-test-fixture.name')); + } +}