From 439afd7fd512fd34a650ec93196688a4d062e31c Mon Sep 17 00:00:00 2001 From: Salem Date: Mon, 10 Aug 2026 18:53:10 +0300 Subject: [PATCH] Credit oh-my-pi as the origin of the advisor design Advisor is a bb port of oh-my-pi's advisor. Name that in the intro and in a Credits section, alongside pasky's pi-omplike-advisor port to upstream pi. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01RtFj6F6knqncNGAyv7rscC --- README.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/README.md b/README.md index fb3c933..af27dca 100644 --- a/README.md +++ b/README.md @@ -16,6 +16,10 @@ reviewer runs in its own hidden thread with its own context, remembers what it has already flagged, and escalates when the same defect comes back. A review that cannot run reports as *unavailable*, never as approval. +Advisor is a bb port of the advisor from +[oh-my-pi](https://github.com/can1357/oh-my-pi) — the design is theirs. See +[Credits](#credits). +

Play the 22-second demo →
@@ -278,6 +282,18 @@ npm pack --dry-run The GitHub Actions workflow runs the same typecheck, test, build, and package checks on pushes to `main` and on pull requests. +## Credits + +The advisor concept — a persistent second model that reviews the primary +agent's work, holds findings across turns, and injects advice back into the +conversation — originates in [oh-my-pi](https://github.com/can1357/oh-my-pi) +by can1357. This plugin is a re-implementation of that design on bb's plugin +surface; the ideas are omp's, the bb-specific code is new. + +[pi-omplike-advisor](https://github.com/pasky/pi-omplike-advisor) by pasky +ports the same design to upstream pi and is worth reading for its own take on +advice delivery and advisor context management. + ## License MIT © 2026 Salem Sayed Abdel Gawad. See [LICENSE](./LICENSE).