From 0b9bd1a08c97362e2910a0a1ca80d3c2be931211 Mon Sep 17 00:00:00 2001 From: itvi-1234 Date: Mon, 9 Nov 2026 20:09:11 +0530 Subject: [PATCH] Record the root extension version in Python binding manifests The Python profiler checks that the binding manifest's extension identity equals the binding model's rootExtension, which includes the version. The manifest carried only id and semanticSha256, so profile generation from an installed Python binding failed with "'version' is a required property". Allow an optional version in the manifest's extension block, write it from rootExtension in the Python emitter, and regenerate the Python bindings for common-integrations and env-configuration. --- .../python/runtimeconditions.file-manifest.yaml | 2 +- .../runtimeconditions.bindings.yaml | 3 ++- .../python/runtimeconditions.file-manifest.yaml | 4 ++-- .../runtimeconditions.binding-release.yaml | 2 +- .../runtimeconditions.bindings.yaml | 3 ++- .../python/src/runtimeconditions_binding_emitter/metadata.py | 1 + .../extension-bindings/emitters/python/tests/test_emitter.py | 1 + .../extension-bindings/emitters/python/tests/test_packages.py | 1 + .../model/runtimeconditions.binding-manifest.schema.yaml | 1 + 9 files changed, 12 insertions(+), 6 deletions(-) diff --git a/bindings/common-integrations/python/runtimeconditions.file-manifest.yaml b/bindings/common-integrations/python/runtimeconditions.file-manifest.yaml index 13cbc56..2bc74f0 100644 --- a/bindings/common-integrations/python/runtimeconditions.file-manifest.yaml +++ b/bindings/common-integrations/python/runtimeconditions.file-manifest.yaml @@ -8,5 +8,5 @@ files: src/runtimeconditions_common_integrations/py.typed: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 src/runtimeconditions_common_integrations/runtimeconditions.binding-model.yaml: ddaebd0f2eeca51a92beb671ce122157337bb0dd0f61edfc74e9b1d854b80020 src/runtimeconditions_common_integrations/runtimeconditions.binding-release.yaml: 4959872a471a593b7cb810417b89d2dfbd1cfaf81cab43305a644dc4bb3ed0a2 - src/runtimeconditions_common_integrations/runtimeconditions.bindings.yaml: f04d4f564a8530a2295818d8b9e1b0d14032473cf26cb91188da97373cf8e135 + src/runtimeconditions_common_integrations/runtimeconditions.bindings.yaml: 5e5f4fe041cc3e4e41da7761e99228448f757f044a97e277386711f62a21f7c1 src/runtimeconditions_common_integrations/runtimeconditions.extension.yaml: ef0d9e71d0d5d481c367002cecd2d3eef15475a40493f231521d778492a216ed diff --git a/bindings/common-integrations/python/src/runtimeconditions_common_integrations/runtimeconditions.bindings.yaml b/bindings/common-integrations/python/src/runtimeconditions_common_integrations/runtimeconditions.bindings.yaml index e143f05..f34faf4 100644 --- a/bindings/common-integrations/python/src/runtimeconditions_common_integrations/runtimeconditions.bindings.yaml +++ b/bindings/common-integrations/python/src/runtimeconditions_common_integrations/runtimeconditions.bindings.yaml @@ -3,13 +3,14 @@ apiVersion: runtimeconditions.io/bindings/v1alpha2 kind: RuntimeConditionsBindingManifest generated: nonEditable: true - emitter: runtimeconditions-binding-emitter@sha256:d84391391bfed31dc59a94ff17cd7beecc388dccef5619064b6991f2272af50d + emitter: runtimeconditions-binding-emitter@sha256:59ff69f7659a0691559ef1dcab8c2b9e181085e8922b46f6eb81d4623952632c version: 0.1.0 model: apiVersion: runtimeconditions.io/binding-model/v1alpha1 semanticSha256: f93d1280658fb9c27c965b1cc8f5518575cfe5bca7f36ac96dcc06c5b66aacbf extension: id: https://runtimeconditions.io/extensions/common-integrations/v1alpha1/runtimeconditions.extension.yaml + version: v1alpha1 semanticSha256: 0952ff5e52486a87e64808a09e8aa28d124a00efdeb9e174c4153d644879d54c package: language: python diff --git a/bindings/env-configuration/python/runtimeconditions.file-manifest.yaml b/bindings/env-configuration/python/runtimeconditions.file-manifest.yaml index 7edd931..5913394 100644 --- a/bindings/env-configuration/python/runtimeconditions.file-manifest.yaml +++ b/bindings/env-configuration/python/runtimeconditions.file-manifest.yaml @@ -7,6 +7,6 @@ files: src/runtimeconditions_env_configuration/bindings.py: 5e5d2796985c1e4e0df09dba9113a581aa53285638b3adb67febc2e117f4a090 src/runtimeconditions_env_configuration/py.typed: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 src/runtimeconditions_env_configuration/runtimeconditions.binding-model.yaml: f9197dd2f5ab4ae932b158ca010c28c6ffe5cd4efbb1a252e1e67840d79da4ba - src/runtimeconditions_env_configuration/runtimeconditions.binding-release.yaml: 889dabbf363dd5556886cc922bd5d7fd559176254fda8f6e8c59de69b59a35b0 - src/runtimeconditions_env_configuration/runtimeconditions.bindings.yaml: 51e5836e2595a07518fdb7689197db9face335d41a4627b1bebc8940399c7926 + src/runtimeconditions_env_configuration/runtimeconditions.binding-release.yaml: e8aa2367d83ae1ab998be72818dd013b7118ffb5cafd818ec4d0f0e5f8cf7c4f + src/runtimeconditions_env_configuration/runtimeconditions.bindings.yaml: d7aa7a791d0265cbca48849ca9b445fb5b2cc1991af1e14f873a7277d6ba07ed src/runtimeconditions_env_configuration/runtimeconditions.extension.yaml: 645e5de82fcfc22c1e3b3bf06534c0cf13baed12b4994548a1f9a9be53a9e7f4 diff --git a/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.binding-release.yaml b/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.binding-release.yaml index f581421..a8b07f8 100644 --- a/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.binding-release.yaml +++ b/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.binding-release.yaml @@ -31,7 +31,7 @@ package: packageDependencies: - artifact: kind: python-wheel - sha256: 105c9081799a5db97f5261b3ba3a4d9f65523b2331751bb6da3bdfcea3c2a620 + sha256: 67e561bd7295c966892e1d74a747c2fb0c17bd0941e6a0fee64b9b0f5a1a67ea compatibleVersionRange: minimumInclusive: 0.1.0 nextBreakingExclusive: 0.2.0 diff --git a/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.bindings.yaml b/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.bindings.yaml index 2be72b3..06a4136 100644 --- a/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.bindings.yaml +++ b/bindings/env-configuration/python/src/runtimeconditions_env_configuration/runtimeconditions.bindings.yaml @@ -3,13 +3,14 @@ apiVersion: runtimeconditions.io/bindings/v1alpha2 kind: RuntimeConditionsBindingManifest generated: nonEditable: true - emitter: runtimeconditions-binding-emitter@sha256:d84391391bfed31dc59a94ff17cd7beecc388dccef5619064b6991f2272af50d + emitter: runtimeconditions-binding-emitter@sha256:59ff69f7659a0691559ef1dcab8c2b9e181085e8922b46f6eb81d4623952632c version: 0.1.0 model: apiVersion: runtimeconditions.io/binding-model/v1alpha1 semanticSha256: 94b3df3073294c54ad047a1309531f32d4556ca5be3a06cad87a1867f143502a extension: id: https://runtimeconditions.io/extensions/env-configuration/v1alpha1/runtimeconditions.extension.yaml + version: v1alpha1 semanticSha256: c6bd5fec1cc31b2b828cb97da2f56773862a70ef04e94dac7652f87a0af7435b package: language: python diff --git a/tooling/extension-bindings/emitters/python/src/runtimeconditions_binding_emitter/metadata.py b/tooling/extension-bindings/emitters/python/src/runtimeconditions_binding_emitter/metadata.py index f7028ee..a34badb 100644 --- a/tooling/extension-bindings/emitters/python/src/runtimeconditions_binding_emitter/metadata.py +++ b/tooling/extension-bindings/emitters/python/src/runtimeconditions_binding_emitter/metadata.py @@ -339,6 +339,7 @@ def _manifest(plan: EmissionPlan, model: dict[str, Any]) -> str: }, "extension": { "id": model["rootExtension"]["id"], + "version": model["rootExtension"]["version"], "semanticSha256": model["rootExtension"]["semanticSha256"], }, "package": { diff --git a/tooling/extension-bindings/emitters/python/tests/test_emitter.py b/tooling/extension-bindings/emitters/python/tests/test_emitter.py index b87ae8c..0697aab 100644 --- a/tooling/extension-bindings/emitters/python/tests/test_emitter.py +++ b/tooling/extension-bindings/emitters/python/tests/test_emitter.py @@ -814,6 +814,7 @@ def test_package_metadata_and_manifest_are_deterministic(case: str) -> None: assert manifest["model"]["semanticSha256"] == model["metadata"]["semanticSha256"] assert manifest["extension"] == { "id": model["rootExtension"]["id"], + "version": model["rootExtension"]["version"], "semanticSha256": model["rootExtension"]["semanticSha256"], } assert manifest["package"] == { diff --git a/tooling/extension-bindings/emitters/python/tests/test_packages.py b/tooling/extension-bindings/emitters/python/tests/test_packages.py index 8a0e0a2..b0b8fdc 100644 --- a/tooling/extension-bindings/emitters/python/tests/test_packages.py +++ b/tooling/extension-bindings/emitters/python/tests/test_packages.py @@ -319,6 +319,7 @@ def _assert_installed(snapshot: list[dict], specs: list[tuple[dict, object]]) -> assert installed["conformance"] is False manifest = yaml.safe_load(installed["manifest"]) assert manifest["extension"]["id"] == model["rootExtension"]["id"] + assert manifest["extension"]["version"] == model["rootExtension"]["version"] assert ( manifest["extension"]["semanticSha256"] == model["rootExtension"]["semanticSha256"] diff --git a/tooling/extension-bindings/model/runtimeconditions.binding-manifest.schema.yaml b/tooling/extension-bindings/model/runtimeconditions.binding-manifest.schema.yaml index ff3f4f2..76683c5 100644 --- a/tooling/extension-bindings/model/runtimeconditions.binding-manifest.schema.yaml +++ b/tooling/extension-bindings/model/runtimeconditions.binding-manifest.schema.yaml @@ -51,6 +51,7 @@ properties: required: [id, semanticSha256] properties: id: {$ref: '#/$defs/extensionIdentifier'} + version: {type: string, minLength: 1} semanticSha256: {$ref: '#/$defs/sha256'} package: description: >-