fix: include period in name validation error message (#6366)

The error message for invalid gem names listed only "letters, numbers,
dashes, and underscores" as allowed characters, but `Patterns::NAME_PATTERN`
also permits periods via `SPECIAL_CHARACTERS`. Updated the message and
corresponding test assertion to include "periods" for consistency.

Fixes #6349

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

Author: mvanhorn

lib/name_format_validator.rb

@@ -5,7 +5,7 @@ def validate_each(record, attribute, value)
     return record.errors.add attribute, "must be a String" if value.class != String
 
     record.errors.add attribute, "must include at least one letter" if requires_letter? && !Patterns::LETTER_REGEXP.match?(value)
-    record.errors.add attribute, "can only include letters, numbers, dashes, and underscores" unless Patterns::NAME_PATTERN.match?(value)
+    record.errors.add attribute, "can only include letters, numbers, periods, dashes, and underscores" unless Patterns::NAME_PATTERN.match?(value)
     record.errors.add attribute, "can not begin with a period, dash, or underscore" if Patterns::SPECIAL_CHAR_PREFIX_REGEXP.match?(value)
     record.errors.add attribute, "can not end with a period, dash, or underscore" if Patterns::SPECIAL_CHAR_SUFFIX_REGEXP.match?(value)
     record.errors.add attribute, "can not end with a common file extension" if Patterns::BANNED_EXTENSION_REGEXP.match?(value)

test/integration/pusher_test.rb

@@ -134,7 +134,7 @@ class PusherIntegrationTest < ActiveSupport::TestCase
       @cutter = Pusher.new(@api_key, @gem)
       @cutter.process
 
-      assert_match(/Dependency unresolved name can only include letters, numbers, dashes, and underscores/, @cutter.message)
+      assert_match(/Dependency unresolved name can only include letters, numbers, periods, dashes, and underscores/, @cutter.message)
       assert_equal 403, @cutter.code
     end