You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 99ff246
Browse filesBrowse the repository at this point in the historyBrowse files
skills: add gotcha 446; queue: comfy-angle round 4 built everything
Round 4 got through gclient sync, gn gen with the prefixed GCC toolchain and all
493 ninja targets, built the wheel and passed the smoke test on cp312/cp313/cp314
- then exited 127 on the last line of the script because the free-threaded
interpreter directory is /opt/python/cp314-cp314t, not cp314t-cp314t.
Copy file name to clipboardExpand all lines: .queue.yml
+21-7Lines changed: 21 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -2317,7 +2317,7 @@ packages:
2317
2317
a gclient sync plus a full ANGLE build does not fit. Validation was static - patch applies with
2318
2318
patch --dry-run --fuzz=0, py_compile of both patched scripts, a unit test of the new
2319
2319
stage_licenses() against a synthetic checkout (including non-UTF8 licence bytes), bash -n of the
2320
-
container script and compile() of both heredocs, and pending_versions.py resolving 0.1.1. PR #2123 open; three CI rounds so far, every one inside gclient sync before anything compiled.
2320
+
container script and compile() of both heredocs, and pending_versions.py resolving 0.1.1. PR #2123 open; four CI rounds so far - the first three never got out of gclient sync, the fourth built everything.
2321
2321
Round 1 (~2 min): vpython3 could not build its venv, since infra/python/wheels publishes no
2322
2322
linux-riscv64 crcmod/lxml (gotcha 423) - fixed by setting VPYTHON_BYPASS for riscv64 hosts in
2323
2323
build_linux.py. Round 2 (~4 min): the bypass worked and moved the wall one layer down - with
@@ -2352,12 +2352,26 @@ packages:
2352
2352
third_party/depot_tools at the same revision the driver clones, so gotcha 427''s gsutil
2353
2353
4.68/six split does not apply (both are 5.35, fine on 3.12), and the Linux hooks that follow
2354
2354
(clang, llvm_objdump, rust, lastchange, configure_siso) import nothing outside the stdlib and
2355
-
depot_tools. Still not rehearsed end to end locally (no docker daemon, 4.5 GB free). Left to
2356
-
watch: those hooks (all 23 use plain python3, so the vpython class of failure is behind us,
2357
-
and update.py maps every Linux host to Linux_x64 so the x86-only prebuilts still download),
2358
-
gn gen with the prefixed GCC toolchain, and whether the statically linked
2359
-
Vulkan-Loader falls back to its C unknown-ext-chain path on riscv64 instead of wanting
2360
-
per-arch assembly.'
2355
+
depot_tools. Still not rehearsed end to end locally (no docker daemon, 4.5 GB free). Round 4
2356
+
(~64 min) closed every open question at once: gclient sync completed, all 23 hooks ran, gn gen
2357
+
with the prefixed GCC toolchain worked, and ninja built all 493 targets - including
2358
+
third_party/vulkan-loader/src/libvulkan.a, so the statically linked Vulkan-Loader does take its
2359
+
portable C unknown-ext-chain path on riscv64 and needs no per-arch assembly. Both of gotcha
2360
+
438''s watch items are therefore closed. libEGL.so and libGLESv2.so linked, scripts/build.py
2361
+
produced the 3.4 MB comfy_angle-0.1.1-py3-none-manylinux_2_39_riscv64.whl with all four
2362
+
expected members, and the smoke test loaded both libraries and printed the real EGL client
2363
+
extension string (EGL_ANGLE_platform_angle_vulkan among them) on cp312, cp313 and cp314; the
2364
+
gpl_sources job passed in parallel. The job then failed on the very last line of the container
2365
+
script with exit 127, purely because the smoke-test loop spelled the free-threaded interpreter
2366
+
/opt/python/cp314t-cp314t while manylinux names that directory cp314-cp314t, so pip was not
2367
+
there and set -e took the step down after the whole build had already succeeded (new gotcha
2368
+
446; the only compile diagnostics in the log are warnings, none of them riscv64-specific).
2369
+
Round 5 changes that one path and nothing else. The fix needed no CI to validate:
2370
+
build-mujoco.yml drives the same manylinux_2_39_riscv64 image with /opt/python/cp314-cp314t and
2371
+
docs/packages/mujoco.yaml lists published cp314-cp314t riscv64 wheels, while
2372
+
build-onnxruntime.yml, build-labmaze.yml and build-vtk.yml all derive the directory as
2373
+
${TAG%t}-${TAG}. Barring a free-threading-specific surprise from loading a py3-none ctypes
2374
+
wrapper, round 5 should be green and publishable.'
0 commit comments