Skip to content

Commit 6351491

Browse files
committed
pymavlink: deselect new v2.4.50 tests hitting the sdist fixture gap
test_context_manager.py's two ContextManagerTest cases (test.BIN) and test_mavgen_typescript.py's only test (snapshottests/resources/common.xml) are new in 2.4.50 and hit the same upstream sdist-packaging gap already worked around for test_mavlogdump.py/test_mavxml.py/RallyTest/FenceTest: the fixture files exist in the git checkout but upstream's sdist only picks up tests/*.py, so cibuildwheel's sandboxed run (which reaches the sdist's tests/ directly, no CIBW_TEST_SOURCES staging involved) gets a FileNotFoundError for the fixture path.
1 parent e5e9185 commit 6351491

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

‎.github/workflows/build-pymavlink.yml‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,17 @@ jobs:
146146
# an earlier test file importing it first (with MAVLINK20 unset) leaves the
147147
# wrong dialect cached for the rest of the pytest run. Everything else in
148148
# the suite is self-contained and order-independent.
149+
# v2.4.50 added two more tests that hit the same sdist gap: test_mavgen_typescript.py's
150+
# only test reads tests/snapshottests/resources/common.xml, and
151+
# ContextManagerTest.test_dfreader_binary/test_mavlink_connection_dataflash (in
152+
# test_context_manager.py, alongside the fixture-free test_mavfile) read test.BIN.
149153
CIBW_TEST_COMMAND: >-
150154
python -m pytest {package}/tests
151155
--ignore={package}/tests/test_mavlogdump.py
152156
--ignore={package}/tests/test_mavxml.py
153-
-k "not RallyTest and not FenceTest and not (MAVWPTest and test_save)"
157+
--ignore={package}/tests/test_mavgen_typescript.py
158+
-k "not RallyTest and not FenceTest and not (MAVWPTest and test_save)
159+
and not (ContextManagerTest and (test_dfreader_binary or test_mavlink_connection_dataflash))"
154160
run: |
155161
set -eux
156162

0 commit comments

Comments
 (0)