pyscf: cd out of the checkout before the licence check

/work/pyscf still holds pyscf.egg-info from the --no-clean pip wheel
build step. python -c puts cwd on sys.path[0], so
importlib.metadata resolves that stale egg-info (no licenses/
subdirectory) instead of the installed wheel, and the licence
assertion sees an empty set. Move the check after the cd /tmp the
later import pyscf smoke test already relies on for the same
reason.

Author: luhenry

.github/workflows/build-pyscf.yml

@@ -127,6 +127,11 @@ jobs:
           "${PYTHON_BIN}" -m pip install -q --only-binary=:all: /work/wheelhouse/*.whl
           "${PYTHON_BIN}" -m pip install -q pytest
 
+          # cd out of /work/pyscf first (gotcha 612): the build step's --no-clean
+          # pip wheel leaves pyscf.egg-info there, and `python -c` puts cwd on
+          # sys.path[0], so importlib.metadata resolves that stale egg-info instead
+          # of the installed wheel and the licence check below sees an empty set.
+          cd /tmp
           licences=$("${PYTHON_BIN}" -c "
           import importlib.metadata as m
           print(sorted(p.name for p in m.files('pyscf') if '.dist-info/licenses/' in str(p)))
@@ -139,7 +144,6 @@ jobs:
           assert expected <= names, names
           "
 
-          cd /tmp
           echo 'pbc_tools_pbc_fft_engine = "NUMPY"' > .pyscf_conf.py
           echo 'scf_hf_SCF_mute_chkfile = True' >> .pyscf_conf.py
           export PYSCF_CONFIG_FILE=/tmp/.pyscf_conf.py