Skip to content

Commit 06d78ea

Browse files
committed
pylance: deselect test_lance_log_file_invalid_path (root-in-container)
The test asserts LANCE_LOG_FILE under an unwritable parent directory never gets created, expecting a permission failure to fall back to stderr logging. The cibuildwheel test phase runs as root in the manylinux container, and root can create arbitrary paths, so the assertion never held here (gotcha 39/83: this is a root-vs-container quirk, not riscv64-specific).
1 parent c468617 commit 06d78ea

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎.github/workflows/build-pylance.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,15 @@ jobs:
133133
# upstream's own `make test` (Makefile: `pytest -vvv -s
134134
# --durations=30 python/tests`, `-n auto --dist loadgroup` from
135135
# run_tests/action.yml's default `pytest-workers: auto`).
136+
# test_lance_log_file_invalid_path asserts LANCE_LOG_FILE under an
137+
# unwritable parent never gets created, but the test phase runs as
138+
# root here (gotcha 39/83), and root can create that path, so the
139+
# assumption behind the test doesn't hold in this container.
136140
CIBW_TEST_COMMAND: >-
137141
cd python &&
138142
python -m pytest python/tests -vvv -s --durations=30
139143
-n auto --dist loadgroup
144+
--deselect python/tests/test_log.py::test_lance_log_file_invalid_path
140145
141146
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
142147
with:

0 commit comments

Comments
 (0)