Skip to content

[Enhancement] Missing CI lint and type-check jobs — TypeScript errors merged to main undetected #866

Description

@RUKAYAT-CODER

Overview

The CI pipeline runs tests but does not run tsc --noEmit or eslint as separate required checks. TypeScript compilation errors and lint violations are merged to main without detection, accumulating technical debt.

Specifications

Features:

  • Add a lint CI job that runs npx eslint . --ext .ts,.tsx --max-warnings 0
  • Add a typecheck CI job that runs npx tsc --noEmit
  • Make both jobs required checks on PR merge

Tasks:

  • Add lint and typecheck jobs to .github/workflows/ci.yml
  • Fix all existing lint and type errors before enabling the gate
  • Document the process for adding a new ESLint disable with justification

Impacted Files:

  • .github/workflows/ci.yml
  • tsconfig.json
  • .eslintrc.js

Acceptance Criteria

  • PRs with TypeScript errors cannot be merged
  • PRs with lint violations cannot be merged
  • CI pipeline completes in under 5 minutes

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programenhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions