From 42a0862463b6ed85e2f4f62d5f90eeca0ebae12c Mon Sep 17 00:00:00 2001 From: Pedro Castro Date: Sun, 10 May 2026 01:14:27 -0300 Subject: [PATCH 1/3] Remove outdated Node.js version guards from docstring tests Node.js 20 has been dropped and the minimum is now v22, so the version guards for Node.js 20+ and 22+ features are no longer needed. --- tests/docstring_tests/DocTest.res | 21 +-------------------- tests/docstring_tests/DocTest.res.js | 20 -------------------- 2 files changed, 1 insertion(+), 40 deletions(-) diff --git a/tests/docstring_tests/DocTest.res b/tests/docstring_tests/DocTest.res index 990c4e02da2..bb9c8dbf81d 100644 --- a/tests/docstring_tests/DocTest.res +++ b/tests/docstring_tests/DocTest.res @@ -14,32 +14,13 @@ let nodeVersion = ->Option.getOrThrow(~message="Failed to convert node version to Int") let ignoreRuntimeTests = [ - ( - // Ignore tests that require Node.js v20+ - 20, - ["Stdlib_Array.toReversed", "Stdlib_Array.toSorted"], - ), - ( - // Ignore tests that require Node.js v22+ - 22, - [ - "Stdlib_Promise.withResolvers", - "Stdlib_Set.union", - "Stdlib_Set.isSupersetOf", - "Stdlib_Set.isSubsetOf", - "Stdlib_Set.isDisjointFrom", - "Stdlib_Set.intersection", - "Stdlib_Set.symmetricDifference", - "Stdlib_Set.difference", - ], - ), ( // Ignore tests that require Node.js v24+ 24, ["Stdlib_RegExp.escape"], ), ( - // Not available in Node.js yet + // Require Node.js 24 (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/setFloat16#browser_compatibility) 1000, ["Stdlib_DataView.getFloat16", "Stdlib_DataView.setFloat16"], ), diff --git a/tests/docstring_tests/DocTest.res.js b/tests/docstring_tests/DocTest.res.js index 13a1e397642..5d0d0e4f491 100644 --- a/tests/docstring_tests/DocTest.res.js +++ b/tests/docstring_tests/DocTest.res.js @@ -21,26 +21,6 @@ let rescript_tools_exe = BinsJs.rescript_tools_exe; let nodeVersion = Stdlib_Option.getOrThrow(Stdlib_Int.fromString(Stdlib_Option.getOrThrow(process.version.replace("v", "").split(".")[0], "Failed to find major version of Node")), "Failed to convert node version to Int"); let ignoreRuntimeTests = [ - [ - 20, - [ - "Stdlib_Array.toReversed", - "Stdlib_Array.toSorted" - ] - ], - [ - 22, - [ - "Stdlib_Promise.withResolvers", - "Stdlib_Set.union", - "Stdlib_Set.isSupersetOf", - "Stdlib_Set.isSubsetOf", - "Stdlib_Set.isDisjointFrom", - "Stdlib_Set.intersection", - "Stdlib_Set.symmetricDifference", - "Stdlib_Set.difference" - ] - ], [ 24, ["Stdlib_RegExp.escape"] From 39f5c846b4c6a9d58e1e36628eca177559fbb5f9 Mon Sep 17 00:00:00 2001 From: Pedro Castro Date: Mon, 11 May 2026 01:27:54 -0300 Subject: [PATCH 2/3] add coment and fix node version --- tests/docstring_tests/DocTest.res | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/docstring_tests/DocTest.res b/tests/docstring_tests/DocTest.res index bb9c8dbf81d..779fa0cf8fc 100644 --- a/tests/docstring_tests/DocTest.res +++ b/tests/docstring_tests/DocTest.res @@ -15,13 +15,13 @@ let nodeVersion = let ignoreRuntimeTests = [ ( - // Ignore tests that require Node.js v24+ + // Ignore tests that require Node.js v24+ (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/escape#browser_compatibility) 24, ["Stdlib_RegExp.escape"], ), ( - // Require Node.js 24 (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/setFloat16#browser_compatibility) - 1000, + // Require Node.js v24+ (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView/setFloat16#browser_compatibility) + 24, ["Stdlib_DataView.getFloat16", "Stdlib_DataView.setFloat16"], ), ] From 9501d5932c3449ea6b5601d8f6c0038a5137c48f Mon Sep 17 00:00:00 2001 From: Pedro Castro Date: Mon, 11 May 2026 02:01:07 -0300 Subject: [PATCH 3/3] add js file --- tests/docstring_tests/DocTest.res.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docstring_tests/DocTest.res.js b/tests/docstring_tests/DocTest.res.js index 5d0d0e4f491..dbe11a97ee1 100644 --- a/tests/docstring_tests/DocTest.res.js +++ b/tests/docstring_tests/DocTest.res.js @@ -26,7 +26,7 @@ let ignoreRuntimeTests = [ ["Stdlib_RegExp.escape"] ], [ - 1000, + 24, [ "Stdlib_DataView.getFloat16", "Stdlib_DataView.setFloat16"