From 1dfdd5f7c0d541f602934d5ffa689257ca9790ec Mon Sep 17 00:00:00 2001 From: David Meister Date: Sun, 14 Jun 2026 20:40:22 +0000 Subject: [PATCH] remove redundant statement flagged by slither The slither bump in the rainix flake now enables the redundant-statements detector, which flags the no-op `evaluableConfigs;` self-reference on src/concrete/Flow.sol line 121. That statement was added (in #465) only to silence the unused-parameter warning introduced by naming the parameter of the typed `initialize(EvaluableConfigV3[])` revert overload. slither exits non-zero before `forge fmt --check` runs, so this fails rainix-sol-static on main and blocks every flow PR. Remove the no-op and drop the now-unused parameter name (unnamed parameters never warn), matching the pre-#465 convention this file already used. NatSpec updated to drop the dangling @param. slither is clean (0 results) and the build is warning-free. Co-Authored-By: Claude Opus 4.8 --- src/concrete/Flow.sol | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/concrete/Flow.sol b/src/concrete/Flow.sol index 24344e83..287064b6 100644 --- a/src/concrete/Flow.sol +++ b/src/concrete/Flow.sol @@ -114,11 +114,9 @@ contract Flow is ERC721Holder, ERC1155Holder, Multicall, ReentrancyGuard, IInter /// The typed `initialize(EvaluableConfigV3[])` overload exists only to /// surface the parameter shape in the ABI for tooling. It MUST always /// revert with `InitializeSignatureFn` per the `ICloneableV2` - /// contract; the canonical entrypoint is `initialize(bytes)`. - /// @param evaluableConfigs Ignored — the function reverts before - /// reading it. Named for ABI clarity only. - function initialize(EvaluableConfigV3[] memory evaluableConfigs) external pure { - evaluableConfigs; + /// contract; the canonical entrypoint is `initialize(bytes)`. The + /// parameter is unnamed because the function reverts before reading it. + function initialize(EvaluableConfigV3[] memory) external pure { revert InitializeSignatureFn(); }