From dad57e51a5bcbf90716a460f3d18e800ae890db3 Mon Sep 17 00:00:00 2001 From: arzafran Date: Tue, 11 Aug 2026 13:39:30 -0300 Subject: [PATCH] fix: idle address text was invisible inside the glass chrome MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The idle-state text color was labelColor while the editing state hard-set white. The chrome row became a vibrancy surface recently, and semantic colors composite through the glass where they can lose all contrast against the dark pill — the URL disappeared until you clicked in. Both states now use the same explicit white every other chrome color in this file already uses. --- src/bro_toolbar.mm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/bro_toolbar.mm b/src/bro_toolbar.mm index 4899e7a..94ad84b 100644 --- a/src/bro_toolbar.mm +++ b/src/bro_toolbar.mm @@ -139,7 +139,11 @@ - (instancetype)initWithFrame:(NSRect)frame { _addressField.bordered = NO; _addressField.drawsBackground = NO; _addressField.focusRingType = NSFocusRingTypeNone; - _addressField.textColor = [NSColor labelColor]; + // Explicit white, not labelColor: the chrome row is a vibrancy surface, + // and semantic colors composite through the glass material where they + // can lose contrast against the dark pill. Every other chrome color in + // this file is already explicit for the same reason. + _addressField.textColor = [NSColor whiteColor]; _addressField.delegate = self; _addressField.cell.scrollable = YES; _addressField.cell.usesSingleLineMode = YES; @@ -507,7 +511,8 @@ - (void)controlTextDidEndEditing:(NSNotification*)notification { if ([_addressField.superview isKindOfClass:[BroTabView class]]) { ((BroTabView*)_addressField.superview).editingAddress = NO; } - _addressField.textColor = [NSColor labelColor]; + // Same explicit white as the init path — see the comment there. + _addressField.textColor = [NSColor whiteColor]; [self displayCompactURL]; } }