closes #98 implemented child block detection

Author: kof

lib/child.js

@@ -16,6 +16,14 @@ var options = JSON.parse(process.argv[2]),
     currentModule = path.basename(options.code.path, '.js'),
     currentTest;
 
+// send ping messages to when child is blocked.
+// after I sent the first ping, testrunner will start to except the next ping
+// within maxBlockDuration, otherwise this process will be killed
+process.send({event: 'ping'});
+setInterval(function() {
+    process.send({event: 'ping'});
+}, Math.floor(options.maxBlockDuration / 2));
+
 process.on('uncaughtException', function(err) {
     if (QUnit.config.current) {
         QUnit.ok(false, 'Test threw unexpected exception: ' + err.message);
@@ -168,3 +176,4 @@ _require(options.code, true);
 options.tests.forEach(function(test) {
     _require(test, false);
 });
+

lib/testrunner.js

@@ -45,7 +45,10 @@ options = exports.options = {
     deps: null,
 
     // define namespace your code will be attached to on global['your namespace']
-    namespace: null
+    namespace: null,
+
+    // max amount of ms child can be blocked, after that we assume running an infinite loop
+    maxBlockDuration: 1000
 };
 
 /**
@@ -55,6 +58,7 @@ options = exports.options = {
  */
 function runOne(opts, callback) {
     var child;
+    var pingCheckTimeoutId;
 
     child = cp.fork(
         __dirname + '/child.js',
@@ -67,28 +71,44 @@ function runOne(opts, callback) {
         child.kill();
     }
 
+    function complete(err, data) {
+        kill();
+        clearTimeout(pingCheckTimeoutId);
+        callback(err, data)
+    }
+
     child.on('message', function(msg) {
-        if (msg.event === 'assertionDone') {
-            log.add('assertions', msg.data);
-        } else if (msg.event === 'testDone') {
-            log.add('tests', msg.data);
-        } else if (msg.event === 'done') {
-            msg.data.code = opts.code.path;
-            log.add('summaries', msg.data);
-            if (opts.coverage) {
-                coverage.add(msg.data.coverage);
-                msg.data.coverage = coverage.get();
-                msg.data.coverage.code = msg.data.code;
-                log.add('coverages', msg.data.coverage);
-            }
-            if (opts.log.testing) {
-                console.log('done');
-            }
-            callback(null, msg.data);
-            kill();
-        } else if (msg.event === 'uncaughtException') {
-            callback(_.extend(new Error(), msg.data));
-            kill();
+        switch (msg.event) {
+            case 'ping':
+                clearTimeout(pingCheckTimeoutId);
+                pingCheckTimeoutId = setTimeout(function() {
+                    complete(new Error('Process blocked for too long'));
+                }, opts.maxBlockDuration);
+                break;
+            case 'assertionDone':
+                log.add('assertions', msg.data);
+                break;
+            case 'testDone':
+                log.add('tests', msg.data);
+                break;
+            case 'done':
+                clearTimeout(pingCheckTimeoutId);
+                msg.data.code = opts.code.path;
+                log.add('summaries', msg.data);
+                if (opts.coverage) {
+                    coverage.add(msg.data.coverage);
+                    msg.data.coverage = coverage.get();
+                    msg.data.coverage.code = msg.data.code;
+                    log.add('coverages', msg.data.coverage);
+                }
+                if (opts.log.testing) {
+                    console.log('done');
+                }
+                complete(null, msg.data);
+                break;
+            case 'uncaughtException':
+                complete(_.extend(new Error(), msg.data));
+                break;
         }
     });
 

package.json

@@ -1,7 +1,7 @@
 {
   "name": "qunit",
   "description": "QUnit testing framework for nodejs",
-  "version": "0.7.2",
+  "version": "0.7.3",
   "author": "Oleg Slobodskoi <oleg008@gmail.com>",
   "contributors": [
     {

readme.md

@@ -97,7 +97,10 @@ var testrunner = require("qunit");
     deps: null,
 
     // define namespace your code will be attached to on global['your namespace']
-    namespace: null
+    namespace: null,
+
+    // max amount of ms child can be blocked, after that we assume running an infinite loop
+    maxBlockDuration: 1000
 }
 ```
 

test/fixtures/infinite-loop-code.js

@@ -0,0 +1 @@
+while(1) {}

test/fixtures/infinite-loop-test.js

@@ -0,0 +1,3 @@
+test('infinite loop', function() {
+    ok(true)
+})

test/testrunner.js

@@ -153,6 +153,16 @@ chain.add('uncaught exception', function() {
     });
 });
 
+chain.add('infinite loop', function() {
+    tr.run({
+        code: fixtures + '/infinite-loop-code.js',
+        tests: fixtures + '/infinite-loop-test.js',
+    }, function(err, res) {
+        a.ok(err instanceof Error, 'error was forwarded');
+        chain.next();
+    });
+});
+
 chain.add('coverage', function() {
     tr.options.coverage = true;
     tr.run({