build: Enforce eslint rules

Fixed violations:
* no-unused-vars
* no-irregular-whitespace
* no-empty

Author: Krinkle

.eslintignore

@@ -0,0 +1 @@
+/coverage

.eslintrc.json

@@ -0,0 +1,10 @@
+{
+  "extends": "eslint:recommended",
+  "env": {
+  	"node": true,
+  	"qunit": true
+  },
+  "rules": {
+  	"no-console": 0
+  }
+}

.jshintrc

@@ -13,14 +13,13 @@ var QUnit = require('qunitjs'),
 require('../support/json/cycle');
 
 var options = JSON.parse(process.argv.pop()),
-    currentModule = path.basename(options.code.path, '.js'),
-    currentTest;
+    currentModule = path.basename(options.code.path, '.js');
 
 // send ping messages to when child is blocked.
 // after I sent the first ping, testrunner will start to except the next ping
 // within maxBlockDuration, otherwise this process will be killed
 process.send({event: 'ping'});
-setInterval(function() {
+setInterval(function() {
     process.send({event: 'ping'});
 }, Math.floor(options.maxBlockDuration / 2));
 
@@ -65,9 +64,6 @@ function _require(res, addToGlobal) {
  * @param {Object} test
  */
 QUnit.testStart(function(test) {
-    // currentTest is undefined while first test is not done yet
-    currentTest = test.name;
-
     // use last module name if no module name defined
     currentModule = test.module || currentModule;
 });

lib/child.js

@@ -10,7 +10,9 @@ var istanbul,
 
 try {
     istanbul = require('istanbul');
-} catch (e) {}
+} catch (e) {
+    // Ignore
+}
 
 exports.setup = function(opts) {
     collector = new istanbul.Collector();

lib/coverage.js

@@ -1,21 +1,25 @@
 'use strict'
 
-/**
- * Is true when generators are supported.
- */
-exports.support = false;
+var supported;
 
 try {
   eval("(function *(){})()");
-  exports.support = true;
-} catch(err) {}
+  supported = true;
+} catch(err) {
+  supported = false;
+}
+
+/**
+ * Is true when generators are supported.
+ */
+exports.support = supported;
 
 /**
  * Returns true if function is a generator fn.
  *
  * @param {Function} fn
  * @return {Boolean}
  */
-exports.isGeneratorFn = function(fn) {
+exports.isGeneratorFn = function(fn) {
     return fn.constructor.name == 'GeneratorFunction';
 }

lib/generators.js

@@ -1,5 +1,4 @@
-var fs = require('fs'),
-    path = require('path'),
+var path = require('path'),
     coverage = require('./coverage'),
     cp = require('child_process'),
     _ = require('underscore'),
@@ -177,7 +176,7 @@ exports.run = function(files, callback) {
         opts.code = absPath(opts.code);
         opts.tests = absPaths(opts.tests);
 
-        runOne(opts, function(err, stat) {
+        runOne(opts, function(err) {
             if (err) {
                 return callback(err, log.stats());
             }

lib/testrunner.js

@@ -34,7 +34,8 @@
     "node": ">=0.6.0 < 8.0"
   },
   "scripts": {
-    "test": "node --harmony ./test/testrunner.js"
+    "test": "node --harmony ./test/testrunner.js && eslint .",
+    "lint": "eslint ."
   },
   "dependencies": {
     "argsparser": "^0.0.6",
@@ -46,6 +47,7 @@
   },
   "devDependencies": {
     "chainer": "^0.0.5",
+    "eslint": "^3.17.1",
     "timekeeper": "^0.0.4"
   },
   "optionalDependencies": {

package.json

@@ -1 +1 @@
-exports.blubb = 123;
+exports.blubb = 123;

test/fixtures/async-code.js

@@ -12,7 +12,7 @@ test('a', 2, function(assert){
     }, 100);
 });
 
-test('2', 1, function (){
+test('2', 1, function (assert){
     assert.ok(true, "tests intermixing sync and async tests #2");
 });