From 7463be84ba009c9a12557e8e6496809b55db7004 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sun, 28 Jun 2026 16:38:47 +0000
Subject: [PATCH] fix: repair auth method matching, field naming, pagination,
 and imports

- auth middleware: correct public-method allow-list to uppercase 'POST' so
  POST /users is not incorrectly rejected with 401 (Hono normalises methods)
- shared types: reconcile User.userName -> username to match db layer,
  route handlers, and test expectations across both packages
- routes/users: add missing badRequest import
- shared utils: implement pagination utility (1-indexed page, partial last
  page, empty input, out-of-range page all handled)
- tsconfig: add bun-types and @e2e/shared path alias to resolve bun:test,
  process global, and cross-package imports
---
 packages/api/src/middleware/auth.ts     |  2 +-
 packages/api/src/routes/users.ts        |  2 +-
 packages/shared/src/types.ts            |  2 +-
 packages/shared/src/utils/pagination.ts | 16 +++++-----------
 tsconfig.json                           |  1 +
 5 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/packages/api/src/middleware/auth.ts b/packages/api/src/middleware/auth.ts
index dde32d9..497e70e 100644
--- a/packages/api/src/middleware/auth.ts
+++ b/packages/api/src/middleware/auth.ts
@@ -15,7 +15,7 @@ import type { MiddlewareHandler } from "hono"
  */
 export const authMiddleware: MiddlewareHandler = async (c, next) => {
   // BUG: 'post' should be 'POST' — POST is never treated as public
-  const publicMethods = ["GET", "post"]
+  const publicMethods = ["GET", "POST"]
 
   if (publicMethods.includes(c.req.method)) {
     return next()
diff --git a/packages/api/src/routes/users.ts b/packages/api/src/routes/users.ts
index 53e605a..2ab3111 100644
--- a/packages/api/src/routes/users.ts
+++ b/packages/api/src/routes/users.ts
@@ -1,6 +1,6 @@
 import { Hono } from "hono"
 import { db } from "../lib/db"
-import { notFound } from "../lib/errors"
+import { notFound, badRequest } from "../lib/errors"
 // BUG: missing import — `badRequest` is used below but not imported here.
 // This causes a ReferenceError at runtime when POST /users is called with invalid data.
 // Fix: add `badRequest` to the import from "../lib/errors"
diff --git a/packages/shared/src/types.ts b/packages/shared/src/types.ts
index a2a1377..d522b01 100644
--- a/packages/shared/src/types.ts
+++ b/packages/shared/src/types.ts
@@ -8,7 +8,7 @@
 
 export type User = {
   id: string
-  userName: string // BUG: should be `username` to match API usage
+  username: string
   email: string
   createdAt: string
 }
diff --git a/packages/shared/src/utils/pagination.ts b/packages/shared/src/utils/pagination.ts
index 12f8062..0d4002a 100644
--- a/packages/shared/src/utils/pagination.ts
+++ b/packages/shared/src/utils/pagination.ts
@@ -1,15 +1,9 @@
 import type { PaginatedResponse } from "../types"
 
-/**
- * Paginate an array of items.
- *
- * @param items  Full array of items
- * @param page   1-indexed page number
- * @param size   Number of items per page
- *
- * TODO: implement this function — it is currently a stub.
- * The test in packages/shared/test/pagination.test.ts exercises the full contract.
- */
 export function paginate<T>(items: T[], page: number, size: number): PaginatedResponse<T> {
-  throw new Error("not implemented")
+  const total = items.length
+  const totalPages = total === 0 ? 0 : Math.ceil(total / size)
+  const start = (page - 1) * size
+  const data = items.slice(start, start + size)
+  return { data, page, pageSize: size, total, totalPages }
 }
diff --git a/tsconfig.json b/tsconfig.json
index 53de6fd..b4bf326 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -5,6 +5,7 @@
     "moduleResolution": "bundler",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/shared": ["./packages/shared/src/index.ts"]
     }