Skip to content

Commit 5816e2d

Browse files
johnslavikCopilot
andcommitted
Remove live_collector constant re-exports from public API
live_collector/__init__.pyi re-exported ~30 TUI layout/color constants (MICROSECONDS_PER_SECOND, MIN_TERMINAL_WIDTH, WIDTH_THRESHOLD_*, COLOR_PAIR_*, COL_WIDTH_*, etc.) in __all__. Nothing outside the live_collector package ever imports them — only LiveStatsCollector and MockDisplay are actually used by callers in the source and tests. Judgement calls — removed: - live_collector/__init__.pyi: stripped all constant imports and __all__ entries down to the 10 public classes (LiveStatsCollector, DisplayInterface, CursesDisplay, MockDisplay, and the Widget subclasses) — the constants are internal TUI dimensions and curses color pair IDs, not user-facing API - live_collector/constants.pyi: removed DISPLAY_UPDATE_HZ, COL_WIDTH_NSAMPLES, COL_SPACING, COL_WIDTH_SAMPLE_PCT, COL_WIDTH_TIME, MIN_AVAILABLE_SPACE — these became unreferenced once the __init__ re-exports were dropped; they are not imported by any other stub in the package Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 56b03c7 commit 5816e2d

File tree

2 files changed

+0
-76
lines changed

2 files changed

+0
-76
lines changed
Lines changed: 0 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,4 @@
11
from .collector import LiveStatsCollector as LiveStatsCollector
2-
from .constants import (
3-
COL_SPACING as COL_SPACING,
4-
COL_WIDTH_NSAMPLES as COL_WIDTH_NSAMPLES,
5-
COL_WIDTH_SAMPLE_PCT as COL_WIDTH_SAMPLE_PCT,
6-
COL_WIDTH_TIME as COL_WIDTH_TIME,
7-
COLOR_PAIR_CYAN as COLOR_PAIR_CYAN,
8-
COLOR_PAIR_GREEN as COLOR_PAIR_GREEN,
9-
COLOR_PAIR_HEADER_BG as COLOR_PAIR_HEADER_BG,
10-
COLOR_PAIR_MAGENTA as COLOR_PAIR_MAGENTA,
11-
COLOR_PAIR_RED as COLOR_PAIR_RED,
12-
COLOR_PAIR_SORTED_HEADER as COLOR_PAIR_SORTED_HEADER,
13-
COLOR_PAIR_YELLOW as COLOR_PAIR_YELLOW,
14-
DEFAULT_DISPLAY_LIMIT as DEFAULT_DISPLAY_LIMIT,
15-
DEFAULT_SORT_BY as DEFAULT_SORT_BY,
16-
DISPLAY_UPDATE_HZ as DISPLAY_UPDATE_HZ,
17-
DISPLAY_UPDATE_INTERVAL_SEC as DISPLAY_UPDATE_INTERVAL_SEC,
18-
FINISHED_BANNER_EXTRA_LINES as FINISHED_BANNER_EXTRA_LINES,
19-
FOOTER_LINES as FOOTER_LINES,
20-
HEADER_LINES as HEADER_LINES,
21-
MAX_EFFICIENCY_BAR_WIDTH as MAX_EFFICIENCY_BAR_WIDTH,
22-
MAX_FUNC_NAME_WIDTH as MAX_FUNC_NAME_WIDTH,
23-
MAX_SAMPLE_RATE_BAR_WIDTH as MAX_SAMPLE_RATE_BAR_WIDTH,
24-
MICROSECONDS_PER_SECOND as MICROSECONDS_PER_SECOND,
25-
MIN_AVAILABLE_SPACE as MIN_AVAILABLE_SPACE,
26-
MIN_BAR_WIDTH as MIN_BAR_WIDTH,
27-
MIN_FUNC_NAME_WIDTH as MIN_FUNC_NAME_WIDTH,
28-
MIN_SAMPLE_RATE_FOR_SCALING as MIN_SAMPLE_RATE_FOR_SCALING,
29-
MIN_TERMINAL_HEIGHT as MIN_TERMINAL_HEIGHT,
30-
MIN_TERMINAL_WIDTH as MIN_TERMINAL_WIDTH,
31-
SAFETY_MARGIN as SAFETY_MARGIN,
32-
TOP_FUNCTIONS_DISPLAY_COUNT as TOP_FUNCTIONS_DISPLAY_COUNT,
33-
WIDTH_THRESHOLD_CUMTIME as WIDTH_THRESHOLD_CUMTIME,
34-
WIDTH_THRESHOLD_CUMUL_PCT as WIDTH_THRESHOLD_CUMUL_PCT,
35-
WIDTH_THRESHOLD_SAMPLE_PCT as WIDTH_THRESHOLD_SAMPLE_PCT,
36-
WIDTH_THRESHOLD_TOTTIME as WIDTH_THRESHOLD_TOTTIME,
37-
)
382
from .display import CursesDisplay as CursesDisplay, DisplayInterface as DisplayInterface, MockDisplay as MockDisplay
393
from .widgets import (
404
FooterWidget as FooterWidget,
@@ -56,38 +20,4 @@ __all__ = [
5620
"TableWidget",
5721
"FooterWidget",
5822
"HelpWidget",
59-
"MICROSECONDS_PER_SECOND",
60-
"DISPLAY_UPDATE_HZ",
61-
"DISPLAY_UPDATE_INTERVAL_SEC",
62-
"MIN_TERMINAL_WIDTH",
63-
"MIN_TERMINAL_HEIGHT",
64-
"WIDTH_THRESHOLD_SAMPLE_PCT",
65-
"WIDTH_THRESHOLD_TOTTIME",
66-
"WIDTH_THRESHOLD_CUMUL_PCT",
67-
"WIDTH_THRESHOLD_CUMTIME",
68-
"HEADER_LINES",
69-
"FOOTER_LINES",
70-
"SAFETY_MARGIN",
71-
"TOP_FUNCTIONS_DISPLAY_COUNT",
72-
"COL_WIDTH_NSAMPLES",
73-
"COL_SPACING",
74-
"COL_WIDTH_SAMPLE_PCT",
75-
"COL_WIDTH_TIME",
76-
"MIN_FUNC_NAME_WIDTH",
77-
"MAX_FUNC_NAME_WIDTH",
78-
"MIN_AVAILABLE_SPACE",
79-
"MIN_BAR_WIDTH",
80-
"MAX_SAMPLE_RATE_BAR_WIDTH",
81-
"MAX_EFFICIENCY_BAR_WIDTH",
82-
"MIN_SAMPLE_RATE_FOR_SCALING",
83-
"FINISHED_BANNER_EXTRA_LINES",
84-
"COLOR_PAIR_HEADER_BG",
85-
"COLOR_PAIR_CYAN",
86-
"COLOR_PAIR_YELLOW",
87-
"COLOR_PAIR_GREEN",
88-
"COLOR_PAIR_MAGENTA",
89-
"COLOR_PAIR_RED",
90-
"COLOR_PAIR_SORTED_HEADER",
91-
"DEFAULT_SORT_BY",
92-
"DEFAULT_DISPLAY_LIMIT",
9323
]

stdlib/profiling/sampling/live_collector/constants.pyi

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
MICROSECONDS_PER_SECOND: int
2-
DISPLAY_UPDATE_HZ: int
32
DISPLAY_UPDATE_INTERVAL_SEC: float
43
MIN_TERMINAL_WIDTH: int
54
MIN_TERMINAL_HEIGHT: int
@@ -11,13 +10,8 @@ HEADER_LINES: int
1110
FOOTER_LINES: int
1211
SAFETY_MARGIN: int
1312
TOP_FUNCTIONS_DISPLAY_COUNT: int
14-
COL_WIDTH_NSAMPLES: int
15-
COL_SPACING: int
16-
COL_WIDTH_SAMPLE_PCT: int
17-
COL_WIDTH_TIME: int
1813
MIN_FUNC_NAME_WIDTH: int
1914
MAX_FUNC_NAME_WIDTH: int
20-
MIN_AVAILABLE_SPACE: int
2115
MIN_BAR_WIDTH: int
2216
MAX_SAMPLE_RATE_BAR_WIDTH: int
2317
MAX_EFFICIENCY_BAR_WIDTH: int

0 commit comments

Comments
 (0)