Commit c22629d
authored
Disable GC freeze hack in parallel workers (#21207)
Unfortunately, this hack causes severe performance regression on Python
3.14, where GC works differently. A single freeze still works, but
repeated freezes are very slow.
This PR makes parallel self-check ~5% slower on Python 3.12, but doesn't
have any effect on `torch` (which however is not very parallelizeable).
But I think it is a safer bet to not do any aggressive GC manipulation
(beyond single freeze, which is kind of an established pattern).
We can tune it more later, when we are done with more "algorithmic"
improvements.1 parent 5666c91 commit c22629d
2 files changed
+7
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4383 | 4383 | | |
4384 | 4384 | | |
4385 | 4385 | | |
4386 | | - | |
4387 | | - | |
4388 | | - | |
| 4386 | + | |
4389 | 4387 | | |
4390 | 4388 | | |
4391 | 4389 | | |
| |||
4394 | 4392 | | |
4395 | 4393 | | |
4396 | 4394 | | |
4397 | | - | |
4398 | | - | |
4399 | 4395 | | |
4400 | 4396 | | |
4401 | 4397 | | |
4402 | 4398 | | |
4403 | 4399 | | |
4404 | 4400 | | |
4405 | 4401 | | |
4406 | | - | |
| 4402 | + | |
4407 | 4403 | | |
4408 | 4404 | | |
4409 | 4405 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
182 | 187 | | |
183 | 188 | | |
184 | 189 | | |
185 | 190 | | |
186 | 191 | | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | 192 | | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | 193 | | |
199 | 194 | | |
200 | 195 | | |
| |||
0 commit comments