Skip to content

Commit 0255da2

Browse files
committed
Refactor test setup to allow overriding of load_fixture with re-use of tree_on_path.
1 parent 3faf336 commit 0255da2

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

importlib_resources/tests/util.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -177,32 +177,30 @@ def setUp(self):
177177
self.fixtures.enter_context(import_helper.isolated_modules())
178178
self.data = self.load_fixture(self.MODULE)
179179

180+
def load_fixture(self, module):
181+
self.tree_on_path({module: fixtures[module]})
182+
return importlib.import_module(module)
183+
180184

181185
class ZipSetup(ModuleSetup):
182186
MODULE = 'data01'
183187

184-
def load_fixture(self, module):
188+
def tree_on_path(self, spec):
185189
temp_dir = self.fixtures.enter_context(os_helper.temp_dir())
186190
modules = pathlib.Path(temp_dir) / 'zipped modules.zip'
187191
self.fixtures.enter_context(
188-
import_helper.DirsOnSysPath(
189-
str(zip_.make_zip_file({module: fixtures[module]}, modules))
190-
)
192+
import_helper.DirsOnSysPath(str(zip_.make_zip_file(spec, modules)))
191193
)
192194

193-
return importlib.import_module(module)
194-
195195

196196
class DiskSetup(ModuleSetup):
197197
MODULE = 'data01'
198198

199-
def load_fixture(self, module):
199+
def tree_on_path(self, spec):
200200
temp_dir = self.fixtures.enter_context(os_helper.temp_dir())
201-
_path.build({module: fixtures[module]}, pathlib.Path(temp_dir))
201+
_path.build(spec, pathlib.Path(temp_dir))
202202
self.fixtures.enter_context(import_helper.DirsOnSysPath(temp_dir))
203203

204-
return importlib.import_module(module)
205-
206204

207205
class CommonTests(DiskSetup, CommonTestsBase):
208206
pass

0 commit comments

Comments
 (0)