Skip to content

Commit 1fea9c6

Browse files
johnslavikwillingc
andauthored
Apply suggestions from review
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
1 parent 3f2b045 commit 1fea9c6

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

getting-started/pull-request-lifecycle.rst

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ should do to help ensure that your pull request is accepted.
241241
#. **Keep your pull request focused and small.** A pull request should address
242242
one issue or add one feature. Combining multiple unrelated changes makes a
243243
pull request harder to review and increases the number of people notified
244-
unnecessarily. When in doubt, split into separate pull requests.
244+
unnecessarily.
245245

246246
#. Proper :ref:`documentation <documenting>` additions/changes should be included.
247247

@@ -270,16 +270,12 @@ See also `python/cpython#126133
270270
Typo fixes
271271
==========
272272

273-
Fixing typos and grammatical errors in documentation is a welcome
273+
Fixing typos and grammatical errors in documentation is a
274274
contribution that does not require a linked issue. The most appropriate
275-
places for such fixes are:
275+
place for such fixes is the :cpy-file:`Doc/` directory (end-user documentation).
276276

277-
* The ``Doc/`` directory (end-user documentation)
278-
* Internal documentation, such as files in ``Misc/``
279-
* News entries under ``Misc/NEWS.d/``
280277

281-
Keep typo-fix PRs **small and focused**, ideally limited to one file or a
282-
small set of closely related files. Large PRs that touch many unrelated files
278+
Keep typo-fix PRs **small and focused**. Large PRs that touch many unrelated files
283279
notify a large number of reviewers unnecessarily and are harder to review.
284280
Large typo-fix PRs, or PRs touching directories outside those listed above,
285281
may be closed with a reference to this section.

0 commit comments

Comments
 (0)