Skip to content

Commit 09c68d2

Browse files
committed
gh-1448: Add PR size guidance to 'Making good PRs' section
1 parent eeef778 commit 09c68d2

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

getting-started/pull-request-lifecycle.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,11 @@ should do to help ensure that your pull request is accepted.
238238
changes, because there might be interferences unknown to you between your
239239
changes and some other part of the interpreter.
240240

241+
#. **Keep your pull request focused and small.** A pull request should address
242+
one issue or add one feature. Combining multiple unrelated changes makes a
243+
pull request harder to review and increases the number of people notified
244+
unnecessarily. When in doubt, split into separate pull requests.
245+
241246
#. Proper :ref:`documentation <documenting>` additions/changes should be included.
242247

243248

0 commit comments

Comments
 (0)