-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
Skip not properly propagated and wrongly shown as ok #139255
Copy link
Copy link
Open
Labels
3.10only security fixesonly security fixespendingThe issue will be closed if no feedback is providedThe issue will be closed if no feedback is providedstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Metadata
Metadata
Assignees
Labels
3.10only security fixesonly security fixespendingThe issue will be closed if no feedback is providedThe issue will be closed if no feedback is providedstdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Projects
Status
Todo
Bug report
Bug description:
I have just updated a testbench from python3.8 to python3.10. To display the status of the tests I use pydev in Eclipse.
With 3.10 skipped tests are not shown as skipped in the GUI.
I debugged and disected and found this PR as the cause:
#27831
The issue for it:
#89118
I have no deep understanding for the unittest code, but I think (and debugging shows) the reason it breaks is because we clear self._outcome before we commit (if this is the right term?) the data via stopTestRun()
I do not use the skipdecorator but raise a SkipTest Exception.
I am not totally sure if the behaviour is wanted or not. I could not find a report that has a similar problem.
Pinging @serhiy-storchaka because it was your PR and it seems you know the module quite well. I could probably write a Patch so that it works for me, but I have no idea if I am just using something wrong. If you need any additional infos I am glad to help.
CPython versions tested on:
3.10
Operating systems tested on:
Windows