tkinter missing -nolinestop on tk.Text

[r4ph43l-glitch]

Bug report

Bug description:

# current tkinter/__init__.py

class Text(...):
[...]
    def search(self, pattern, index, stopindex=None,
           forwards=None, backwards=None, exact=None,
           regexp=None, nocase=None, count=None, elide=None):
[...]

The current tkinter implementation of the tkinter.Text.search method misses use of tcl options:
-nolinestop
-all
-overlap
-strictlimits

Is there any reason on why it is not inside the CPython implementation?

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs

• gh-130693: Add options of the tkinter.Text.search method: -nolinestop -all -overlap -strictlimits #130848
• [3.14] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) #141669
• [3.13] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) (GH-141669) #141670

[sharktide]

I'll see if I can make a pr

[sharktide]

Almost done, I have to write unittests.

[sharktide]

is currently avalible at https://github.com/sharktide/cpython/tree/patch-130693

[sharktide]

I am currently pinging this issue as I have not seen a review for nearly a month. Could someone please review soon?

PR: gh-130848

[serhiy-storchaka]

For -all, it would be more Pythonic to add a separate method search_all() which returns a list or a tuple.

[sharktide]

For -all, it would be more Pythonic to add a separate method search_all() which returns a list or a tuple.

on it