Tomas's feedback

Author: StanFromIreland

Lib/gettext.py

@@ -492,10 +492,10 @@ def find(domain, localedir=None, languages=None, all=False):
         localedir = _default_localedir
     if languages is None:
         languages = []
-        if os.environ.get('LANGUAGE'):
-            languages = os.environ.get('LANGUAGE').split(',')
-        elif locale.getlocale() != (None, None):
-            languages.append(".".join(filter(None, locale.getlocale())))
+        if val := os.environ.get('LANGUAGE'):
+            languages = val.split(':')
+        elif (loc := locale.getlocale()) != (None, None):
+            languages.append(".".join(filter(None, loc)))
         else:
             for envar in ('LC_ALL', 'LC_MESSAGES', 'LANG'):
                 val = os.environ.get(envar)

Lib/test/test_gettext.py

@@ -748,6 +748,13 @@ def test_find_with_env_vars(self, patch_getlocale):
                                   localedir=os.path.join(self.tempdir, "locale"))
             self.assertEqual(result, mo_file)
             self.env.unset(var)
+        # test fallbacks
+        for var in ('LANGUAGE', 'LC_ALL', 'LC_MESSAGES', 'LANG'):
+            self.env.set(var, 'es_ES:ga_IE:fr_FR')
+            result = gettext.find("mofile",
+                                  localedir=os.path.join(self.tempdir, "locale"))
+            self.assertEqual(result, mo_file)
+            self.env.unset(var)
 
     @unittest.mock.patch("locale.getlocale", return_value=('ga_IE', 'UTF-8'))
     def test_process_vars_override(self, patch_getlocale):