Fix: Add update method to SimpleNamespace

Author: Tomas Correia

Objects/namespaceobject.c

@@ -246,17 +246,51 @@ namespace_replace(PyObject *self, PyObject *args, PyObject *kwargs)
 }
 
 static PyObject *namespace_update(PyObject *self, PyObject *args, PyObject *kwds);
+static PyObject *
+namespace_update(PyObject *self, PyObject *args, PyObject *kwargs)
+{
+    PyObject *update_obj = NULL;
+
+    if (!PyArg_UnpackTuple(args, "update", 0, 1, &update_obj)) {
+        return NULL;
+    }
+
+    _PyNamespaceObject *ns = (_PyNamespaceObject *)self;
+    PyObject *dict = ns->ns_dict;
+    Py_INCREF(dict);
+
+    if (update_obj != NULL) {
+        if (PyDict_Update(dict, update_obj) < 0) {
+            Py_DECREF(dict);
+            return NULL;
+        }
+    }
+
+    if (kwargs && PyDict_Update(dict, kwargs) < 0) {
+        Py_DECREF(dict);
+        return NULL;
+    }
+
+    Py_DECREF(dict);
+    Py_RETURN_NONE;
+}
+
+
 
 static PyMethodDef namespace_methods[] = {
     {"__reduce__", namespace_reduce, METH_NOARGS,
      namespace_reduce__doc__},
     {"__replace__", _PyCFunction_CAST(namespace_replace), METH_VARARGS|METH_KEYWORDS,
      PyDoc_STR("__replace__($self, /, **changes)\n--\n\n"
         "Return a copy of the namespace object with new values for the specified attributes.")},
-    {"update", (PyCFunction)(void(*)(void))namespace_update,
-     METH_VARARGS | METH_KEYWORDS,
-     PyDoc_STR("update(**kwargs)\n--\n\nUpdate namespace attributes from keyword arguments.")
-    },
+    
+    {"update", (PyCFunction)(PyCFunctionWithKeywords)namespace_update, METH_VARARGS | METH_KEYWORDS,
+     PyDoc_STR("update(self, mapping=(), /, **kwargs)\n--\n\n"
+           "Update the namespace with the given keyword arguments.")},
+
+    {NULL, NULL}  /* sentinel */
+
+
 
 };
 
@@ -327,27 +361,7 @@ _PyNamespace_New(PyObject *kwds)
     return (PyObject *)ns;
 }
 
-#include "Python.h"
-
-static PyObject *
-namespace_update(PyObject *self, PyObject *args, PyObject *kwds)
-{
-    if (kwds == NULL) {
-        Py_RETURN_NONE;
-    }
-
-    PyObject *dict = PyObject_GetAttrString(self, "__dict__");
-    if (dict == NULL) {
-        return NULL;
-    }
 
-    int result = PyDict_Update(dict, kwds);
-    Py_DECREF(dict);
 
-    if (result < 0) {
-        return NULL;
-    }
 
-    Py_RETURN_NONE;
-}