Skip to content

Commit d440b54

Browse files
authored
Update test_http_cookiejar.py
1 parent 09f5a61 commit d440b54

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

Lib/test/test_http_cookiejar.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
CookieJar, DefaultCookiePolicy, LWPCookieJar, MozillaCookieJar,
1717
LoadError, lwp_cookie_str, DEFAULT_HTTP_PORT, escape_path,
1818
reach, is_HDN, domain_match, user_domain_match, request_path,
19-
request_port, request_host)
19+
request_port, request_host, is_ip)
2020

2121
mswindows = (sys.platform == "win32")
2222

@@ -867,6 +867,18 @@ def test_is_HDN(self):
867867
self.assertFalse(is_HDN(".foo.bar.com"))
868868
self.assertFalse(is_HDN("..foo"))
869869
self.assertFalse(is_HDN("foo."))
870+
871+
def test_is_ip(self):
872+
self.assertTrue(is_ip('[::1]'))
873+
self.assertTrue(is_ip('::1'))
874+
self.assertTrue(is_ip('[2001:db8:85a3::8a2e:370:7334]'))
875+
self.assertTrue(is_ip('2001:db8:85a3::8a2e:370:7334'))
876+
self.assertTrue(is_ip('192.168.0.1'))
877+
self.assertFalse(is_ip('256.256.256.256'))
878+
self.assertFalse(is_ip('[::2001:db8:85a3::]'))
879+
self.assertFalse(is_ip('acme.com'))
880+
self.assertFalse(is_ip(''))
881+
870882

871883
def test_reach(self):
872884
self.assertEqual(reach("www.acme.com"), ".acme.com")
@@ -915,7 +927,7 @@ def test_domain_match(self):
915927
# not both HDNs, so must string-compare equal to match
916928
self.assertTrue(user_domain_match("192.168.1.1", "192.168.1.1"))
917929
self.assertTrue(user_domain_match("[::1]", "[::1]"))
918-
self.assertTrue(domain_match("[2001:db8:85a3::8a2e:370:7334]", "[2001:db8:85a3::8a2e:370:7334]"))
930+
self.assertTrue(domain_match("2001:db8::", "2001:db8::"))
919931
self.assertFalse(user_domain_match("[::1]", "::1"))
920932
self.assertFalse(user_domain_match("192.168.1.1", ".168.1.1"))
921933
self.assertFalse(user_domain_match("192.168.1.1", "."))

0 commit comments

Comments
 (0)